diff options
author | Yilun Lin <yllin@google.com> | 2018-09-08 00:18:01 +0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-13 06:13:50 -0700 |
commit | 8faef60c20ae6ffa4414fe9f4b47e6d0d8597348 (patch) | |
tree | a48bf9d12fa51a45a6d6a92df965c3f6cac907d5 | |
parent | 5afb2520926c5b0205ce074afc29b92434b9033e (diff) | |
download | chrome-ec-8faef60c20ae6ffa4414fe9f4b47e6d0d8597348.tar.gz |
type: Rename size3_t to sizev3_t
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: I4fea3bb2c1781a91f1c12ad66f25382cc0be3611
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215446
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
-rw-r--r-- | common/mat33.c | 2 | ||||
-rw-r--r-- | include/mat33.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/common/mat33.c b/common/mat33.c index 17938c0c4f..d5d062b7ce 100644 --- a/common/mat33.c +++ b/common/mat33.c @@ -58,7 +58,7 @@ void mat33_swap_rows(mat33_t A, const size_t i, const size_t j) void mat33_get_eigenbasis(mat33_t S, floatv3_t e_vals, mat33_t e_vecs) { const size_t N = 3; - size3_t ind; + sizev3_t ind; size_t i, j, k, l, m; for (k = 0; k < N; ++k) { diff --git a/include/mat33.h b/include/mat33.h index 75c0d79366..5dd77cbdb9 100644 --- a/include/mat33.h +++ b/include/mat33.h @@ -11,7 +11,7 @@ #include "util.h" typedef float mat33_t[3][3]; -typedef size_t size3_t[3]; +typedef size_t sizev3_t[3]; void init_zero_matrix(mat33_t A); void init_diagonal_matrix(mat33_t A, float x); |