diff options
| author | Dino Li <Dino.Li@ite.com.tw> | 2020-12-24 14:07:43 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-12-29 03:06:40 +0000 |
| commit | c262d8e13669d669fbacff20391c65299a4a0d46 (patch) | |
| tree | ac8e19942819ce38bb66209d8b1fec0cb9c4a04e | |
| parent | 4553e910add49fb420a855d6db9a71ea95fb030b (diff) | |
| download | chrome-ec-c262d8e13669d669fbacff20391c65299a4a0d46.tar.gz | |
asurada: Ensure unused pins aren't floating to save power
BUG=b:173490375
BRANCH=none
TEST=save ~2mw on asurada.
Signed-off-by: Dino Li <Dino.Li@ite.com.tw>
Change-Id: I839e4b19b1c82583ae1c60ea2d6a463806bf4937
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2545917
Reviewed-by: Ayo Wu <ayowu@google.com>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
| -rw-r--r-- | board/asurada/gpio.inc | 40 |
1 files changed, 23 insertions, 17 deletions
diff --git a/board/asurada/gpio.inc b/board/asurada/gpio.inc index 9c5b3ebf17..f4bc1da2a8 100644 --- a/board/asurada/gpio.inc +++ b/board/asurada/gpio.inc @@ -36,6 +36,8 @@ GPIO_INT(LID_ACCEL_INT_L, PIN(J, 3), GPIO_INT_FALLING | GPIO_SEL_1P8V, #ifdef BOARD_ASURADA_REV0 GPIO_INT(ALS_RGB_INT_ODL, PIN(F, 0), GPIO_INT_FALLING, tcs3400_interrupt) +#else +GPIO(ALS_RGB_INT_ODL, PIN(F, 0), GPIO_INPUT) #endif /* USB-C interrupts */ @@ -132,26 +134,21 @@ ALTERNATE(PIN_MASK(I, 0x4F), 0, MODULE_ADC, 0) /* ADC 0,1,2,3,6 */ ALTERNATE(PIN_MASK(M, 0x33), 0, MODULE_SPI, 0) /* SPI */ /* Unimplemented Pins */ -UNIMPLEMENTED(PCH_SMI_L) -UNIMPLEMENTED(PCH_SCI_L) -UNIMPLEMENTED(PCH_WAKE_L) -UNIMPLEMENTED(PCH_PLTRST_L) - -#define UNIMPLEMENTED_GPIO(name, pin) UNIMPLEMENTED(name) - -UNIMPLEMENTED_GPIO(SET_VMC_VOLT_AT_1V8, PIN(D, 4)) -UNIMPLEMENTED_GPIO(EN_PP3000_VMC_PMU, PIN(D, 2)) -UNIMPLEMENTED_GPIO(PACKET_MODE_EN, PIN(A, 3)) +GPIO(SET_VMC_VOLT_AT_1V8, PIN(D, 4), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(EN_PP3000_VMC_PMU, PIN(D, 2), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(PACKET_MODE_EN, PIN(A, 3), GPIO_INPUT | GPIO_PULL_DOWN) /* b/160218054: behavior not defined */ -UNIMPLEMENTED_GPIO(USB_A0_FAULT_ODL, PIN(A, 7)) -UNIMPLEMENTED_GPIO(CHARGER_PROCHOT_ODL, PIN(C, 3)) -UNIMPLEMENTED_GPIO(PG_MT6315_GPU_ODL, PIN(H, 6)) -UNIMPLEMENTED_GPIO(EN_PP3000_SD_U, PIN(G, 1)) +/* *_ODL pin has external pullup so don't pull it down. */ +GPIO(USB_A0_FAULT_ODL, PIN(A, 7), GPIO_INPUT) +GPIO(CHARGER_PROCHOT_ODL, PIN(C, 3), GPIO_INPUT) +GPIO(PG_MT6315_GPU_ODL, PIN(H, 6), GPIO_INPUT) +GPIO(EN_PP3000_SD_U, PIN(G, 1), GPIO_INPUT | GPIO_PULL_DOWN) /* reserved for future use */ -UNIMPLEMENTED_GPIO(CCD_MODE_ODL, PIN(C, 4)) - -#undef UNIMPLEMENTED_GPIO +GPIO(CCD_MODE_ODL, PIN(C, 4), GPIO_INPUT) +/* NC pins, enable internal pull-up to avoid floating state. */ +GPIO(NC_GPI5, PIN(I, 5), GPIO_INPUT | GPIO_PULL_UP) +GPIO(NC_GPI7, PIN(I, 7), GPIO_INPUT | GPIO_PULL_UP) #ifdef BOARD_ASURADA_REV0 GPIO(NC_GPE5, PIN(E, 5), GPIO_INPUT | GPIO_PULL_UP) #else /* HAYATO */ @@ -159,3 +156,12 @@ GPIO(NC_GPM2, PIN(M, 2), GPIO_INPUT | GPIO_PULL_DOWN) #endif GPIO(NC_GPM3, PIN(M, 3), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(NC_GPM6, PIN(M, 6), GPIO_INPUT | GPIO_PULL_DOWN) +GPIO(SPI_CLK_GPG6, PIN(G, 6), GPIO_INPUT | GPIO_PULL_UP) +/* + * These 4 pins don't have internal pull-down capability, + * so we set them as output low. + */ +GPIO(NC_GPG3, PIN(G, 3), GPIO_OUT_LOW) +GPIO(SPI_MOSI_GPG4, PIN(G, 4), GPIO_OUT_LOW) +GPIO(SPI_MISO_GPG5, PIN(G, 5), GPIO_OUT_LOW) +GPIO(SPI_CS_GPG7, PIN(G, 7), GPIO_OUT_LOW) |