summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorParth Malkan <parthmalkan@google.com>2022-07-11 15:37:14 -0700
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-07-11 23:44:01 +0000
commite0fad9b5ffcaf2bc1b80771198bc1f6972191234 (patch)
tree8304c27b92a60eee614b8682a295ab8f56e55a1b
parentf877b4b8a462df91c4d1f9a526c5f7103edf37ea (diff)
downloadchrome-ec-e0fad9b5ffcaf2bc1b80771198bc1f6972191234.tar.gz
rgbkbd: Fix response size for rgbkbd host command
Default response size is set to 0 which breaks libec. Set the response size to sizeof(ec_response_rgbkbd) BRANCH=none BUG=none TEST=Test on Taniks Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I6a4fc9795a920e3823372b252e2e4d073013c3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3756734 Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org>
-rw-r--r--common/rgb_keyboard.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/common/rgb_keyboard.c b/common/rgb_keyboard.c
index 2bb5464a7d..5d92da688c 100644
--- a/common/rgb_keyboard.c
+++ b/common/rgb_keyboard.c
@@ -533,8 +533,7 @@ static enum ec_status hc_rgbkbd(struct host_cmd_handler_args *args)
struct ec_response_rgbkbd *r = args->response;
enum ec_status rv = EC_RES_SUCCESS;
- /* Default value is 0 */
- args->response_size = 0;
+ args->response_size = sizeof(*r);
if (rgbkbd_late_init())
return EC_RES_ERROR;
@@ -553,7 +552,6 @@ static enum ec_status hc_rgbkbd(struct host_cmd_handler_args *args)
rv = EC_RES_ERROR;
break;
case EC_RGBKBD_SUBCMD_GET_CONFIG:
- args->response_size = sizeof(*r);
r->rgbkbd_type = rgbkbd_type;
break;
default: