diff options
| author | Scott Collyer <scollyer@google.com> | 2021-04-28 07:38:05 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-05-04 18:05:58 +0000 |
| commit | e2921a619fb7b1ba980171ce327289265e44cc94 (patch) | |
| tree | 9745d089993283cf878e1cbf9e53a6ee657c99d7 | |
| parent | 6dda009c8a6701d6ec9722ea4819adc7a91906bf (diff) | |
| download | chrome-ec-e2921a619fb7b1ba980171ce327289265e44cc94.tar.gz | |
TCPMv2: Use board specific MF preference for DP Attention
Both DP Status and DP Attention messages contain a MF bit which allows
the UFP-D to signal to the DPF-D its multi-function
preference. Chromeos host machines only act on this bit in the DP
Status message. However, other host machines may also use this bit in
the DP Attention message.
This CL adds a call to a board specific policy function so that the MF
bit can be set correctly in both the DP Status and DP Attention
message.
BUG=b:186632734
BRANCH=quiche
TEST=ODM partner verifed that with this bit set in both DP Status and
DP Attention, the host machine will select pin configuraiton
D. Previously, the host machine was selecting pin configuration C.
Signed-off-by: Scott Collyer <scollyer@google.com>
Change-Id: I0242d2a5ad056ec210d7364b606528e4a54858c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2856290
Commit-Queue: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2871050
Tested-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
| -rw-r--r-- | common/usbc/usb_pd_dp_ufp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/usbc/usb_pd_dp_ufp.c b/common/usbc/usb_pd_dp_ufp.c index 2c651052e5..d2307a6025 100644 --- a/common/usbc/usb_pd_dp_ufp.c +++ b/common/usbc/usb_pd_dp_ufp.c @@ -100,7 +100,7 @@ static void hpd_to_dp_attention(void) (evt != hpd_low), /* HPD_HI|LOW */ 0, /* request exit DP */ 0, /* request exit USB */ - 0, /* MF pref */ + dock_get_mf_preference(), /* MF pref */ 1, /* enabled */ 0, /* power low */ 0x2); |