diff options
| author | Yilun Lin <yllin@google.com> | 2018-12-21 18:02:46 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-05-14 20:13:22 -0700 |
| commit | e6912d4794b8eccb4dca9e250f6a03b6f5903853 (patch) | |
| tree | 6e43993682415ca73088c2879ed0d1f0bd0c4441 | |
| parent | 6264b515814af52b403989557b9e14a1a699b460 (diff) | |
| download | chrome-ec-e6912d4794b8eccb4dca9e250f6a03b6f5903853.tar.gz | |
kukui: Enable interrupts from hall sensor.
Support hall covering/uncovering over lid close/open.
TEST=Emulate hall cover and see system goes down.
TEST=Emulate hall uncover and see system goes up.
BUG=b:111378000
BRANCH=None.
Change-Id: I56c0b45ba8b005c98877c2830e2320368788f04a
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1388236
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
| -rw-r--r-- | board/kukui/board.c | 6 | ||||
| -rw-r--r-- | board/kukui/board.h | 2 | ||||
| -rw-r--r-- | board/kukui/gpio.inc | 4 |
3 files changed, 4 insertions, 8 deletions
diff --git a/board/kukui/board.c b/board/kukui/board.c index 166ea32fe1..29263859e8 100644 --- a/board/kukui/board.c +++ b/board/kukui/board.c @@ -26,6 +26,7 @@ #include "hooks.h" #include "host_command.h" #include "i2c.h" +#include "lid_switch.h" #include "power.h" #include "power_button.h" #include "pwm.h" @@ -53,11 +54,6 @@ static void tcpc_alert_event(enum gpio_signal signal) schedule_deferred_pd_interrupt(0 /* port */); } -static void hall_interrupt(enum gpio_signal signal) -{ - /* TODO(b/111378000): Implement hall_interrupt */ -} - static void gauge_interrupt(enum gpio_signal signal) { task_wake(TASK_ID_CHARGER); diff --git a/board/kukui/board.h b/board/kukui/board.h index 262052fe8e..fd0352a78f 100644 --- a/board/kukui/board.h +++ b/board/kukui/board.h @@ -56,7 +56,6 @@ /* By default, set hcdebug to off */ #undef CONFIG_HOSTCMD_DEBUG_MODE #define CONFIG_HOSTCMD_DEBUG_MODE HCDEBUG_OFF -#undef CONFIG_LID_SWITCH #undef CONFIG_LTO #define CONFIG_POWER_BUTTON #define CONFIG_POWER_BUTTON_IGNORE_LID @@ -102,6 +101,7 @@ /* To be able to indicate the device is in tablet mode. */ #define CONFIG_TABLET_MODE #define CONFIG_TABLET_MODE_SWITCH +#define GPIO_LID_OPEN GPIO_HALL_INT_L /* FIFO size is in power of 2. */ #define CONFIG_ACCEL_FIFO 256 diff --git a/board/kukui/gpio.inc b/board/kukui/gpio.inc index 6f7630609e..eebe21587c 100644 --- a/board/kukui/gpio.inc +++ b/board/kukui/gpio.inc @@ -39,8 +39,8 @@ GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH, spi_event) GPIO_INT_RW(SYNC_INT, PIN(A, 8), GPIO_INT_RISING | GPIO_PULL_DOWN, sync_interrupt) -GPIO_INT(HALL_INT_L, PIN(C, 5), GPIO_INT_FALLING, - hall_interrupt) +GPIO_INT(HALL_INT_L, PIN(C, 5), GPIO_INT_BOTH, + lid_interrupt) GPIO_INT(GAUGE_INT_ODL, PIN(C, 9), GPIO_INT_FALLING | GPIO_PULL_UP, gauge_interrupt) GPIO_INT(POGO_ADC_INT_L, PIN(A, 6), GPIO_INT_BOTH | GPIO_ANALOG, |