summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDevin Lu <Devin.Lu@quantatw.com>2014-10-24 16:10:49 +0800
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2014-10-27 00:47:40 +0000
commitfb3ec1deef32e13632d930a7deb29d2fa92d7d86 (patch)
tree7ee1316f4af7aa5201ec44cf5b4e60ede7276ba4
parent8fc6f22b4d87d79b59e17c6b31a13256ab077354 (diff)
downloadchrome-ec-fb3ec1deef32e13632d930a7deb29d2fa92d7d86.tar.gz
Kip: Support force lid open
Factory test process need lid switch no function or keep lid opened BUG=chrome-os-partner:33281 BRANCH=kip TEST=Run command "ectool forcelidopen 1" and "reboot". Then lid close quickly, the system boot as lid opened. Deault value or run command "ectool forcelidopen 0" make the device normal. Change-Id: I407a28c6900a1f8aa9d3b01d4e83f6c4e1e88012 Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/225334 Reviewed-by: Chih-Wei Tsai <adam.tsai@quantatw.com> Tested-by: Chih-Wei Tsai <adam.tsai@quantatw.com> Reviewed-by: Mohammed Habibulla <moch@chromium.org>
-rw-r--r--common/lid_switch.c21
-rw-r--r--include/ec_commands.h10
-rw-r--r--util/ectool.c26
3 files changed, 56 insertions, 1 deletions
diff --git a/common/lid_switch.c b/common/lid_switch.c
index 80e3dbfbaa..e955965e92 100644
--- a/common/lid_switch.c
+++ b/common/lid_switch.c
@@ -21,6 +21,7 @@
#define LID_DEBOUNCE_US (30 * MSEC) /* Debounce time for lid switch */
static int debounced_lid_open; /* Debounced lid state */
+static int forced_lid_open; /* Forced lid open */
/**
* Get raw lid switch state.
@@ -29,7 +30,7 @@ static int debounced_lid_open; /* Debounced lid state */
*/
static int raw_lid_open(void)
{
- return gpio_get_level(GPIO_LID_OPEN) ? 1 : 0;
+ return (forced_lid_open || gpio_get_level(GPIO_LID_OPEN)) ? 1 : 0;
}
/**
@@ -125,3 +126,21 @@ DECLARE_CONSOLE_COMMAND(lidclose, command_lidclose,
NULL,
"Simulate lid close",
NULL);
+
+/**
+ * Host command to enable/disable lid opened.
+ */
+static int hc_force_lid_open(struct host_cmd_handler_args *args)
+{
+ const struct ec_params_force_lid_open *p = args->params;
+
+ /* Override lid open if necessary */
+ forced_lid_open = p->enabled ? 1 : 0;
+
+ /* Make this take effect immediately; no debounce time */
+ hook_call_deferred(lid_change_deferred, 0);
+
+ return EC_RES_SUCCESS;
+}
+DECLARE_HOST_COMMAND(EC_CMD_FORCE_LID_OPEN, hc_force_lid_open,
+ EC_VER_MASK(0));
diff --git a/include/ec_commands.h b/include/ec_commands.h
index 9a5c4ec68b..9238d037d8 100644
--- a/include/ec_commands.h
+++ b/include/ec_commands.h
@@ -1326,6 +1326,16 @@ struct ec_response_motion_sense {
} __packed;
/*****************************************************************************/
+/* Force lid open command */
+
+/* Make lid event always open */
+#define EC_CMD_FORCE_LID_OPEN 0x2c
+
+struct ec_params_force_lid_open {
+ uint8_t enabled;
+} __packed;
+
+/*****************************************************************************/
/* USB charging control commands */
/* Set USB port charging mode */
diff --git a/util/ectool.c b/util/ectool.c
index 4539d62e7c..8571fe84c7 100644
--- a/util/ectool.c
+++ b/util/ectool.c
@@ -86,6 +86,8 @@ const char help_str[] =
" Reads from EC flash to a file\n"
" flashwrite <offset> <infile>\n"
" Writes to EC flash from a file\n"
+ " forcelidopen <enable>\n"
+ " Forces the lid switch to open position\n"
" gpioget <GPIO name>\n"
" Get the value of GPIO signal\n"
" gpioset <GPIO name>\n"
@@ -3810,6 +3812,29 @@ struct command {
int (*handler)(int argc, char *argv[]);
};
+int cmd_force_lid_open(int argc, char *argv[])
+{
+ struct ec_params_force_lid_open p;
+ char *e;
+ int rv;
+
+ if (argc != 2) {
+ fprintf(stderr, "Usage: %s <0|1>\n", argv[0]);
+ return -1;
+ }
+ p.enabled = strtol(argv[1], &e, 0);
+ if (e && *e) {
+ fprintf(stderr, "Bad value.\n");
+ return -1;
+ }
+
+ rv = ec_command(EC_CMD_FORCE_LID_OPEN, 0, &p, sizeof(p), NULL, 0);
+ if (rv < 0)
+ return rv;
+ printf("Success.\n");
+ return 0;
+}
+
/* NULL-terminated list of commands */
const struct command commands[] = {
{"extpwrcurrentlimit", cmd_ext_power_current_limit},
@@ -3842,6 +3867,7 @@ const struct command commands[] = {
{"flashread", cmd_flash_read},
{"flashwrite", cmd_flash_write},
{"flashinfo", cmd_flash_info},
+ {"forcelidopen", cmd_force_lid_open},
{"gpioget", cmd_gpio_get},
{"gpioset", cmd_gpio_set},
{"hangdetect", cmd_hang_detect},