diff options
| author | Peter Marheine <pmarheine@chromium.org> | 2020-12-30 16:54:19 +1100 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-01-05 00:51:24 +0000 |
| commit | 45de6930052039b25a980b5eacaf6309cba946b1 (patch) | |
| tree | dd23e4bab007762b92159ba9e59acf13e376d7a3 /baseboard/zork | |
| parent | 5ff18dfd6ab67df2e62c6af9f20ed472808de707 (diff) | |
| download | chrome-ec-45de6930052039b25a980b5eacaf6309cba946b1.tar.gz | |
zork: use MKBP GPIO & host event for wake on DP
GPIO-only MKBP only works when the AP is awake; we need to use
GPIO_AND_HOST_EVENT in order to support waking the AP in response to
MKBP events; in particular DP_ALT_MODE_ENTERED.
We also configure the MKBP wakeup mask so powerd can apply configuration
at runtime per chromeos-config: if no mask is configured then the
hostcmd to set the wakeup mask is not included in the firmware.
Wake on MKBP (and thus wake on DP) also requires AP firmware support.
https://review.coreboot.org/c/coreboot/+/48844 implements it for Zork.
BUG=b:174121852
TEST=Generating DP event via EC console on morphius with patched AP
firmware successfully wakes system from S3.
BRANCH=zork
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: Ifb193399259674da17694aac5213bfd1f189ee59
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2607026
Reviewed-by: Edward Hill <ecgh@chromium.org>
Diffstat (limited to 'baseboard/zork')
| -rw-r--r-- | baseboard/zork/baseboard.h | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/baseboard/zork/baseboard.h b/baseboard/zork/baseboard.h index e31a0574ff..2a9827ca9a 100644 --- a/baseboard/zork/baseboard.h +++ b/baseboard/zork/baseboard.h @@ -263,8 +263,13 @@ #define I2C_ADDR_EEPROM_FLAGS 0x50 -/* Sensors */ #define CONFIG_MKBP_EVENT +/* Host event is required to wake from sleep */ +#define CONFIG_MKBP_USE_GPIO_AND_HOST_EVENT +/* Required to enable runtime configuration */ +#define CONFIG_MKBP_EVENT_WAKEUP_MASK (BIT(EC_MKBP_EVENT_DP_ALT_MODE_ENTERED)) + +/* Sensors */ #define CONFIG_DYNAMIC_MOTION_SENSOR_COUNT /* Thermal */ |