diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /board/atlas/board.c | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'board/atlas/board.c')
| -rw-r--r-- | board/atlas/board.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/atlas/board.c b/board/atlas/board.c index 3be1ebfb3d..e0fc4d07e7 100644 --- a/board/atlas/board.c +++ b/board/atlas/board.c @@ -274,7 +274,7 @@ static void board_report_pmic_fault(const char *str) BD99992GW_REG_RESETIRQ1, &vrfault) != EC_SUCCESS) return; - if (!(vrfault & (1 << 4))) + if (!(vrfault & BIT(4))) return; /* VRFAULT has occurred, print VRFAULT status bits. */ @@ -293,7 +293,7 @@ static void board_report_pmic_fault(const char *str) /* Clear all faults -- Write 1 to clear. */ i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, - BD99992GW_REG_RESETIRQ1, (1 << 4)); + BD99992GW_REG_RESETIRQ1, BIT(4)); i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, BD99992GW_REG_PWRSTAT1, pwrstat1); i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, |