diff options
| author | FelixTW_Chang <felixtw_chang@compal.corp-partner.google.com> | 2022-08-25 16:18:38 +0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-09-05 01:03:48 +0000 |
| commit | 73129997be8fff12c3a7038f84b4080dfbd65370 (patch) | |
| tree | 164e8e24bd1b2baf8dae515b7aa2c0697a9b5318 /board/banshee | |
| parent | 02b7a40359ad90b19997a229589ce81bbb94a756 (diff) | |
| download | chrome-ec-73129997be8fff12c3a7038f84b4080dfbd65370.tar.gz | |
Banshee: Modify LED behavior
This patch modify some behaviors:
1. Change pwr_led duty to 100.
2. Turn off pwr_led when lid close.
3. Change Charge LED color from Green to White
when battery fully charged.
4. Change RGB duty to mix White color.
BUG=b:220954645
BRANCH=None
TEST=check power and charge led behavior
Signed-off-by: FelixTW_Chang <felixtw_chang@compal.corp-partner.google.com>
Change-Id: I0dc6f64c6ae7bbda543bed12fbfdf1e90cebeb3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855654
Tested-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Diffstat (limited to 'board/banshee')
| -rw-r--r-- | board/banshee/led.c | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/board/banshee/led.c b/board/banshee/led.c index a94cef7889..130c2d969d 100644 --- a/board/banshee/led.c +++ b/board/banshee/led.c @@ -28,7 +28,7 @@ #define LED_TICKS_PER_CYCLE 10 #define LED_ON_TICKS 5 -#define BREATH_LIGHT_LENGTH 55 +#define BREATH_LIGHT_LENGTH 100 #define BREATH_HOLD_LENGTH 50 #define BREATH_OFF_LENGTH 200 @@ -54,7 +54,7 @@ struct pwm_led_color_map led_color_map[EC_LED_COLOR_COUNT] = { [EC_LED_COLOR_GREEN] = { 0, 50, 0 }, [EC_LED_COLOR_BLUE] = { 0, 0, 8 }, [EC_LED_COLOR_YELLOW] = { 40, 50, 0 }, - [EC_LED_COLOR_WHITE] = { 20, 50, 25 }, + [EC_LED_COLOR_WHITE] = { 4, 10, 5 }, [EC_LED_COLOR_AMBER] = { 45, 5, 0 }, }; @@ -96,8 +96,8 @@ DECLARE_DEFERRED(breath_led_pwm_deferred); /* * Breath LED API - * Max duty (percentage) = BREATH_LIGHT_LENGTH (55%) - * Fade time (second) = 550ms(In) / 550ms(Out) + * Max duty (percentage) = BREATH_LIGHT_LENGTH (100%) + * Fade time (second) = 1000ms(In) / 1000ms(Out) * Duration time (second) = BREATH_HOLD_LENGTH(500ms) * Interval time (second) = BREATH_OFF_LENGTH(2000ms) */ @@ -319,7 +319,7 @@ static void led_set_battery(void) -1); break; case PWR_STATE_CHARGE_NEAR_FULL: - set_active_port_color(EC_LED_COLOR_GREEN); + set_active_port_color(EC_LED_COLOR_WHITE); break; case PWR_STATE_IDLE: set_active_port_color(EC_LED_COLOR_AMBER); @@ -335,6 +335,12 @@ static void led_set_battery(void) static void led_set_power(void) { + /* turn off led when lid is close*/ + if (!lid_is_open()) { + set_pwr_led_color(PWM_LED1, -1); + return; + } + if (chipset_in_state(CHIPSET_STATE_ANY_SUSPEND)) { breath_led_run(1); return; |