diff options
| author | Jonathan Brandmeyer <jbrandmeyer@chromium.org> | 2018-08-24 14:30:35 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-07 18:36:37 -0700 |
| commit | a530eb162a6aab5db3dee940ba2718e5a1924f8a (patch) | |
| tree | 41e1f5fdc1db71eb13d1296d722b616380d887c1 /board/careena | |
| parent | 7fafaf999ff6d3b3565278a77fdba0a9ee1e26fe (diff) | |
| download | chrome-ec-a530eb162a6aab5db3dee940ba2718e5a1924f8a.tar.gz | |
grunt: Use higher priority TCPC interrupt tasks.
See also go/usb-pd-slow-response-time. Lift tcpc_alert_event interrupt
handler to baseboard.c to reduce duplication.
BUG=b:112848644, b:111909282
BRANCH=none
TEST=Observe response time after SrcCap to Sink Request is 15ms on
Careena and Grunt hardware after forcing a sysjump. Repeat test on
Careena Port 0 with the DB disconnected (containing Port 1), also 15ms.
Change-Id: I501bd86d84ba84eea0a705731e59e2431fc9a2ac
Signed-off-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1194669
Commit-Ready: Jett Rink <jettrink@chromium.org>
Tested-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'board/careena')
| -rw-r--r-- | board/careena/board.c | 16 | ||||
| -rw-r--r-- | board/careena/ec.tasklist | 4 |
2 files changed, 3 insertions, 17 deletions
diff --git a/board/careena/board.c b/board/careena/board.c index 1bae162930..2aec72f7c6 100644 --- a/board/careena/board.c +++ b/board/careena/board.c @@ -50,22 +50,6 @@ #define CPRINTS(format, args...) cprints(CC_USBCHARGE, format, ## args) #define CPRINTF(format, args...) cprintf(CC_USBCHARGE, format, ## args) -static void tcpc_alert_event(enum gpio_signal signal) -{ - if ((signal == GPIO_USB_C0_PD_INT_ODL) && - !gpio_get_level(GPIO_USB_C0_PD_RST_L)) - return; - - if ((signal == GPIO_USB_C1_PD_INT_ODL) && - !gpio_get_level(GPIO_USB_C1_PD_RST_L)) - return; - -#ifdef HAS_TASK_PDCMD - /* Exchange status with TCPCs */ - host_command_pd_send_status(PD_CHARGE_NO_CHANGE); -#endif -} - #ifdef CONFIG_USB_PD_TCPC_LOW_POWER static void anx74xx_cable_det_handler(void) { diff --git a/board/careena/ec.tasklist b/board/careena/ec.tasklist index be1dbcc21f..a4253b04c4 100644 --- a/board/careena/ec.tasklist +++ b/board/careena/ec.tasklist @@ -34,4 +34,6 @@ TASK_ALWAYS(POWERBTN, power_button_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(PD_C0, pd_task, NULL, LARGER_TASK_STACK_SIZE) \ - TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE) + TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE) \ + TASK_ALWAYS(PD_INT_C0, pd_interrupt_handler_task, 0, TASK_STACK_SIZE) \ + TASK_ALWAYS(PD_INT_C1, pd_interrupt_handler_task, 1, TASK_STACK_SIZE) |