diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-09-16 00:20:50 -0700 |
|---|---|---|
| committer | Justin TerAvest <teravest@chromium.org> | 2020-09-28 20:25:22 +0000 |
| commit | b3a033d2dfdc4bfe2b2e82207fea969cf3caee33 (patch) | |
| tree | d13d3f5c70e824e700eee89813a55fb70d37c286 /board/drawcia | |
| parent | 605ab1815625e377c902f4047a42e23ddd45debb (diff) | |
| download | chrome-ec-b3a033d2dfdc4bfe2b2e82207fea969cf3caee33.tar.gz | |
drawcia: Update OCPC PID constants
Since changing the approach of charging via the sub board on systems
that use the SM5803, we need to update the PID constants to work with
this new approach. This commit updates the constants for drawcia.
BUG=b:168253008
BRANCH=None
TEST=Build and flash drawcia and verify charging is working as
expected.
Change-Id: I8073aa240f90a0ba1ba3d2adabdc0e9fd12dfc6d
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2415512
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'board/drawcia')
| -rw-r--r-- | board/drawcia/board.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/board/drawcia/board.c b/board/drawcia/board.c index 9abd33f4f9..fe9bb0e940 100644 --- a/board/drawcia/board.c +++ b/board/drawcia/board.c @@ -644,12 +644,12 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, int *kd, int *kd_div) { - *kp = 1; - *kp_div = 6; + *kp = 3; + *kp_div = 14; - *ki = 0; - *ki_div = 1; + *ki = 3; + *ki_div = 500; - *kd = 0; - *kd_div = 1; + *kd = 4; + *kd_div = 40; } |