diff options
| author | Divya Sasidharan <divya.s.sasidharan@intel.com> | 2017-12-14 12:14:43 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-12-28 14:50:29 -0800 |
| commit | d41766df11888d07a630dc97de9ce8ce1f6a8f9a (patch) | |
| tree | 4239044270f4879d9251684026c6cb64f488baa4 /board/glkrvp | |
| parent | 304bb8b09c60a75ac8eae72ab017a5996b76afeb (diff) | |
| download | chrome-ec-d41766df11888d07a630dc97de9ce8ce1f6a8f9a.tar.gz | |
glkrvp: Fix hibernate <sec> to allow wakeup from hibernation
Issue was found when EC would not wake up from hibernate after
specified time period.
The infinite while loop blocks further hibernate functions
that needs to be executed after the board specific
hibernate method.
Remove this while loop to complete hibernation logic.
Also in hibernate function we should not be cutting down power
to EC (SMC_SHUTDOWN) as this will limit supporting wake sources
feature. Removing it in this patch.
BRANCH=master
BUG=b:70690772
TEST=On glkrvp EC console, check if "hibernate 30" wakes up EC
after 30 sec, with only battery, only AC, with AC+battery.
Change-Id: Iae735cc26eeef8e205771d2f3c6e5260918e093e
Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com>
Diffstat (limited to 'board/glkrvp')
| -rw-r--r-- | board/glkrvp/board.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/board/glkrvp/board.c b/board/glkrvp/board.c index 1038811f60..a8c9dcfd2f 100644 --- a/board/glkrvp/board.c +++ b/board/glkrvp/board.c @@ -153,12 +153,6 @@ void board_hibernate(void) /* Added delay to allow AP to settle down */ msleep(100); - - gpio_set_level(GPIO_SMC_SHUTDOWN, 1); - - /* Power to EC should shut down now */ - while (1) - ; } int board_get_version(void) |