diff options
| author | Philip Chen <philipchen@google.com> | 2019-08-15 18:24:22 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-09-19 03:47:09 +0000 |
| commit | 0beadf2ffd8b23e15d1e7c14de8719d0f45c9519 (patch) | |
| tree | 9b531ef5087e3935542560a4bc9b7cc379c3e843 /board/hammer | |
| parent | 16d2b24ac05f7a5654bddcf9cb61f0f6684d1806 (diff) | |
| download | chrome-ec-0beadf2ffd8b23e15d1e7c14de8719d0f45c9519.tar.gz | |
tablet_mode: Renaming for GMR sensor
GMR sensors can be used to
(1) detect clamshell/tablet mode
(2) detect lid open/closed
But hall sensors can only do (2).
Therefore the naming related to "hall sensor" for tablet mode
application is incorrect.
This patch performs the following renaming to better reflect the reality:
config:
CONFIG_HALL_SENSOR -> CONFIG_GMR_TABLET_MODE
CONFIG_HALL_SENSOR_CUSTOM -> CONFIG_GMR_TABLET_MODE_CUSTOM
CONFIG_DPTF_MOTION_LID_NO_HALL_SENSOR ->
CONFIG_DPTF_MOTION_LID_NO_GMR_SENSOR
GPIO:
HALL_SENSOR_GPIO_L -> GMR_TABLET_MODE_GPIO_L
functions:
hall_sensor_disable() -> gmr_tablet_switch_disable()
hall_sensor_isr() -> gmr_tablet_switch_isr()
hall_sensor_int() -> gmr_tablet_switch_init()
variable:
hall_sensor_at_360 -> gmr_sensor_at_360
BUG=b:139378190
BRANCH=none
TEST=make buildall
Change-Id: I28393d056ddd128d8ffafc16a1f9fefee5455ccc
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1757275
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Diffstat (limited to 'board/hammer')
| -rw-r--r-- | board/hammer/board.h | 2 | ||||
| -rw-r--r-- | board/hammer/gpio.inc | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/board/hammer/board.h b/board/hammer/board.h index 88627bd15a..87893e5f06 100644 --- a/board/hammer/board.h +++ b/board/hammer/board.h @@ -219,7 +219,7 @@ #ifdef CONFIG_HALL_SENSOR #define CONFIG_TABLET_MODE -#define HALL_SENSOR_GPIO_L GPIO_TABLET_MODE_L +#define GMR_TABLET_MODE_GPIO_L GPIO_TABLET_MODE_L #define CONFIG_KEYBOARD_TABLET_MODE_SWITCH #endif diff --git a/board/hammer/gpio.inc b/board/hammer/gpio.inc index 24c683f731..207045b868 100644 --- a/board/hammer/gpio.inc +++ b/board/hammer/gpio.inc @@ -12,9 +12,9 @@ #ifndef HAS_NO_TOUCHPAD GPIO_INT(TOUCHPAD_INT, PIN(B, 8), GPIO_INT_FALLING, touchpad_interrupt) #endif /* !HAS_NO_TOUCHPAD */ -#ifdef CONFIG_HALL_SENSOR -GPIO_INT(TABLET_MODE_L, PIN(B, 11), GPIO_PULL_UP | GPIO_INT_BOTH, hall_sensor_isr) -#endif /* CONFIG_HALL_SENSOR */ +#ifdef CONFIG_GMR_TABLET_MODE +GPIO_INT(TABLET_MODE_L, PIN(B, 11), GPIO_PULL_UP | GPIO_INT_BOTH, gmr_tablet_switch_isr) +#endif /* CONFIG_GMR_TABLET_MODE */ #endif /* SECTION_IS_RW */ /* Keyboard inputs */ |