summaryrefslogtreecommitdiff
path: root/board/kodama/led.c
diff options
context:
space:
mode:
authorDiana Z <dzigterman@chromium.org>2021-04-16 12:02:12 -0600
committerCommit Bot <commit-bot@chromium.org>2021-04-22 22:30:32 +0000
commit4746791009b75da679d44d45e8487c57c9191329 (patch)
tree5401e9c35f6bae95373f5fa472680813dc69d47f /board/kodama/led.c
parent7fa18f56441dd596927845198ea61dbe164d7a00 (diff)
downloadchrome-ec-4746791009b75da679d44d45e8487c57c9191329.tar.gz
LED On/Off: Remove power LED config
Move the LED on/off module towards using a more flexible LED support approach. Define a weak power LED table and setter for boards to override when needed. Note that during run-time these functions will not get called since led_auto_control_is_enabled() will return false for nonexistent LEDs. This consumes an average of 165 additional bytes of flash space on boards which do not use a power LED. BRANCH=None BUG=b:185508707 TEST=make -j buildall, load on guybrush (battery LED only) and confirm no errors are seen. Load on Boten (both LEDs) and confirm behavior appears normal Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Iaa1e22a7f5d8be39eb8792ee13d358087d7f7482 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2832691 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board/kodama/led.c')
-rw-r--r--board/kodama/led.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/board/kodama/led.c b/board/kodama/led.c
index 61d29f9d16..0b67553a7b 100644
--- a/board/kodama/led.c
+++ b/board/kodama/led.c
@@ -36,7 +36,7 @@ struct led_descriptor led_bat_state_table[LED_NUM_STATES][LED_NUM_PHASES] = {
{EC_LED_COLOR_GREEN, 2 * LED_ONE_SEC} },
};
-const struct led_descriptor
+__override const struct led_descriptor
led_pwr_state_table[PWR_LED_NUM_STATES][LED_NUM_PHASES] = {
[PWR_LED_STATE_ON] = {{EC_LED_COLOR_WHITE, LED_INDEFINITE} },
[PWR_LED_STATE_SUSPEND_AC] = {{EC_LED_COLOR_WHITE, 3 * LED_ONE_SEC},
@@ -66,7 +66,7 @@ static void led_set_color(int mask)
mt6370_led_set_color(led_mask);
}
-void led_set_color_power(enum ec_led_colors color)
+__override void led_set_color_power(enum ec_led_colors color)
{
if (color == EC_LED_COLOR_WHITE)
led_mask |= LED_MASK_WHITE;