diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-11-19 13:05:21 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-11-20 01:15:43 +0000 |
| commit | abf4fb8392c6674903a3778670a2fec0fe23c6c6 (patch) | |
| tree | 80192d36940ad4650b05eee9481778ae49b29b26 /board/spring | |
| parent | d72084463a00d29d6bedf03466500c7bcebec87d (diff) | |
| download | chrome-ec-abf4fb8392c6674903a3778670a2fec0fe23c6c6.tar.gz | |
spring: Increase stack for keyscan task
The keyscan task is short enough on stack space that turning on
keyboard debugging causes a stack overflow. This was previously not
the default, but https://chromium-review.googlesource.com/#/c/174373/
made it the default. Reverting that change just masks the problem;
enabling keyboard debugging on Spring would still cause a stack
overflow.
Rather than reverting that change, increase the stack size of the
keyscan task so that it doesn't overflow. There is sufficient space
to do this. Even after increasing the keyboard stack from 256 bytes to
320 bytes and doing a 'sysjump rw' to force jump tags to populate,
'shmem' reports 132 bytes free.
BUG=chrome-os-partner:23834
BRANCH=none
TEST=Boot Spring.
ksstate on
Bang on keyboard for a bit
taskinfo -> shows KEYSCAN task at 292/320 bytes free
sysjump rw
shmem -> shows 132 bytes free, 0 used
Change-Id: Idf9fdce5b9e6ca4d05d80a62ae9ea831ed508e3a
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/177355
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'board/spring')
| -rw-r--r-- | board/spring/ec.tasklist | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/spring/ec.tasklist b/board/spring/ec.tasklist index a842fb772f..4503bb2e95 100644 --- a/board/spring/ec.tasklist +++ b/board/spring/ec.tasklist @@ -23,4 +23,4 @@ TASK_NOTEST(CHIPSET, chipset_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(HOSTCMD, host_command_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(CONSOLE, console_task, NULL, TASK_STACK_SIZE) \ - TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, 256) + TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, 320) |