diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-09-27 09:11:48 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-09-27 23:07:21 +0000 |
| commit | 84ba1881208aa0fe56e7775958d95a8fa78f93c4 (patch) | |
| tree | 3a5059690586b13e18fa2f94dccb5e2f9b6df252 /board | |
| parent | 1e16031f75a9c84567b6bdb6fd5372234ac93fb3 (diff) | |
| download | chrome-ec-84ba1881208aa0fe56e7775958d95a8fa78f93c4.tar.gz | |
Support backlight control via lid only
The old backlight_x86 code did
(backlight enable) = (lid is open) && (GPIO request from AP)
Newer systems will AND those signals in hardware. Support those
systems by separating CONFIG_BACKLIGHT_LID and
CONFIG_BACKLIGHT_REQ_GPIO, and add tests for the case where the enable
signal is dependent only on the lid position.
BUG=chrome-os-partner:22960
BRANCH=none
TEST=pass unit tests
Change-Id: I1909426e49f00a8acd5047fd88c801cba1dacd76
Reviewed-on: https://chromium-review.googlesource.com/170925
Tested-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Commit-Queue: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/bolt/board.h | 3 | ||||
| -rw-r--r-- | board/link/board.h | 3 | ||||
| -rw-r--r-- | board/peppy/board.h | 3 | ||||
| -rw-r--r-- | board/rambi/board.h | 2 | ||||
| -rw-r--r-- | board/slippy/board.h | 3 |
5 files changed, 9 insertions, 5 deletions
diff --git a/board/bolt/board.h b/board/bolt/board.h index b74424d474..3f6f8b4891 100644 --- a/board/bolt/board.h +++ b/board/bolt/board.h @@ -29,7 +29,8 @@ #define CONFIG_BATTERY_LINK #define CONFIG_BATTERY_SMART -#define CONFIG_BACKLIGHT_X86 +#define CONFIG_BACKLIGHT_LID +#define CONFIG_BACKLIGHT_REQ_GPIO GPIO_PCH_BKLTEN #define CONFIG_CHARGER #define CONFIG_CHARGER_BQ24715 /* 10mOhm sense resitors. */ diff --git a/board/link/board.h b/board/link/board.h index f011003c22..3ff1749c41 100644 --- a/board/link/board.h +++ b/board/link/board.h @@ -9,7 +9,8 @@ #define __BOARD_H /* Optional features */ -#define CONFIG_BACKLIGHT_X86 +#define CONFIG_BACKLIGHT_LID +#define CONFIG_BACKLIGHT_REQ_GPIO GPIO_PCH_BKLTEN #define CONFIG_BATTERY_LINK #define CONFIG_BATTERY_SMART #define CONFIG_BATTERY_VENDOR_PARAMS diff --git a/board/peppy/board.h b/board/peppy/board.h index f98eab08ac..46d110d642 100644 --- a/board/peppy/board.h +++ b/board/peppy/board.h @@ -9,7 +9,8 @@ #define __BOARD_H /* Optional features */ -#define CONFIG_BACKLIGHT_X86 +#define CONFIG_BACKLIGHT_LID +#define CONFIG_BACKLIGHT_REQ_GPIO GPIO_PCH_BKLTEN #define CONFIG_BATTERY_CHECK_CONNECTED #define CONFIG_BATTERY_SMART #define CONFIG_BOARD_VERSION diff --git a/board/rambi/board.h b/board/rambi/board.h index 8c8ca0e684..9792d31e51 100644 --- a/board/rambi/board.h +++ b/board/rambi/board.h @@ -9,6 +9,7 @@ #define __BOARD_H /* Optional features */ +#define CONFIG_BACKLIGHT_LID #define CONFIG_BOARD_VERSION #define CONFIG_CMD_GSV #define CONFIG_EXTPOWER_GPIO @@ -23,7 +24,6 @@ /* TODO(rspangler): port these to Rambi, or remove if not needed */ #if 0 -#define CONFIG_BACKLIGHT_X86 #define CONFIG_BATTERY_CHECK_CONNECTED #define CONFIG_BATTERY_SMART #define CONFIG_CHARGER diff --git a/board/slippy/board.h b/board/slippy/board.h index 648f09a960..e56702adfe 100644 --- a/board/slippy/board.h +++ b/board/slippy/board.h @@ -9,7 +9,8 @@ #define __BOARD_H /* Optional features */ -#define CONFIG_BACKLIGHT_X86 +#define CONFIG_BACKLIGHT_LID +#define CONFIG_BACKLIGHT_REQ_GPIO GPIO_PCH_BKLTEN #define CONFIG_BATTERY_CHECK_CONNECTED #define CONFIG_BATTERY_SMART #define CONFIG_BOARD_VERSION |