diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 16:07:55 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:56 -0700 |
| commit | ac77140b7f4f42075d2377fc9d956a636b05aacf (patch) | |
| tree | c64c6a30916ff741a2ab235141f7bd071cd54483 /chip/ish/i2c.c | |
| parent | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (diff) | |
| download | chrome-ec-ac77140b7f4f42075d2377fc9d956a636b05aacf.tar.gz | |
common: bit change 1 << constants with BIT(constants)
Mechanical replacement of bit operation where operand is a constant.
More bit operation exist, but prone to errors.
Reveal a bug in npcx:
chip/npcx/system-npcx7.c:114:54: error: conversion from 'long unsigned int' to 'uint8_t' {aka 'volatile unsigned char'} changes value from '16777215' to '255' [-Werror=overflow]
BUG=None
BRANCH=None
TEST=None
Change-Id: I006614026143fa180702ac0d1cc2ceb1b3c6eeb0
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518660
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/ish/i2c.c')
| -rw-r--r-- | chip/ish/i2c.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chip/ish/i2c.c b/chip/ish/i2c.c index 525bee3732..79f0dd13de 100644 --- a/chip/ish/i2c.c +++ b/chip/ish/i2c.c @@ -335,7 +335,7 @@ int chip_i2c_xfer(int port, int slave_addr, const uint8_t *out, int out_size, if (in_size > (ISH_I2C_FIFO_SIZE - out_size)) { while ((i2c_mmio_read(ctx->base, IC_STATUS) & - (1 << IC_STATUS_TFE)) == 0) { + BIT(IC_STATUS_TFE)) == 0) { if (__hw_clock_source_read() >= expire_ts) { ctx->error_flag = 1; @@ -398,7 +398,7 @@ int chip_i2c_xfer(int port, int slave_addr, const uint8_t *out, int out_size, expire_ts = __hw_clock_source_read() + I2C_TSC_TIMEOUT; while (i2c_mmio_read(ctx->base, IC_STATUS) & - (1 << IC_STATUS_MASTER_ACTIVITY)) { + BIT(IC_STATUS_MASTER_ACTIVITY)) { if (__hw_clock_source_read() >= expire_ts) { ctx->error_flag = 1; |