diff options
| author | Denis Brockus <dbrockus@chromium.org> | 2019-06-25 12:44:16 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-07-19 21:11:02 +0000 |
| commit | d1a18f82ed831d4e640336ff5571f5fa64bc7b36 (patch) | |
| tree | c46aeb6136de1c27c66e3d5f662e9620161bef7b /common/i2c_trace.c | |
| parent | 1f14229fa7e499dfcee07d17add187598ff0a46c (diff) | |
| download | chrome-ec-d1a18f82ed831d4e640336ff5571f5fa64bc7b36.tar.gz | |
Use 7bit I2C/SPI slave addresses in EC
Opt for 7bit slave addresses in EC code. If 8bit is
expected by a driver, make it local and show this in
the naming.
Use __7b, __7bf and __8b as name extensions for i2c/spi
addresses used in the EC codebase. __7b indicates a
7bit address by itself. __7bf indicates a 7bit address
with optional flags attached. __8b indicates a 8bit
address by itself.
Allow space for 10bit addresses, even though this is
not currently being used by any of our attached
devices.
These extensions are for verification purposes only and
will be removed in the last pass of this ticket. I want
to make sure the variable names reflect the type to help
eliminate future 7/8/7-flags confusion.
BUG=chromium:971296
BRANCH=none
TEST=make buildall -j
Change-Id: I2fc3d1b52ce76184492b2aaff3060f486ca45f45
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1699893
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Diffstat (limited to 'common/i2c_trace.c')
| -rw-r--r-- | common/i2c_trace.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/common/i2c_trace.c b/common/i2c_trace.c index 52603c7244..ff237ed582 100644 --- a/common/i2c_trace.c +++ b/common/i2c_trace.c @@ -23,16 +23,17 @@ struct i2c_trace_range { static struct i2c_trace_range trace_entries[8]; -void i2c_trace_notify(int port, int slave_addr, int direction, - const uint8_t *data, size_t size) +void i2c_trace_notify__7bf(int port, uint16_t slave_addr__7bf, + int direction, const uint8_t *data, size_t size) { size_t i; + uint16_t addr__7b = I2C_GET_ADDR__7b(slave_addr__7bf); for (i = 0; i < ARRAY_SIZE(trace_entries); i++) if (trace_entries[i].enabled && trace_entries[i].port == port - && trace_entries[i].slave_addr_lo <= slave_addr - && trace_entries[i].slave_addr_hi >= slave_addr) + && trace_entries[i].slave_addr_lo <= addr__7b + && trace_entries[i].slave_addr_hi >= addr__7b) goto trace_enabled; return; @@ -40,7 +41,7 @@ trace_enabled: CPRINTF("i2c: %s %d:0x%X ", direction ? "read" : "write", port, - slave_addr); + addr__7b); for (i = 0; i < size; i++) CPRINTF("%02X ", data[i]); CPRINTF("\n"); |