summaryrefslogtreecommitdiff
path: root/common/switch.c
diff options
context:
space:
mode:
authorRandall Spangler <rspangler@chromium.org>2013-11-01 08:49:17 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2013-11-01 20:07:24 +0000
commit3266ae6a7e7539f7e124c15197118fc0d9e68489 (patch)
tree0784b4936653dfc50136ce68bb1b63c614555596 /common/switch.c
parentd7004207e5d809ff6bc4b6a0c6969fd3b277b886 (diff)
downloadchrome-ec-3266ae6a7e7539f7e124c15197118fc0d9e68489.tar.gz
cleanup: Even more TODO comments
Update comments with more info, or remove if no longer applicable. No code changes. BUG=chrome-os-partner:18343 BRANCH=none TEST=build all platforms; pass unit tests Change-Id: I5b56eeb500bc0f00e84e91ef99684f4b1b310972 Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/175418 Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'common/switch.c')
-rw-r--r--common/switch.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/common/switch.c b/common/switch.c
index a8cf4eaebd..7a15fb144f 100644
--- a/common/switch.c
+++ b/common/switch.c
@@ -84,8 +84,9 @@ static void switch_init(void)
#endif
/*
- * TODO(rspangler): It's weird that flash_common.c owns reading the
- * write protect signal, but we enable the interrupt for it here.
+ * TODO(crosbug.com/p/23793): It's weird that flash_common.c owns
+ * reading the write protect signal, but we enable the interrupt for it
+ * here. Take ownership of WP back, or refactor it to its own module.
*/
#ifdef CONFIG_WP_ACTIVE_HIGH
gpio_enable_interrupt(GPIO_WP);