diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2020-04-30 12:16:31 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-12 01:02:56 +0000 |
| commit | 5017fef617a6bdff3340a22915d2a79446591d7d (patch) | |
| tree | 9b18dfc02211aa969af28bbf42d899b31765a68a /common/usb_pd_console_cmd.c | |
| parent | af7303f8b929fa0fc11173a27a1fc16666706d9b (diff) | |
| download | chrome-ec-5017fef617a6bdff3340a22915d2a79446591d7d.tar.gz | |
TCPMv2: Define fields for SVID discovery state
Index discovery results by SOP type and track SVID discovery state for
each type. Define accessors for this state and modify existing accessors
to be SOP-type-aware.
BUG=b:152419850,b:152418267
TEST=make buildall; attach port partner; observe discovery via Twinkie
BRANCH=none
Change-Id: I24ee19aac087c5752a3a822ab2b0c9da7a55af1b
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2174464
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'common/usb_pd_console_cmd.c')
| -rw-r--r-- | common/usb_pd_console_cmd.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/common/usb_pd_console_cmd.c b/common/usb_pd_console_cmd.c index cbef79a1f1..22039eddc3 100644 --- a/common/usb_pd_console_cmd.c +++ b/common/usb_pd_console_cmd.c @@ -16,9 +16,11 @@ static void dump_pe(int port) int i, j, idh_ptype; struct svdm_amode_data *modep; uint32_t mode_caps; - struct pd_discovery *disc = pd_get_am_discovery(port); const union disc_ident_ack *resp; enum tcpm_transmit_type type; + /* TODO(b/152417597): Output SOP' discovery results */ + const struct pd_discovery *disc = + pd_get_am_discovery(port, TCPC_TX_SOP); static const char * const idh_ptype_names[] = { "UNDEF", "Hub", "Periph", "PCable", "ACable", "AMA", @@ -49,16 +51,17 @@ static void dump_pe(int port) ccprintf("\n"); } - if (disc->svid_cnt < 1) { + if (pd_get_svid_count(port, TCPC_TX_SOP) < 1) { ccprintf("No SVIDS discovered yet.\n"); return; } - for (i = 0; i < disc->svid_cnt; i++) { + /* TODO(b/152418267): Display discovered SVIDs and modes for SOP' */ + for (i = 0; i < pd_get_svid_count(port, TCPC_TX_SOP); i++) { ccprintf("SVID[%d]: %04x MODES:", i, disc->svids[i].svid); for (j = 0; j < disc->svids[j].mode_cnt; j++) ccprintf(" [%d] %08x", j + 1, - disc->svids[i].mode_vdo[j]); + disc->svids[i].mode_vdo[j]); ccprintf("\n"); modep = pd_get_amode_data(port, disc->svids[i].svid); |