diff options
| author | Jett Rink <jettrink@chromium.org> | 2018-08-17 13:33:02 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-07 18:36:36 -0700 |
| commit | e8070b44b088e99e38ec741ed8091c7e4a033bef (patch) | |
| tree | dedc7bce6201fba05b92f4e48ec4405366fbc76b /common/usb_pd_tcpc.c | |
| parent | e6a13850e9b5a6b2889549c03caddf2944e7fc63 (diff) | |
| download | chrome-ec-e8070b44b088e99e38ec741ed8091c7e4a033bef.tar.gz | |
tcpm: add TCPC RX circular buffer in EC
The alert line for TCPC will stay asserted as long as there are RX
messages for the TCPM (i.e. EC) to pull from the TCPC. We should clear
all of the RX messages we know about during a single alert handling
session.
This CL can stand on its own, but it is a part of a CL stack that will
tighten the critical section of time between received messages from the
TCPC and sending follow up message out through the TCPC.
See go/usb-pd-slow-response-time for more details.
BRANCH=none
BUG=b:112088135,b:112344286,b:111909282,b:112848644,b:113124761
BUG=b:113057273,b:112825261
TEST=Reduces reset issue in most cases for phaser, bobba. Does not seem to
adversely affect state machine negotiation. Full CL stack consistently
sends a REQUEST at 18ms after a SRC_CAP GoodCRC, which is well below the
24 ms threshold we need to be under for USB PD spec compliance.
Also testing pd_suspend scenario manually and EC was responsive after
port 1 suspend because of "bad behavior"
Change-Id: I1654b46400e9881f2927a5f6d6ace589edd182de
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1185727
Diffstat (limited to 'common/usb_pd_tcpc.c')
| -rw-r--r-- | common/usb_pd_tcpc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/usb_pd_tcpc.c b/common/usb_pd_tcpc.c index 9feb0ef2b1..152775bbc0 100644 --- a/common/usb_pd_tcpc.c +++ b/common/usb_pd_tcpc.c @@ -266,7 +266,7 @@ static int rx_buf_is_full(int port) return (diff == 1) || (diff == -RX_BUFFER_SIZE); } -static int rx_buf_is_empty(int port) +int rx_buf_is_empty(int port) { /* Buffer is empty if the head and tail are the same */ return pd[port].rx_buf_tail == pd[port].rx_buf_head; @@ -884,7 +884,7 @@ void pd_task(void *u) void pd_rx_event(int port) { - task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_RX, 0); + task_set_event(PD_PORT_TO_TASK_ID(port), TASK_EVENT_WAKE, 0); } int tcpc_alert_status(int port, int *alert) |