diff options
| author | Rob Barnes <robbarnes@google.com> | 2023-02-06 17:34:37 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-02-06 19:24:31 +0000 |
| commit | a7a972a19db68c6ee831daf150bb23dc4291cc61 (patch) | |
| tree | 8f24216d90ad3546c61ef09a1501185ea9fb7d24 /core | |
| parent | 0e94eecb89da262dda0b2bad81c2d6c5df0933f1 (diff) | |
| download | chrome-ec-a7a972a19db68c6ee831daf150bb23dc4291cc61.tar.gz | |
Revert "panic: Publish EC_HOST_EVENT_PANIC on panic"
This reverts commit 98e00bb45940f1cf31216a20c7441364d43fd8fb.
Reason for revert: On MKBP based boards, host_set_single_event will result in a mutex lock, which will fail when inside the panic ISR. See b/267681436.
Original change's description:
> panic: Publish EC_HOST_EVENT_PANIC on panic
>
> Publish EC_HOST_EVENT_PANIC when a panic occurs.
>
> The kernel may use this event to clean up before the system is reset
> (e.g. sync the drive).
>
> This will be a no-op if the kernel doesn't handle it.
>
> BUG=b:258195448
> BRANCH=None
> TEST=Observe event in kernel. Pass panic_event unit test.
>
> Change-Id: I34b9847778bf17dd113e81158bbbdf999ad2ca33
> Signed-off-by: Rob Barnes <robbarnes@google.com>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4063818
> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Bug: b:258195448
Change-Id: I772ef77ec7e4661f1c98658b94e73941ad74d4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4225911
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Ricardo Quesada <ricardoq@chromium.org>
Commit-Queue: Rob Barnes <robbarnes@google.com>
Auto-Submit: Rob Barnes <robbarnes@google.com>
Diffstat (limited to 'core')
| -rw-r--r-- | core/cortex-m/panic.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/core/cortex-m/panic.c b/core/cortex-m/panic.c index 7d364ec2a0..eefe068931 100644 --- a/core/cortex-m/panic.c +++ b/core/cortex-m/panic.c @@ -364,9 +364,6 @@ void __keep report_panic(void) if (IS_ENABLED(CONFIG_ARMV7M_CACHE)) cpu_clean_invalidate_dcache(); - if (IS_ENABLED(CONFIG_HOSTCMD_EVENTS)) - host_set_single_event(EC_HOST_EVENT_PANIC); - /* Start safe mode if possible */ if (IS_ENABLED(CONFIG_SYSTEM_SAFE_MODE)) { /* TODO: check for nested exceptions */ |