diff options
| author | Ting Shen <phoenixshen@google.com> | 2023-04-11 17:24:27 +0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-05-03 08:08:25 +0000 |
| commit | 1b6abaf157d0a9d0c76bf1ef5f11a188929f7ffe (patch) | |
| tree | 0259f7da31a2741eefbeb44c2c8ae22689eb04eb /driver | |
| parent | 4ce730711ac5e1272e4b0d23a24599f88a0c9840 (diff) | |
| download | chrome-ec-1b6abaf157d0a9d0c76bf1ef5f11a188929f7ffe.tar.gz | |
rt1739: fix init sequence and add es4 workaround
Fix following bugs for ES4
1. RT1739's soft reset disconnects ccd. Manually reset all touched
registers instead.
2. Implement the ES4 workaround in b:279550642 comment 5
BUG=b:275294155, b:279550642
TEST=check `ppc_dump 0` before and after this CL, make sure all
registers are the same.
LOW_COVERAGE_REASON=b:273854311 ongoing
Change-Id: I49c6189a69991fa23ebc46fc6ba93d7229c356fe
Signed-off-by: Ting Shen <phoenixshen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4413420
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Code-Coverage: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Tested-by: Yidi Lin <yidilin@chromium.org>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/ppc/rt1739.c | 18 | ||||
| -rw-r--r-- | driver/ppc/rt1739.h | 4 |
2 files changed, 14 insertions, 8 deletions
diff --git a/driver/ppc/rt1739.c b/driver/ppc/rt1739.c index edb54bb73c..ffd7760986 100644 --- a/driver/ppc/rt1739.c +++ b/driver/ppc/rt1739.c @@ -212,6 +212,12 @@ static int rt1739_workaround(int port) RT1739_HVLV_SCP_EN | RT1739_HVLV_OCRC_EN)); break; + case RT1739_DEVICE_ID_ES4: + CPRINTS("RT1739 ES4"); + RETURN_ERROR(update_reg(port, RT1739_REG_LVHVSW_OV_CTRL, + RT1739_OT_SEL_LVL, MASK_CLR)); + break; + default: CPRINTF("RT1739 unknown device id: %02X", device_id); break; @@ -295,21 +301,17 @@ static int rt1739_init(int port) RETURN_ERROR(write_reg(port, RT1739_REG_SYS_CTRL, RT1739_OT_EN | RT1739_SHUTDOWN_OFF)); } else if (batt_connected || !(vbus_switch_ctrl & RT1739_HV_SNK_EN)) { - /* - * If rt1739 is not sinking, or there's a working battery, - * we can reset its registers safely. - * - * Otherwise, don't touch the VBUS_SWITCH_CTRL reg. + /* b/275294155: reset vbus switch only instead of doing a full + * reset */ - RETURN_ERROR( - write_reg(port, RT1739_REG_SW_RESET, RT1739_SW_RESET)); - usleep(1 * MSEC); + RETURN_ERROR(write_reg(port, RT1739_REG_VBUS_SWITCH_CTRL, 0)); } RETURN_ERROR(write_reg(port, RT1739_REG_SYS_CTRL, RT1739_OT_EN | RT1739_SHUTDOWN_OFF)); RETURN_ERROR(rt1739_workaround(port)); RETURN_ERROR(rt1739_set_frs_enable(port, false)); + RETURN_ERROR(rt1739_set_vconn(port, false)); RETURN_ERROR(update_reg(port, RT1739_REG_VBUS_DET_EN, RT1739_VBUS_PRESENT_EN, MASK_SET)); RETURN_ERROR(update_reg(port, RT1739_REG_SBU_CTRL_01, diff --git a/driver/ppc/rt1739.h b/driver/ppc/rt1739.h index d2cf006564..f4c5e44354 100644 --- a/driver/ppc/rt1739.h +++ b/driver/ppc/rt1739.h @@ -19,6 +19,7 @@ #define RT1739_REG_DEVICE_ID0 0x02 #define RT1739_DEVICE_ID_ES1 0x11 #define RT1739_DEVICE_ID_ES2 0x12 +#define RT1739_DEVICE_ID_ES4 0x14 #define RT1739_REG_SW_RESET 0x04 #define RT1739_SW_RESET BIT(0) @@ -106,6 +107,9 @@ #define RT1739_REG_VCONN_CTRL3 0x33 #define RT1739_VCONN_CLIMIT_EN BIT(0) +#define RT1739_REG_LVHVSW_OV_CTRL 0x36 +#define RT1739_OT_SEL_LVL BIT(1) + #define RT1739_REG_SBU_CTRL_01 0x38 #define RT1739_SBUSW_MUX_SEL BIT(4) #define RT1739_SBU2_SWEN BIT(3) |