diff options
| author | Jeremy Bettis <jbettis@chromium.org> | 2022-11-08 23:37:45 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-11-09 15:45:01 +0000 |
| commit | 23c8f3cf3e17dafa7eaa4afc646183dca1570ee2 (patch) | |
| tree | 4373d388b68ad872b2d5207b865532cfc885d052 /firmware_builder.py | |
| parent | e615a219c1694276467dbfc5c0874ae50895ccb0 (diff) | |
| download | chrome-ec-23c8f3cf3e17dafa7eaa4afc646183dca1570ee2.tar.gz | |
Revert "cq: Run verbose make for better debugging"
This reverts commit 23fd725b83abdcb50eb99f69e6a4b102489ba3f7.
Reason for revert: The build output for EC is 109Mb. Too big.
Original change's description:
> cq: Run verbose make for better debugging
>
> There have been several mysterious failures in the CQ and it's hard to
> see what is going on since make doesn't print the commands by default.
>
> BRANCH=None
> BUG=b:257393779
> TEST=CQ
>
> Signed-off-by: Jeremy Bettis <jbettis@google.com>
> Change-Id: I4e4db7ef328b01f52d820405db036ef881d06405
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4005654
> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
> Tested-by: Jeremy Bettis <jbettis@chromium.org>
> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
> Commit-Queue: Al Semjonovs <asemjonovs@google.com>
Bug: b:257393779
Change-Id: I9fbde348c12ec77b2447a264d7190c3d75423958
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4014811
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
Commit-Queue: Al Semjonovs <asemjonovs@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Diffstat (limited to 'firmware_builder.py')
| -rwxr-xr-x | firmware_builder.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/firmware_builder.py b/firmware_builder.py index e24d87459e..ff7f524d78 100755 --- a/firmware_builder.py +++ b/firmware_builder.py @@ -74,11 +74,11 @@ def build(opts): ec_dir = pathlib.Path(__file__).parent subprocess.run([ec_dir / "util" / "check_clang_format.py"], check=True) - cmd = ["make", "clobber", "V=1"] + cmd = ["make", "clobber"] print(f"# Running {' '.join(cmd)}.") subprocess.run(cmd, cwd=os.path.dirname(__file__), check=True) - cmd = ["make", "buildall_only", f"-j{opts.cpus}", "V=1"] + cmd = ["make", "buildall_only", f"-j{opts.cpus}"] print(f"# Running {' '.join(cmd)}.") subprocess.run(cmd, cwd=os.path.dirname(__file__), check=True) @@ -239,7 +239,7 @@ def test(opts): # Otherwise, build the 'runtests' target, which verifies all # posix-based unit tests build and pass. target = "coverage" if opts.code_coverage else "runtests" - cmd = ["make", target, f"-j{opts.cpus}", "V=1"] + cmd = ["make", target, f"-j{opts.cpus}"] print(f"# Running {' '.join(cmd)}.") subprocess.run(cmd, cwd=os.path.dirname(__file__), check=True) @@ -247,13 +247,13 @@ def test(opts): # Verify compilation of the on-device unit test binaries. # TODO(b/172501728) These should build for all boards, but they've bit # rotted, so we only build the ones that compile. - cmd = ["make", f"-j{opts.cpus}", "V=1"] + cmd = ["make", f"-j{opts.cpus}"] cmd.extend(["tests-" + b for b in BOARDS_UNIT_TEST]) print(f"# Running {' '.join(cmd)}.") subprocess.run(cmd, cwd=os.path.dirname(__file__), check=True) # Verify the tests pass with ASan also - cmd = ["make", "TEST_ASAN=y", target, f"-j{opts.cpus}", "V=1"] + cmd = ["make", "TEST_ASAN=y", target, f"-j{opts.cpus}"] print(f"# Running {' '.join(cmd)}.") subprocess.run(cmd, cwd=os.path.dirname(__file__), check=True) |