diff options
| author | Jett Rink <jettrink@chromium.org> | 2019-03-20 07:29:22 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:43:27 -0700 |
| commit | 7c91b658c6c0c1ef9a08f2409190bbda0c2a0140 (patch) | |
| tree | 5d2557ff24e69ffd051ffa9196007e15a1132b77 /include/mkbp_event.h | |
| parent | 45bb97a58126aa943412c343bc4847e972d3b707 (diff) | |
| download | chrome-ec-7c91b658c6c0c1ef9a08f2409190bbda0c2a0140.tar.gz | |
mkbp: non-gpio-based mkbp events, leave interrupts
For non-gpio-based mkbp event delivery, we do not want to temporarily
disable interrupts as the code to send the mkbp events may use mutexes or
task scheduling to perform the more complicated mkbp event delivery.
For simple GPIO-based implementations, pausing interrupts gives the
mkbp_last_event_time marker the best chance at matching the actual time
the gpio was toggled on the EC. For other implementation, we are already
at the mercy of bus delays and timing for delivery so it wasn't as
reliable in that case to beginning with.
BRANCH=none
BUG=b:128862307
TEST=Ran AIDA64 sensor tab for a long time without seeing ISH
communication issue.
Change-Id: Id6e63a7f7b494559bd38b4659a580fa57666ecf1
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1531773
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Mathew King <mathewk@chromium.org>
Diffstat (limited to 'include/mkbp_event.h')
| -rw-r--r-- | include/mkbp_event.h | 29 |
1 files changed, 0 insertions, 29 deletions
diff --git a/include/mkbp_event.h b/include/mkbp_event.h index c1f3a238dc..c451c53673 100644 --- a/include/mkbp_event.h +++ b/include/mkbp_event.h @@ -29,35 +29,6 @@ extern uint32_t mkbp_last_event_time; int mkbp_send_event(uint8_t event_type); /* - * Set MKBP active event status on the AP. - * - * This communicates to the AP whether an MKBP event is currently available - * for processing. It is used by mkbp_send_event(). - * - * The default implementation in mkbp_event.c has weak linkage and can be - * overridden by individual boards depending on their hardware configuration. - * - * @param active 1 if there is an event, 0 otherwise - */ -void mkbp_set_host_active(int active); - -/* - * Communicate an MKBP event to the host via a dedicated GPIO pin. - * - * This can be used if the board schematic has a pin reserved for this purpose. - */ -void mkbp_set_host_active_via_gpio(int active); - -/* - * Communicate an MKBP event to the AP via EC_HOST_EVENT. - * - * This can be used without a dedicated interrupt pin configured. It is the - * default behavior of mkbp_set_host_active when CONFIG_MKBP_USE_HOST_EVENT - * is defined in board.h. - */ -void mkbp_set_host_active_via_event(int active); - -/* * Communicate an MKBP event to the AP via custom method. * * This can be used if a board has a custom method. |