diff options
| author | Shawn Nematbakhsh <shawnn@chromium.org> | 2016-06-15 12:49:51 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-06-16 12:27:42 -0700 |
| commit | 48435ece3b65cbec5e8edf68b9d790d66f8d23be (patch) | |
| tree | 14ba94a98e3be7e8f56a6c81fdc2988ae5474c15 /include/usb_charge.h | |
| parent | b12662080799859b326461ae498a10d61dd87e2e (diff) | |
| download | chrome-ec-48435ece3b65cbec5e8edf68b9d790d66f8d23be.tar.gz | |
bd99955: Improve interrupt / USB charger task wake scheme
Previously our charger ISR called a deferred task which woke our charger
task. We can skip the deferred task and just wake our charger task
directly.
The other meaningful change here is to assume that we're using the
charger for VBUS detection / BC1.2 if we have a usb_chg task, which
holds true for all of our current boards with this charger.
BUG=None
TEST=Manual on kevin with subsequent commit. Verify charger connect /
disconnect detection works properly on both ports, with zinger, donette
and generic DCP charger.
BRANCH=None
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: Iad4f3ea90947b50859c549b591675e325717209f
Reviewed-on: https://chromium-review.googlesource.com/352822
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'include/usb_charge.h')
| -rw-r--r-- | include/usb_charge.h | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/include/usb_charge.h b/include/usb_charge.h index 382f373f8a..34893eabf7 100644 --- a/include/usb_charge.h +++ b/include/usb_charge.h @@ -47,13 +47,7 @@ int usb_charge_set_mode(int usb_port_id, enum usb_charge_mode mode); */ int usb_charge_ports_enabled(void); -/* Events handled by the USB_CHG task */ -#ifdef HAS_TASK_USB_CHG -/* One task for all the ports */ -#define USB_CHG_EVENT_VBUS_P0 TASK_EVENT_CUSTOM(1) -#define USB_CHG_EVENT_VBUS_P1 TASK_EVENT_CUSTOM(2) -#elif defined(HAS_TASK_USB_CHG_P0) -/* One task per port */ +#ifdef HAS_TASK_USB_CHG_P0 #define USB_CHG_EVENT_BC12 TASK_EVENT_CUSTOM(1) #define USB_CHG_EVENT_VBUS TASK_EVENT_CUSTOM(2) #define USB_CHG_EVENT_INTR TASK_EVENT_CUSTOM(4) |