diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2019-05-03 12:48:41 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-05-15 13:36:18 -0700 |
| commit | aaba1d5efd51082d143ce2ac64e6caf9cb14d5e5 (patch) | |
| tree | 2f270d3141f77192078c6578ef78648491477779 /test/is_enabled_error.sh | |
| parent | 1598a615eb150916ea323e212b87298c3a6fcfb6 (diff) | |
| download | chrome-ec-aaba1d5efd51082d143ce2ac64e6caf9cb14d5e5.tar.gz | |
ec: common: Make IS_ENABLED fail on unknown values
If IS_ENABLED is called with any unknown values, a compiler error will be
thrown. This change requires that the optimizer always be enabled,
otherwise errors will be thrown when a value is not defined.
BUG=none
BRANCH=none
TEST=make runtests TEST_LIST_HOST="is_enabled_error is_enabled"
Change-Id: I1b166311f81d07e48b3665f4bc0e9502d2ccc4c6
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1592728
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'test/is_enabled_error.sh')
| -rw-r--r-- | test/is_enabled_error.sh | 40 |
1 files changed, 40 insertions, 0 deletions
diff --git a/test/is_enabled_error.sh b/test/is_enabled_error.sh new file mode 100644 index 0000000000..1e5407f31f --- /dev/null +++ b/test/is_enabled_error.sh @@ -0,0 +1,40 @@ +#!/bin/bash -e +# Copyright 2019 The Chromium OS Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +TEST_DIR="$(dirname "${BASH_SOURCE[0]}")" + +TEST_CMD="$(cat "${TEST_DIR}/RO/test/is_enabled_error.o.cmd")" + +TEST_ERROR_COUNT=0 + +for test_value in 0 1 2 A "5 + 5"; do + echo -n "Running TEST_VALUE=${test_value}..." + TEST_CMD_COMPLETE="${TEST_CMD} \"-DTEST_VALUE=${test_value}\"" + if BUILD_OUTPUT="$(sh -c "$TEST_CMD_COMPLETE" 2>&1)"; then + echo "Fail" + echo "Compilation should not have succeeded for" \ + "TEST_VALUE=${test_value}" + echo "$BUILD_OUTPUT" + TEST_ERROR_COUNT=$((TEST_ERROR_COUNT+1)) + continue + fi + + EXPECTED_ERROR="CONFIG_VALUE must be <blank>, or not defined" + if grep -q "$EXPECTED_ERROR" <<< "$BUILD_OUTPUT"; then + echo "OK" + else + echo "Fail" + echo "Expected to find: $EXPECTED_ERROR" + echo "Actual error:" + echo "$BUILD_OUTPUT" + TEST_ERROR_COUNT=$((TEST_ERROR_COUNT+1)) + fi +done + +if [[ $TEST_ERROR_COUNT -eq 0 ]]; then + echo "Pass!" +else + echo "Fail! (${TEST_ERROR_COUNT} tests)" +fi |