diff options
| author | Denis Brockus <dbrockus@google.com> | 2021-01-08 13:01:06 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-01-09 01:03:40 +0000 |
| commit | ba81125401ff0dde76d9a064e53f6ad76226f84c (patch) | |
| tree | 3fe02b1940bc2d68a29a7d91fa1ab3c5127720e2 /test/usb_tcpmv2_td_pd_src_e2.c | |
| parent | 48ce495e86a9b3702bd56e1b5a072cf2ae834d9b (diff) | |
| download | chrome-ec-ba81125401ff0dde76d9a064e53f6ad76226f84c.tar.gz | |
TCPMv2: Compliance Unit Test - TD.PD.SRC.E2 cleanup
cleanup message offsets to be more clear
BUG=none
BRANCH=none
TEST=make buildall
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I75971aa97742a878ffaa9f5885348a0512faad98
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2618569
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'test/usb_tcpmv2_td_pd_src_e2.c')
| -rw-r--r-- | test/usb_tcpmv2_td_pd_src_e2.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/test/usb_tcpmv2_td_pd_src_e2.c b/test/usb_tcpmv2_td_pd_src_e2.c index c4a1d7780b..c8b862db28 100644 --- a/test/usb_tcpmv2_td_pd_src_e2.c +++ b/test/usb_tcpmv2_td_pd_src_e2.c @@ -12,6 +12,8 @@ #include "usb_tc_sm.h" #define BUFFER_SIZE 100 + +#define HEADER_BYTE_OFFSET 1 #define HEADER_BYTE_CNT 2 #define PDO_BYTE_CNT 4 @@ -70,7 +72,7 @@ int test_td_pd_src_e2(void) EC_SUCCESS, "%d"); TEST_GE(msg_len, HEADER_BYTE_CNT, "%d"); - header = UINT16_FROM_BYTE_ARRAY_LE(data, 1); + header = UINT16_FROM_BYTE_ARRAY_LE(data, HEADER_BYTE_OFFSET); revision = PD_HEADER_REV(header); if (revision == REVISION_3) return EC_SUCCESS; @@ -101,7 +103,8 @@ int test_td_pd_src_e2(void) * 2. Voltage field = 100 (5 V) * 3. Bits 24..22 = 000b (Reserved) */ - pdo = UINT32_FROM_BYTE_ARRAY_LE(&data[2], 1); + pdo = UINT32_FROM_BYTE_ARRAY_LE(data, HEADER_BYTE_OFFSET + + HEADER_BYTE_CNT); type = pdo & PDO_TYPE_MASK; TEST_EQ(type, PDO_TYPE_FIXED, "%d"); @@ -129,8 +132,10 @@ int test_td_pd_src_e2(void) int offset; uint32_t voltage; - offset = HEADER_BYTE_CNT + (i * PDO_BYTE_CNT); - pdo = UINT32_FROM_BYTE_ARRAY_LE(&data[offset], 1); + offset = HEADER_BYTE_OFFSET + + HEADER_BYTE_CNT + + (i * PDO_BYTE_CNT); + pdo = UINT32_FROM_BYTE_ARRAY_LE(data, offset); type = pdo & PDO_TYPE_MASK; TEST_NE(type, PDO_TYPE_AUGMENTED, "%d"); |