diff options
| author | Simon Glass <sjg@chromium.org> | 2023-05-08 15:20:07 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-05-11 14:04:23 +0000 |
| commit | 67debcce5555daf1c24e1eada34f7607bf041308 (patch) | |
| tree | 2ff540cb25f3b08d127d01416f79235eb3022f23 /test | |
| parent | 7d727e6ec9d487530c909027adcaa0d91c9794d2 (diff) | |
| download | chrome-ec-67debcce5555daf1c24e1eada34f7607bf041308.tar.gz | |
charger: Rename enum charge_state to led_pwr_state
This name is confusing, since its members start with PWR_ and the
comment for enum charge_state_v2 says that these values are only used
to control the LEDs, with one not-quite-correct exception, whatever
that might be.
We could rename it to power_state, but that is already fairly widely
used as a variable in the code base. Also it seems better to match the
enum PWR_ prefix. Future work may rename the members too.
Rename the charge_state enum.
This makes no functional change.
BUG=b:218332694
TEST=make buildall
Change-Id: If8a7cc73dcfb4c1e89984e57fc55e432416e8aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4516187
Commit-Queue: Simon Glass <sjg@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'test')
| -rw-r--r-- | test/sbs_charging_v2.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/sbs_charging_v2.c b/test/sbs_charging_v2.c index f47e349672..0b12aea739 100644 --- a/test/sbs_charging_v2.c +++ b/test/sbs_charging_v2.c @@ -124,7 +124,7 @@ enum ec_status charger_profile_override_set_param(uint32_t param, test_static int wait_charging_state(void) { - enum charge_state state; + enum led_pwr_state state; task_wake(TASK_ID_CHARGER); msleep(WAIT_CHARGER_TASK); state = charge_get_state(); @@ -206,7 +206,7 @@ test_static void ev_clear(int event) test_static int test_charge_state(void) { - enum charge_state state; + enum led_pwr_state state; uint32_t flags; /* On AC */ @@ -519,7 +519,7 @@ test_static int test_external_funcs(void) #define CHG_OPT2 0x4000 test_static int test_hc_charge_state(void) { - enum charge_state state; + enum led_pwr_state state; int i, rv, tmp; struct ec_params_charge_state params; struct ec_response_charge_state resp; |