diff options
author | Jack Rosenthal <jrosenth@chromium.org> | 2021-11-04 12:11:58 -0600 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2021-11-05 04:22:34 +0000 |
commit | 252457d4b21f46889eebad61d4c0a65331919cec (patch) | |
tree | 01856c4d31d710b20e85a74c8d7b5836e35c3b98 /util/host_command_check.sh | |
parent | 08f5a1e6fc2c9467230444ac9b582dcf4d9f0068 (diff) | |
download | chrome-ec-stabilize-14388.62.B-ish.tar.gz |
ish: Trim down the release branchstabilize-wristpin-14469.59.B-ishstabilize-voshyr-14637.B-ishstabilize-quickfix-14695.187.B-ishstabilize-quickfix-14695.124.B-ishstabilize-quickfix-14526.91.B-ishstabilize-14695.85.B-ishstabilize-14695.107.B-ishstabilize-14682.B-ishstabilize-14633.B-ishstabilize-14616.B-ishstabilize-14589.B-ishstabilize-14588.98.B-ishstabilize-14588.14.B-ishstabilize-14588.123.B-ishstabilize-14536.B-ishstabilize-14532.B-ishstabilize-14528.B-ishstabilize-14526.89.B-ishstabilize-14526.84.B-ishstabilize-14526.73.B-ishstabilize-14526.67.B-ishstabilize-14526.57.B-ishstabilize-14498.B-ishstabilize-14496.B-ishstabilize-14477.B-ishstabilize-14469.9.B-ishstabilize-14469.8.B-ishstabilize-14469.58.B-ishstabilize-14469.41.B-ishstabilize-14442.B-ishstabilize-14438.B-ishstabilize-14411.B-ishstabilize-14396.B-ishstabilize-14395.B-ishstabilize-14388.62.B-ishstabilize-14388.61.B-ishstabilize-14388.52.B-ishstabilize-14385.B-ishstabilize-14345.B-ishstabilize-14336.B-ishstabilize-14333.B-ishrelease-R99-14469.B-ishrelease-R98-14388.B-ishrelease-R102-14695.B-ishrelease-R101-14588.B-ishrelease-R100-14526.B-ishfirmware-cherry-14454.B-ishfirmware-brya-14505.B-ishfirmware-brya-14505.71.B-ishfactory-kukui-14374.B-ishfactory-guybrush-14600.B-ishfactory-cherry-14455.B-ishfactory-brya-14517.B-ish
In the interest of making long-term branch maintenance incur as little
technical debt on us as possible, we should not maintain any files on
the branch we are not actually using.
This has the added effect of making it extremely clear when merging CLs
from the main branch when changes have the possibility to affect us.
The follow-on CL adds a convenience script to actually pull updates from
the main branch and generate a CL for the update.
BUG=b:204206272
BRANCH=ish
TEST=make BOARD=arcada_ish && make BOARD=drallion_ish
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Diffstat (limited to 'util/host_command_check.sh')
-rwxr-xr-x | util/host_command_check.sh | 138 |
1 files changed, 0 insertions, 138 deletions
diff --git a/util/host_command_check.sh b/util/host_command_check.sh deleted file mode 100755 index f699803b2e..0000000000 --- a/util/host_command_check.sh +++ /dev/null @@ -1,138 +0,0 @@ -#!/bin/bash -# -# Copyright 2017 The Chromium OS Authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. - -excludes=( --exclude-dir=build --exclude=TAGS ) - -####################################### -# Test if the following conditions hold for the ec host command -# The alpha numeric value of the define starts with 0x -# The alpha numeric value of the define is 4-hex digits -# The hex digits "A B C D E F" are capitalized -# Arguments: -# string - ec host command to check -# Returns: -# 0 if command is ok, else 1 -######################################## -check_cmd() { - IFS=" " - # Remove any tabs that may exist - tts=$(echo "$1" | sed 's/\t/ /g') - arr=( $tts ) - - # Check for 0x - if [[ "${arr[2]}" != 0x* ]]; then - return 1 - fi - - # Check that length is 6. 0x + 4 hex digits - if [[ ${#arr[2]} != 6 ]]; then - return 1 - fi - - # Check that hex digits are valid and uppercase - hd=${arr[2]:2} - if ! [[ $hd =~ ^[0-9A-F]{4}$ ]]; then - return 1 - fi - - # command is ok - return 0 -} - -####################################### -# Test if the string arg is in one of the following formats: -# file.X:#define EC_CMD_X XxXXXX -# file.X:#define EC_PRV_CMD_X XxXXXX -# Arguments: -# string - potential ec host command -# Returns: -# 0 if command is formated properly, else 1 -######################################## -should_check() { - IFS=" " - arr=( $1 ) - - # Check for file.X:#define - IFS=":" - temp=( ${arr[0]} ) - # Check for file.X - if [ ! -f "${temp[0]}" ]; then - return 1 - fi - - # Check for #define - if [[ "${temp[1]}" != "#define" ]]; then - return 1 - fi - - # Check for EC_CMD_XXX or EC_PRV_CMD_XXX - if [[ "${arr[1]}" != EC_CMD_* ]] && [[ "${arr[1]}" != EC_PRV_CMD_* ]]; then - return 1 - fi - - # Check for EC_XXX_XXX(n) - if [[ "${arr[1]}" =~ ')'$ ]]; then - return 1 - fi - - return 0 -} - -main() { - - # Do not run the check unless an EC_[xxx]CMD change is present. - if [[ -z "$(git diff --no-ext-diff "${PRESUBMIT_COMMIT}~" \ - "${PRESUBMIT_COMMIT}" -U0 | - egrep 'EC_[^ ]*CMD')" ]]; then - exit 0 - fi - - ec_errors=() - ei=0 - # Search all file occurrences of "EC_CMD" and store in array - IFS=$'\n' - ec_cmds=($(grep "${excludes[@]}" -r "EC_CMD")) - - # Loop through and find valid occurrences of "EC_CMD" to check - length=${#ec_cmds[@]} - for ((i = 0; i != length; i++)); do - if should_check "${ec_cmds[i]}"; then - if ! check_cmd "${ec_cmds[i]}"; then - ec_errors[$ei]="${ec_cmds[i]}" - ((ei++)) - fi - fi - done - - # Search all file occurrances of "EC_PRV_CMD" and store in array - IFS=$'\n' - ec_prv_cmds=($(grep "${excludes[@]}" -r "EC_PRV_CMD")) - - # Loop through and find valid occurrences of "EC_PRV_CMD" to check - length=${#ec_prv_cmds[@]} - for ((i = 0; i != length; i++)); do - if should_check "${ec_prv_cmds[i]}"; then - if ! check_cmd "${ec_prv_cmds[i]}"; then - ec_errors[$ei]="${ec_prv_cmds[i]}" - ((ei++)) - fi - fi - done - - # Check if any malformed ec host commands were found - if [ ! $ei -eq 0 ]; then - echo "The following host commands are malformed:" - # print all malformed host commands - for ((i = 0; i != ei; i++)); do - echo "FILE: ${ec_errors[i]}" - done - exit 1 - fi - - exit 0 -} - -main "$@" |