diff options
author | Jack Rosenthal <jrosenth@chromium.org> | 2021-11-04 12:11:58 -0600 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2021-11-05 04:22:34 +0000 |
commit | 252457d4b21f46889eebad61d4c0a65331919cec (patch) | |
tree | 01856c4d31d710b20e85a74c8d7b5836e35c3b98 /zephyr/zmake/tests/test_reexec.py | |
parent | 08f5a1e6fc2c9467230444ac9b582dcf4d9f0068 (diff) | |
download | chrome-ec-release-R98-14388.B-ish.tar.gz |
ish: Trim down the release branchstabilize-wristpin-14469.59.B-ishstabilize-voshyr-14637.B-ishstabilize-quickfix-14695.187.B-ishstabilize-quickfix-14695.124.B-ishstabilize-quickfix-14526.91.B-ishstabilize-14695.85.B-ishstabilize-14695.107.B-ishstabilize-14682.B-ishstabilize-14633.B-ishstabilize-14616.B-ishstabilize-14589.B-ishstabilize-14588.98.B-ishstabilize-14588.14.B-ishstabilize-14588.123.B-ishstabilize-14536.B-ishstabilize-14532.B-ishstabilize-14528.B-ishstabilize-14526.89.B-ishstabilize-14526.84.B-ishstabilize-14526.73.B-ishstabilize-14526.67.B-ishstabilize-14526.57.B-ishstabilize-14498.B-ishstabilize-14496.B-ishstabilize-14477.B-ishstabilize-14469.9.B-ishstabilize-14469.8.B-ishstabilize-14469.58.B-ishstabilize-14469.41.B-ishstabilize-14442.B-ishstabilize-14438.B-ishstabilize-14411.B-ishstabilize-14396.B-ishstabilize-14395.B-ishstabilize-14388.62.B-ishstabilize-14388.61.B-ishstabilize-14388.52.B-ishstabilize-14385.B-ishstabilize-14345.B-ishstabilize-14336.B-ishstabilize-14333.B-ishrelease-R99-14469.B-ishrelease-R98-14388.B-ishrelease-R102-14695.B-ishrelease-R101-14588.B-ishrelease-R100-14526.B-ishfirmware-cherry-14454.B-ishfirmware-brya-14505.B-ishfirmware-brya-14505.71.B-ishfactory-kukui-14374.B-ishfactory-guybrush-14600.B-ishfactory-cherry-14455.B-ishfactory-brya-14517.B-ish
In the interest of making long-term branch maintenance incur as little
technical debt on us as possible, we should not maintain any files on
the branch we are not actually using.
This has the added effect of making it extremely clear when merging CLs
from the main branch when changes have the possibility to affect us.
The follow-on CL adds a convenience script to actually pull updates from
the main branch and generate a CL for the update.
BUG=b:204206272
BRANCH=ish
TEST=make BOARD=arcada_ish && make BOARD=drallion_ish
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Diffstat (limited to 'zephyr/zmake/tests/test_reexec.py')
-rw-r--r-- | zephyr/zmake/tests/test_reexec.py | 59 |
1 files changed, 0 insertions, 59 deletions
diff --git a/zephyr/zmake/tests/test_reexec.py b/zephyr/zmake/tests/test_reexec.py deleted file mode 100644 index 9f25b5a834..0000000000 --- a/zephyr/zmake/tests/test_reexec.py +++ /dev/null @@ -1,59 +0,0 @@ -# Copyright 2021 The Chromium OS Authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. -"""Test the zmake re-exec functionality.""" - -import os -import sys -import unittest.mock as mock - -import pytest - -import zmake.__main__ as main - - -@pytest.fixture -def fake_env(monkeypatch): - environ = {} - monkeypatch.setattr(os, "environ", environ) - return environ - - -@pytest.fixture -def mock_execve(): - with mock.patch("os.execve", autospec=True) as mocked_function: - yield mocked_function - - -def test_out_of_chroot(fake_env, mock_execve): - # When CROS_WORKON_SRCROOT is not set, we should not re-exec. - main.maybe_reexec(["--help"]) - mock_execve.assert_not_called() - - -def test_pythonpath_set(fake_env, mock_execve): - # With PYTHONPATH set, we should not re-exec. - fake_env["CROS_WORKON_SRCROOT"] = "/mnt/host/source" - fake_env["PYTHONPATH"] = "/foo/bar/baz" - main.maybe_reexec(["--help"]) - mock_execve.assert_not_called() - - -def test_zmake_does_not_exist(fake_env, mock_execve): - # When zmake is not at src/platform/ec/zephyr/zmake, don't re-exec. - fake_env["CROS_WORKON_SRCROOT"] = "/this/does/not/exist" - main.maybe_reexec(["--help"]) - mock_execve.assert_not_called() - - -def test_zmake_reexec(fake_env, mock_execve): - # Nothing else applies? The re-exec should happen. - fake_env["CROS_WORKON_SRCROOT"] = "/mnt/host/source" - main.maybe_reexec(["--help"]) - new_env = dict(fake_env) - new_env["PYTHONPATH"] = "/mnt/host/source/src/platform/ec/zephyr/zmake" - mock_execve.assert_called_once_with( - sys.executable, - [sys.executable, "-m", "zmake", "--help"], - new_env, - ) |