summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* pdeval-stm32f072: Update for inclusive terminologystabilize-14964.B-mainKyle Lin2022-07-081-2/+2
| | | | | | | | | | | | | Replace 'slave' with 'target' for more inclusive terminology. BUG=none BRANCH=none TEST=none Change-Id: I290a3616ddfdcd9993acfd1fbb2eb585d07c1f54 Signed-off-by: Kyle Lin <kylelinck@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750968 Reviewed-by: Marco Chen <marcochen@chromium.org>
* pompom: Update for inclusive terminologyKyle Lin2022-07-081-1/+1
| | | | | | | | | | | | | Replace 'slave' with 'target' for more inclusive terminology. BUG=none BRANCH=none TEST=The modified source file builds successfully. Change-Id: I1bd12697b811683898251045f6818869371b09ce Signed-off-by: Kyle Lin <kylelinck@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750967 Reviewed-by: Marco Chen <marcochen@chromium.org>
* tentacruel: add ps8743 device bindingjeffrey_lin2022-07-083-0/+49
| | | | | | | | | | | | | add PS8743 USBC MUX device binding BUG=b:237955258 TEST=enable on tentacruel BRANCH=none Signed-off-by: jeffrey_lin <jeffrey_lin@pegatron.corp-partner.google.com> Change-Id: Ie059aabb362da5fe390155dda2907c03cbfca176 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750261 Reviewed-by: Eric Yilun Lin <yllin@google.com>
* steelix: fix typoTing Shen2022-07-082-4/+4
| | | | | | | | | | | | | | | | from -> form BUG=none TEST=zmake build steelix BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Ic1bfed029c5aeb0906b9bb1a08f7f6b87ac22398 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3751016 Auto-Submit: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org>
* anx7447: expose public headerEric Yilun Lin2022-07-082-12/+30
| | | | | | | | | | | | | | | | move i2c device register address and function declarations into public header. BUG=b:227359727 TEST=zmake BRANCH=none Change-Id: I6abf44ed35c48a5a8ff087130867b67c1cc5ec8c Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3721943 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* nx20p348x: expose public headerEric Yilun Lin2022-07-082-20/+34
| | | | | | | | | | | | | | | | move i2c device register address and function declarations into public header. BUG=b:227359727 TEST=zmake BRANCH=none Change-Id: I51c967c53c3052196bc51964a7ca2f7d104a1781 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3721942 Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com>
* bindings/usb_mux: forward declaration of board_init/board_setEric Yilun Lin2022-07-082-0/+81
| | | | | | | | | | | | | | | | | Forward declares usb_mux callback board_init and board_set to silent the compile error. BUG=b:227359727 TEST=define board_init/board_set function in dts and ensure it's called BRANCH=none Change-Id: I11ba4b56d1c3ffbaec20c2adb7f538b693169093 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3721939 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* ppc: add comma separator in ppc shim for a better formatEric Yilun Lin2022-07-084-19/+16
| | | | | | | | | | | | | | | | Move the comma from header to the dts binding. BUG=none TEST=zmake --goma testall --clobber BRANCH=none Change-Id: Ife8651cc58f43cdd9e6f6088fd860dec4d03237a Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750555 Commit-Queue: Eric Yilun Lin <yllin@google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* bc12: add comma separator in bc12 shim for a better formatEric Yilun Lin2022-07-084-12/+12
| | | | | | | | | | | | | | | | Move the comma from header to the dts binding. BUG=none TEST=zmake --goma testall --clobber BRANCH=none Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Change-Id: If7cd0d3947cc73c9b2ef8ad378d58fce5e8fe833 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750554 Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* tcpc: add comma separator in tcpc shim for a better formatEric Yilun Lin2022-07-087-26/+19
| | | | | | | | | | | | | | | | | | Move the comma from header to the dts binding. BUG=none TEST=zmake --goma testall --clobber BRANCH=none Change-Id: Ic5ee1a8b83bc9690354546402cc74f097176fe36 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750550 Auto-Submit: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com>
* sm5803: slow clocks last when enabling LPMPeter Marheine2022-07-081-4/+5
| | | | | | | | | | | | | | | | | Silicon Mitus say that slowing clocks before disabling GPADCs can cause spurious readings, which may cause unexpected behavior. We don't currently disable GPADCs, but in the same spirit change the order of operations to slow the clocks last when going into low-power mode. BUG=b:168591511,b:237697900 TEST=sinking and sourcing still work on Nereid and ports enter runtime LPM as expected. BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Ideac273cf39b6d1b13cc8336701774595e49df41 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750542 Reviewed-by: Andrew McRae <amcrae@google.com>
* docs: Add note about removing history to reduce EC image sizeJameson Thies2022-07-081-4/+5
| | | | | | | | | | | | | | | | | src/platform/ec/docs/reducing_ec_image_size.md includes a small section stating that the help command can be removed from the EC console free up flash space in the EC. Similarly, the history command can be removed. This CL updates the reducing_ec_image_size.md doc to note that both help and history can be removed to save EC space. BRANCH=None BUG=None TEST=None Signed-off-by: Jameson Thies <jthies@google.com> Change-Id: Iee566ea574c85607eca8a481fec6d2ffdd332405 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750112 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* clang-format: Enable enforcement during pre-uploadJack Rosenthal2022-07-071-0/+1
| | | | | | | | | | | | | | | Enable the clang_format_check hook for pre-upload. BUG=b:236386294 BRANCH=none TEST=Run ~/chromiumos/src/repohooks/pre-upload.py on recent commits Only legitimate formatting errors are caught. Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: Id00fd8a7acce4105cb8f4a445067393616df5ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3751770 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* zephyr/include/drivers/cros_flash.h: Format with clang-formatJack Rosenthal2022-07-071-13/+13
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: I69345692daf01e56e98cb2e57d3420aee62ec574 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730711 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* include/usb_pd_timer.h: Format with clang-formatJack Rosenthal2022-07-071-19/+16
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: I7d4ef8e73349c70bde48f0af285a2812d8f36dba Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730445 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* common/usbc/usb_pd_timer.c: Format with clang-formatJack Rosenthal2022-07-071-64/+62
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: Ic49d027ee6bcf2ab1d52215af4146beeee284081 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3729788 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* chip/stm32/registers-stm32l.h: Format with clang-formatJack Rosenthal2022-07-071-580/+566
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: Idcf30bc6916b729321e183a5d43e16afb6e2c12e Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3729533 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* chip/stm32/registers-stm32h7.h: Format with clang-formatJack Rosenthal2022-07-071-801/+789
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: I6336557f0869f177d1df82651b21f76d7f6a6e9b Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3729532 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* chip/stm32/registers.h: Format with clang-formatJack Rosenthal2022-07-071-327/+322
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: Ic76151cfe4fd7b211b9a065befe67224bb8d6d64 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3729535 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* common: Conditionally support printf %l and %i modifiersBobby Casey2022-07-0710-32/+140
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The libfp library prints some values with PRIx32 or PRId32 format specifiers which, in their compilation environment, output "%lx" and "%ld". Unfortunately, support for printing any '%l' format in EC code was deprecated in issuetracker.google.com/issues/172210614 after changing it from it being treated as a hard-coded 64-bit length. There was concern that new code using %l with 32-bit values would be cherry-picked to older branches without the updated printf. In these cases, the older code would interpret that %l as 64-bit argument, causing it to over-ingest arguments and potentially behave in an undefined manner. Printing 32-bit values with "%l" or "%i" is safe as long as we can guarantee no legacy code will attempt to print using "%l" with a 64-bit value. The logic here is protected by a config flag that is only enabled for FPMCU and FPMCU doesn't use long running release branches. A printf test is also added to ensure that only dartmonkey and bloonchipper boards have long32 enabled. BRANCH=none BUG=b:234781655 BUG=b:234143158 TEST=./test/run_device_tests.py -b dartmonkey -t printf TEST=./test/run_device_tests.py -b bloonchipper -t printf TEST=make runhosttests Signed-off-by: Bobby Casey <bobbycasey@google.com> Change-Id: If432f507a31cc12a4c5c4bdcd07c6141407bd70d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3707743 Reviewed-by: Andrea Grandi <agrandi@google.com> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* test: Remove TEST_CHECK macroBobby Casey2022-07-078-64/+80
| | | | | | | | | | | | | | | | | | | | | The TEST_CHECK macro returns a value (from the calling function) on either success or failure. This differs from all other TEST_* macros in test_util.h, which only return on failure. Returning on failure is appropriate and allows short circuiting a test on the first failure but returning on success results in short circuiting after the first successful check and bypassing subsequent checks. This behavior is somewhat confusing and easy to miss during review. BRANCH=none BUG=b:238120333 TEST=make runhosttests TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Bobby Casey <bobbycasey@google.com> Change-Id: I3777b427aa5e20a91689f86fc37daadffacf27f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3748830 Reviewed-by: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* test: Add a test to check if the debugger is connectedTom Hughes2022-07-078-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is intended to make it easier to debug the behavior of is_debugger_connected(). With JLink we're seeing that C_DEBUGEN is still set even after disconnecting the JLink (see referenced bug). BRANCH=none BUG=b:180945056 TEST=On dragonclaw v0.2 with JLink and servo_micro, flash the "debug" test: Connect the debugger: JLinkExe -device STM32F412CG -if SWD -speed 4000 -autoconnect 1 J-Link>r J-Link>go Run the test on the FPMCU console: > runtest debugger => PASS Disconnect the debugger: J-Link>exit Run the test on the FPMCU console: > runtest no_debugger => PASS TEST=On icetower v0.1 with JLink and servo_micro, flash the "debug" test: Connect the debugger: JLinkExe -device STM32H743ZI -if SWD -speed 4000 -autoconnect 1 J-Link>r J-Link>go Run the test on the FPMCU console: > runtest debugger => PASS Physically disconnect the debugger and servo_micro. Then reconnect servo_micro and start servod. Run the test on the FPMCU console: > runtest no_debugger => PASS Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I544cab5814a30310345d4337a818d7b48cc22a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3739316 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* test/stdlib: Disable gcc stringop-truncation warningTom Hughes2022-07-072-0/+11
| | | | | | | | | | | | | | | | | | | | | | | gcc warns: error: ‘__builtin_strncpy’ output truncated copying 10 bytes from a string of length 12 [-Werror=stringop-truncation] In this case the test is intentionally copying a subset of the string. Also, since it's not obvious, add a note that when building this test for the host we're actually testing the toolchain's C standard library, not the EC "builtin" version. BRANCH=none BUG=b:234181908, b:237823627 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I943de03ae62d7ae5e431809305ae68100e6da418 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3724490 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* util: Move stdlib declarations to builtin directoryTom Hughes2022-07-076-52/+78
| | | | | | | | | | | | | | | | | | The "builtin" directory is EC's copy of the C standard library headers. Move the declarations for functions that are provided by the standard library to the "builtin" directory. This change makes it easier for future changes to optionally build with the C standard library instead of the standalone EC subset. BRANCH=none BUG=b:172020503, b:234181908 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I4822e49677e0c0e1b092711b533f2aaa762cb4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3712033 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* Move standard library tests to their own fileTom Hughes2022-07-0712-369/+422
| | | | | | | | | | | | | | The standard library functions are being consolidated in stdlib.c, so this test mirrors the same layout. BRANCH=none BUG=none TEST=make buildall -j Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I2d7f7671f23a0c4e5f09ef9e0d5d8c25688cd376 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3724489 Reviewed-by: Edward Hill <ecgh@chromium.org>
* tree: Move stdlib implementation to builtin directoryTom Hughes2022-07-077-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keeping all of the standard library implementation in a single directory makes it easier to choose between EC's implementation or the implementation from the toolchain. BRANCH=none BUG=b:234181908, b:172020503 TEST=make buildall -j TEST=Using icetower v0.1, Segger J-Trace, and servo micro: ./test/run_device_tests.py -b dartmonkey Test "aes": PASSED Test "cec": PASSED Test "cortexm_fpu": PASSED Test "crc": PASSED Test "flash_physical": PASSED Test "flash_write_protect": PASSED Test "fpsensor_hw": PASSED Test "fpsensor_spi_ro": PASSED Test "fpsensor_spi_rw": PASSED Test "fpsensor_uart_ro": PASSED Test "fpsensor_uart_rw": PASSED Test "mpu_ro": PASSED Test "mpu_rw": PASSED Test "mutex": PASSED Test "pingpong": PASSED Test "printf": PASSED Test "queue": PASSED Test "rollback_region0": PASSED Test "rollback_region1": PASSED Test "rollback_entropy": PASSED Test "rtc": PASSED Test "sha256": PASSED Test "sha256_unrolled": PASSED Test "static_if": PASSED Test "system_is_locked_wp_on": PASSED Test "system_is_locked_wp_off": PASSED Test "timer_dos": PASSED Test "utils": PASSED Test "utils_str": PASSED Test "panic_data_dartmonkey_v2.0.2887": PASSED Test "panic_data_nocturne_fp_v2.2.64": PASSED Test "panic_data_nami_fp_v2.2.144": PASSED Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I75f8591e87a9076d47208eb598186a391c77966d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3724488 Reviewed-by: Edward Hill <ecgh@chromium.org>
* BB retimer: Set 'DP CONNECTION' bit only when mux_state gets HPD eventjohnwc_yeh2022-07-072-12/+17
| | | | | | | | | | | | | | | | | | | | | | For some chromebooks design, there are expanssion card (typeC to HDMI) communicate with TCPC through CC line, when the HDMI card connect to chromebook the DP CONNECTION bit would be enable even no connect HDMI moinitor. It will increase BBR power consumption, so set 'DP CONNECTION' bit only when mux_state gets HPD event. BUG=b:233975818 BRANCH=None TEST=Test on Banshee, measure BBR power consumption reduce from 143mW to 7mW. And the HDMI monitor can be output. Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: I8a80235992cfa1bac28f03c3b6a7ec378e07ecf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3726600 Reviewed-by: Diana Z <dzigterman@chromium.org> Tested-by: Enzo Hong <enzo.hong@intel.corp-partner.google.com> Commit-Queue: Diana Z <dzigterman@chromium.org>
* docs/fingerprint: Update power numbers for latest bloonchipper releaseTom Hughes2022-07-071-15/+15
| | | | | | | | | | | | BRANCH=none BUG=none TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I98667aeda2e380dd215bd0bb0bcfca781b03e996 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3739314 Reviewed-by: Andrea Grandi <agrandi@google.com> Reviewed-by: Bobby Casey <bobbycasey@google.com>
* driver/fingerprint/fpc/bep/fpc_sensor_spi.c: Format with clang-formatJack Rosenthal2022-07-071-3/+3
| | | | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=./util/compare_build.sh -b fp Tricium: disable Change-Id: I7307b5373977851db34cea9d5e02324f8a49cf65 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3729972 Commit-Queue: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* board/cherry/board.c: Format with clang-formatJack Rosenthal2022-07-071-2/+2
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: Iff6332e788eb710f1923ee4c7e40015c013bcb54 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3748795 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* driver/fingerprint/fpc/libfp/fpc_sensor_pal.h: Format with clang-formatJack Rosenthal2022-07-071-5/+7
| | | | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=./util/compare_build.sh -b fp Tricium: disable Change-Id: I2809c0731ce779a9dd87730a07940c7738eb4c83 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3729946 Commit-Queue: Tom Hughes <tomhughes@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* include/btle_hci_int.h: Format with clang-formatJack Rosenthal2022-07-071-36/+54
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: Ief33fd9a5b8eed2264b143ebf1261835e9cc0230 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749516 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* ccgxxf: Return cached CC state on I2C failureVijay Hiremath2022-07-071-2/+46
| | | | | | | | | | | | | | | | | | | Once the PD negotiation completes, CCGXXF chip stops responding over I2C for about 10 seconds. As DRP is enabled, TCPM algorithm constantly looks for any CC status changes even after negotiation completes. Hence, cache the CC state and return the cached values in case of I2C failures. This workaround will be removed once the fix is added in the physical layer firmware of CCGXXF. BUG=b:236994474 BRANCH=none TEST=Able to negotiate USB/DP/TBT/USB4 on MTLRVP Change-Id: Ia51b6accca3e9fa0d49b9b27915c4f95c62e35be Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3715434 Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-by: RAJESH KUMAR <rajesh3.kumar@intel.com>
* ec: Don't convert coverage paths to relativeJeremy Bettis2022-07-071-3/+0
| | | | | | | | | | | | | | | | The build_firmware recipe will take care of converting paths to absolute or relative as necessary, so leave the paths alone. BRANCH=None BUG=b:231639771 TEST=Ran locally Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I2588f55fd3bcca81459846be8ae6228404f5e3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749799 Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* cq: Merge in the legacy tests in the zephyr covJeremy Bettis2022-07-071-1/+27
| | | | | | | | | | | | | | | | Just like in gitlab, merge in the legacy coverage data, and put that into the ALL_MERGED metric. BRANCH=None BUG=b:231639771 TEST=Ran locally. Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I05128b0c07160ab6d5f3937216dd1797b2403f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3748852 Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
* README: Emphasize with inline code instead of boldPatrick Thompson2022-07-071-1/+1
| | | | | | | | | | | | | | | | | README.md has angle brackets that are supposed to be displayed but are not because bold (**) does not escape brackets. The rest of the file uses inline code (backtics) for emphasis so that's what I changed it to. BUG=b:231139247 BRANCH=None TEST=None Change-Id: I7b3c791c402fd7f7e270a4e340cb40bcca166ead Signed-off-by: Patrick Thompson <ptf@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749530 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* mt8186: reports reset/shutdown reason in hexEric Yilun Lin2022-07-071-2/+2
| | | | | | | | | | | | | | | It's more readable if the reason is in hex format. BUG=none TEST=the reasons are reports in hex format BRANCH=none Change-Id: I95133806caad9047dcbbffc22b8c1f04033773d8 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750274 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* mt8186: reports forcing shutdown by long pwrkey pressEric Yilun Lin2022-07-071-5/+14
| | | | | | | | | | | | | | | | | | | | | | | When powerkey long pressed for 8(+-20%) seconds, the PMIC will enter forcing shutdown mode and turn off the rail. If PMIC enters the forcing shutdown process too fast, then the shutdown reason report will be canceled, and we won't know the exactly shutdown reason. This CL reports the shutdown reason when the power is going for S0S3, and hasn't reported the reason. BUG=none TEST=1. at S0, ensure the long powerkey press reports 0x8009 2. apshutdown works 3. shutdown from AP works 4. at S3, long press powerkey: S3->S0->S3->S5->G3 BRANCH=none Change-Id: I1ea8e710a81ed7267c7f87c6c6d711a045603b7e Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3750273 Commit-Queue: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* zephyr/it8xxx2: increase the image size to 1MBTing Shen2022-07-072-9/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set CONFIG_FLASH_SIZE_BYTES back to 1MB to match the hard-coded number in tast. After this CL, the region mapping become: 384kB RO + PSTATE 384kB RW 256kB unused This CL doesn't increase the RO/RW region size, only adds a 256kB unallocated region at the end of FLASH. So the performance of software sync should be the same. BUG=b:237350549 TEST=1) size of zephyr.bin is still 768kB 2) `dut-control ec_flash_size` prints 1MB instead of 768kB 3) ec software sync and sysjump works 4) fw region macros doesn't change: CONFIG_FW_PSTATE_SIZE: 4096 CONFIG_FW_PSTATE_OFF: 389120 CONFIG_RO_MEM_OFF: 0 CONFIG_RO_STORAGE_OFF: 0 CONFIG_RO_SIZE: 393216 CONFIG_RW_MEM_OFF: 393216 CONFIG_RW_STORAGE_OFF: 0 CONFIG_RW_SIZE: 393216 CONFIG_EC_PROTECTED_STORAGE_OFF: 0 CONFIG_EC_PROTECTED_STORAGE_SIZE: 393216 CONFIG_EC_WRITABLE_STORAGE_OFF: 393216 CONFIG_EC_WRITABLE_STORAGE_SIZE: 393216 CONFIG_WP_STORAGE_OFF: 0 CONFIG_WP_STORAGE_SIZE: 393216 BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: I598186737cfef4db50c4eecfc846800e17dfd537 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3742961 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Reviewed-by: Dino Li <dino.li@ite.corp-partner.google.com>
* tentacruel: extract LED dtsi shared with krabbylschyi2022-07-075-386/+225
| | | | | | | | | | | | | | | | | | Tentacruel and krabby shares the same LED DTS settings. Extract these settings as a base dtsi, and covert tentacruel to use DTS to control the LED behavior. BUG=b:236796813 TEST=use `battfake` in EC console, set battery to different level and check LED behavior matches to the DTS settings. BRANCH=none Signed-off-by: lschyi <lschyi@google.com> Change-Id: I1e09e5c7d05e91b919a113280c228ebab317b25d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3748017 Tested-by: Sung-Chi Li <lschyi@chromium.org> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Sung-Chi Li <lschyi@chromium.org>
* krabby: convert LED implementation into DTSlschyi2022-07-074-160/+131
| | | | | | | | | | | | | | | | | Convert and adapt LED implementation in Krabby in to DTS. BUG=b:236796813 TEST=use `battfake` in EC console, set battery to different level and check LED behavior matches to the DTS settings. BRANCH=none Signed-off-by: lschyi <lschyi@google.com> Change-Id: I39be060c4fe0c7a3a46a2cfe6fc528cb2ce0896c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3748016 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Sung-Chi Li <lschyi@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Sung-Chi Li <lschyi@chromium.org>
* board/galtic/board.h: Format with clang-formatJack Rosenthal2022-07-071-2/+3
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: Icbc347a2f9aeb84608ccd416931676b15cee4136 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749379 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* chip/npcx/gpio_chip-npcx5.h: Format with clang-formatJack Rosenthal2022-07-071-71/+71
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: Id46ebca41fb1bd943277f5b037eefe2cfb45a804 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749457 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* chip/max32660/uart_regs.h: Format with clang-formatJack Rosenthal2022-07-071-158/+190
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: I0dd604a8b62416a5b57708f9656bbbf9fd2b2e6a Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749435 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* util/uut/l_com_port.c: Format with clang-formatJack Rosenthal2022-07-071-3/+4
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: Ic03096cc17f9ba724863161b1c2296be8d85b8a9 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749524 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* board/magolor/board.h: Format with clang-formatJack Rosenthal2022-07-071-2/+3
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: I08a8eeddbc4ef95621f714a9b5abf877b3ad202a Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749392 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* board/coffeecake/usb_pd_policy.c: Format with clang-formatJack Rosenthal2022-07-071-3/+4
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: I4b8f837e1cd4e0fa8230f1f3aea5ed0709d39b0d Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3748796 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* board/corori2/board.h: Format with clang-formatJack Rosenthal2022-07-071-2/+3
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: I5add6129c30e9f7b58e237054e06c87edb21319f Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3748797 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* chip/max32660/pwrseq_regs.h: Format with clang-formatJack Rosenthal2022-07-071-27/+32
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: I9b49beabcc3114cee29d67177e94a45466b77922 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749433 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* board/servo_v4/usb_pd_config.h: Format with clang-formatJack Rosenthal2022-07-071-14/+16
| | | | | | | | | | | | BUG=b:236386294 BRANCH=none TEST=none Tricium: disable Change-Id: Ice808816780fbf197a0ab9dcb671842e306ae373 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749419 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
View Lorry Controller Status