summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* common/keyboard_8042: Add logging to keyboard_clear_bufferRaul E Rangel2020-03-021-0/+4
| | | | | | | | | | | | | It's useful to know when the buffer has been cleared. BUG=b:145575366 BRANCH=none TEST=Saw x in kblog Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: I1c3474687c91a3e017d7a7a0e4e7967c3fb10f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079693 Reviewed-by: Edward Hill <ecgh@chromium.org>
* common/keyboard_8042: Update kblog while holding mutexRaul E Rangel2020-03-021-2/+3
| | | | | | | | | | | | | | i8042_send_to_host can be called from multiple tasks. Make sure we don't mix up or lose any kblog entries. BUG=b:145575366 BRANCH=none TEST=Built and saw kblog is still populated. Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: I5d036f6db4c829c2071850c1ec92f74a24b135b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079692 Reviewed-by: Edward Hill <ecgh@chromium.org>
* ec: exclude chargen, the cli command from RO image buildNamyoon Woo2020-03-011-0/+2
| | | | | | | | | | | | | | | chargen occupies 400~500 bytes in flash usage. It is not likely to be used in EC RO, so this patch excludes it from RO build. BUG=none BRANCH=none TEST=build hatch, and checked RO.map file doesn't include chargen command. Signed-off-by: Namyoon Woo <namyoon@chromium.org> Change-Id: I1209d2a945526f59888c37b504f5886138265fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2080933 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* compare_build.sh: Fix restore detached HEADCraig Hesling2020-03-011-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the scenario where you want to run compare_build.sh, but you are currently are in a detached HEAD state. Without it, ./compare_build.sh moves your HEAD and cannot restore it. The command "git rev-parse --abbrev-ref HEAD" only returns a unique identifier (branch name) when HEAD is on a branch. If you are in detached HEAD mode, it simply returns HEAD, which isn't useful. BRANCH=none BUG=none TEST=git checkout cros/master git rev-parse HEAD ./util/compare_build.sh git rev-parse HEAD # We should still be on the same hash Change-Id: Ib8dbedc61a77567262fceab59c17e1fb9c78cdd6 Signed-off-by: Craig Hesling <hesling@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2080917
* TCPMv2: Add BIST RX and TX states needed by PD FAFTSam Hurst2020-02-292-53/+145
| | | | | | | | | | | | | | | | Split the BIST state into BIST RX and TX states. These states are accessed from the pd console which enables the device to work with PD FAFT. BUG=chromium:1021235 BRANCH=none TEST=make -j buildall Manual tests: Change-Id: I1f8280b8a31b0faa012e2098b6fc51b24d7ee1fc Signed-off-by: Sam Hurst <shurst@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1962975 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* PS8740: Allow 0xa or 0xb for REVISION_ID2Edward Hill2020-02-292-23/+30
| | | | | | | | | | | BUG=b:150384642 BRANCH=none TEST=ps874x_init succeeds on Dalboz Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I9213a1f12d2412db4d38eaf75daaa27507787e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2080644 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zork: Split mux/retimer for trembyle/dalbozEdward Hill2020-02-296-360/+390
| | | | | | | | | | | BUG=b:150099043 b:150384642 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Ica9eda3f9d6a1332319b5c7ba56c0881d05eeebd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079353 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* volteer: Prevent glitch on SLP_S3_L during power onKeith Short2020-02-293-15/+49
| | | | | | | | | | | | | | | | | Reconfigure the SLP_S3_L power interrupt as an output and drive this signal low while the PP3300_A rail comes up. This prevents a glitch on the SLP_S3_L signal that can affect the power sequencing. BUG=b:143346794 BRANCH=none TEST=make buildall TEST=Verify Volteer boots. With debug code enabled, verify SLP_S3_L drives low while PP3300 turns on. Change-Id: Ic8204874cb9e68a1af27fafcf5274d50ce5cb38f Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068535 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* volteer: add chargen to the set of CLI commandsNamyoon Woo2020-02-281-0/+3
| | | | | | | | | | | | | | | | This is needed to support CCD testing of UART to USB bridging. This patch occupies 440 and 424 bytes in flash usage of RO and RW respectively. BUG=none BRANCH=none TEST=build volteer, and checked that command is included in the symbol map. Signed-off-by: Namyoon Woo <namyoon@chromium.org> Change-Id: Ife501d6a2da10840ad06ec025a6a2663021072cf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079871 Reviewed-by: Keith Short <keithshort@chromium.org>
* zork: add chargen to the set of CLI commandsNamyoon Woo2020-02-281-0/+3
| | | | | | | | | | | | | | | | This is needed to support CCD testing of UART to USB bridging. This patch occupies 536 and 524 bytes in flash usage of RO and RW respectively. BUG=none BRANCH=none TEST=build morphius, and checked that command is included in the symbol map. Signed-off-by: Namyoon Woo <namyoon@chromium.org> Change-Id: I4994df1e7826ccb11bbffb8874ddf5c5d75176ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079872 Reviewed-by: Edward Hill <ecgh@chromium.org>
* usb_mux: retimer: mux as chained mux and retimerDenis Brockus2020-02-2899-1001/+1051
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes retimers appear as generic muxes. By allowing a chain of muxes they can be stacked up to the new configurations that zork requires and will continue to work as they did before on configurations that only have a single mux. The code used to have two different arrays, 1) muxes and 2) retimers. On one of the zork configurations the processor MUX stopped being the primary mux and the retimer took its place. In a different configuration of that same platform it left the primary and secondary alone but the mux_set FLIP operation had to be ignored. Since the same interfaces needed to be available for both it stopped making sense to have two different structures and two different methods of handling them. This consolodates the two into one. The platforms that do not have retimers, this change will not make any difference. For platforms like zork, it will remove the retimers and make them chained muxes. So testing on trembyle makes sense to verify, BUG=b:147593660 BRANCH=none TEST=verify USB still works on trembyle Change-Id: I286cf1e302f9bd3dd7e81098ec08514a2a009fe3 Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2066794 Commit-Queue: Jett Rink <jettrink@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org>
* dedede: add chargen to the set of CLI commandsNamyoon Woo2020-02-281-0/+3
| | | | | | | | | | | | | | | | This is needed to support CCD testing of UART to USB bridging. This patch occupies 448 and 428 bytes in flash usage of RO and RW respectively. BUG=b:38448364 BRANCH=none TEST=build waddledoo and waddledee, and checked that command is included in the symbol map. Signed-off-by: Namyoon Woo <namyoon@chromium.org> Change-Id: Id2f525b1a53042316f96e6374dee84e95c1f5c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079709 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* docs/fingerprint: Add instructions for adding private repoTom Hughes2020-02-281-1/+24
| | | | | | | | | | | | BRANCH=none BUG=b:147702944 TEST=view in gitiles Change-Id: I6262b47b0438fe34aee6a3c562198e1ee41b6f83 Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2076583 Tested-by: Craig Hesling <hesling@chromium.org> Reviewed-by: Craig Hesling <hesling@chromium.org>
* i2c: fix the tcpc i2c protection in the i2c_command_passthru_protectZhuohao Lee2020-02-281-4/+12
| | | | | | | | | | | | | | | | | In the depthcharge, we call the EC host command with the subcmd EC_CMD_I2C_PASSTHRU_PROTECT to block all of the TCPC i2c pass through commands from the AP. However, the params->port isn't set because we need to block all of the TCPC. In order to support the tcpc i2c ports protection correctly, we need to skip the get_i2c_port checking BUG=b:150099159 TEST=ran on Palkia Change-Id: I4ab13a8f737f0e7b9ae88e51012d1737fc34e1a1 Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2069959 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Karthikeyan Ramasubramanian <kramasub@chromium.org>
* common/system: Add sysinfo host commandTom Hughes2020-02-283-9/+158
| | | | | | | | | | | | | | | | | | This command is useful to use during testing to verify the state of the system (e.g., locked/unlocked, currently running image, etc.). BRANCH=none BUG=b:146447208 TEST=make buildall -j TEST=ectool --name=cros_fp sysinfo TEST=ectool --name=cros_fp sysinfo flags TEST=ectool --name=cros_fp sysinfo reset_flags TEST=ectool --name=cros_fp sysinfo firmware_copy Change-Id: I714b6bd8c0d7192386404c25a831e38438fa5238 Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2047032 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* common/system: Unify ec_current_image and system_image_copy_tTom Hughes2020-02-2841-257/+254
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "enum ec_current_image" is exposed in ec_commands.h (and used by non-EC code, such as biod). We also have an "enum system_image_copy_t" that is the exact same thing (though has a few more definitions). A followup CL (I714b6bd8c0d7192386404c25a831e38438fa5238) adds the "sysinfo" host command, so we want to be able to expose all the potential image variants. Rather than maintain two enums that can potentially get out of sync, unify the code to use a single enum. We choose to keep the "enum ec_current_image", since external code depends on it. To verify that this change results in no changes to the generated binaries: ./util/compare_build.sh --board all BRANCH=none BUG=b:146447208 TEST=./util/compare_build.sh --board=all Change-Id: I13776bc3fd6e6ad635980476a35571c52b1767ac Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2036599 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Namyoon Woo <namyoon@chromium.org>
* nami: Enable extpwrlimit option in ectoolShelley Chen2020-02-281-1/+1
| | | | | | | | | | | | | BUG=b:149997506 BRANCH=nami TEST=ectool extpwrlimit 3000 5000 Signed-off-by: Shelley Chen <shchen@google.com> Change-Id: I34da082b8475ae4b200586d604ad653186fc5299 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079359 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Shelley Chen <shchen@chromium.org> Tested-by: Shelley Chen <shchen@chromium.org>
* hatch: Enable extpwrlimit option in ectoolShelley Chen2020-02-281-0/+1
| | | | | | | | | | | | | BUG=b:149997506 BRANCH=hatch TEST=ectool extpwrlimit 3000 5000 Signed-off-by: Shelley Chen <shchen@google.com> Change-Id: Ie133ac518f1a290ef04610a56c1d104d60254ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2079358 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Shelley Chen <shchen@chromium.org> Tested-by: Shelley Chen <shchen@chromium.org>
* common/flash: Adds validation to setting serialBrian J. Nemec2020-02-271-9/+13
| | | | | | | | | | | | | | | | | | | | | Adds a simple validation to the serial number to verify it fits within the buffer allocated to it. If a serial number is passed that is too long, it will no longer be silently truncated, instead an invalid argument will show up on the console. Also performed a small bit of cleanup on the function to eliminate extra loops and replace them with memset and memcpy functions. BUG=b:149775650 TEST=Verified that we can set and load serial numbers correctly. On ServoV4 where CONFIG_SERIALNO_LEN = 28: Verified that serial numbers up to 27 characters can be set and loaded. Verified 28 characters and longer return error codes. Change-Id: I9b4fb269a59023001a0fa8c1e8fc810db320fb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2063368 Tested-by: Brian Nemec <bnemec@chromium.org> Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Commit-Queue: Brian Nemec <bnemec@chromium.org>
* docs: Add code-review guidelinesAbe Levkoy2020-02-271-0/+108
| | | | | | | | | | | | | | | | | These should help code reviews go more smoothly. They are the consensus position of an out-of-band discussion among EC developers. BUG=none TEST=Observed rendered MD BRANCH=none Change-Id: I3b5e31a00481cc43732f5399c80a1ec82fec05b4 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2062761 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org>
* volteer: Update EC to AP interrupt assignmentKeith Short2020-02-271-1/+1
| | | | | | | | | | | | | | | | | Update the EC to AP interrupt assignment for the next build. On boards with board ID=0, the EC_PCH_INT_ODL signal was cut so there is no need for backward compatibility. BUG=b:144933528, b:140557015 BRANCH=none TEST=make buildall -j TEST=Using reworked Volteer board, run "cat /proc/interrupts | grep chromeos" to verify EC is generating interrupts to the kernel. Change-Id: I0a09b0aad9f3a1cd30eb8cf1c2d1f1483d377c8b Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2076507 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* doc: Add creating a new board checklist.Keith Short2020-02-2717-1/+1301
| | | | | | | | | | | | | | | | Add the high-level steps for creating a new board in the EC code base. The entry point is the docs/new_board_checklist.md file, which then links to files found under docs/configuration/. BUG=b:147905484 BRANCH=none TEST=none Change-Id: Ia0ca4f6547735a5d1ee93145ee18962cf7559fe3 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1778635 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* volteer: Configure EC_VOLUP_BTN_ODL for next buildKeith Short2020-02-276-8/+69
| | | | | | | | | | | | | | | | Update the GPIO assignment for the EC_VOLUP_BTN_ODL signal for the next board build. BUG=b:144933528 BRANCH=none TEST=make buildall TEST=Verify volume buttons with board ID=0 Change-Id: I28e53573b6a6a9ba7e5df0458ded8b988c25ac04 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2065489 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* common/keyboard_8042: Add ability to specify 8042 channelRaul E Rangel2020-02-271-13/+32
| | | | | | | | | | | | | | | We actually have two data channels we can send data on. This CL only adds the functionality to specify the additional channel. We only define the KBD channel for now. A follow up will add the AUX channel. BUG=b:145575366 BRANCH=none TEST=Verified keyboard data is still sent Change-Id: Icaed0a741cee4dac5eb5e6f36bd4e45d4a1e1bcd Signed-off-by: Raul E Rangel <rrangel@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073285 Reviewed-by: Edward Hill <ecgh@chromium.org>
* common/keyboard_8042: Track aux chan enable and aux irq enableRaul E Rangel2020-02-271-0/+33
| | | | | | | | | | | | | Start tracking these so we can correctly filter mouse messages. BUG=b:145575366 BRANCH=none TEST=Verified 8042 command prints current state Change-Id: I8a5fe3c66196d961c3a1adbb7355532de5ac0dc9 Signed-off-by: Raul E Rangel <rrangel@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073284 Reviewed-by: Edward Hill <ecgh@chromium.org>
* common/keyboard_8042: Rename i8042_irq_enabledRaul E Rangel2020-02-271-5/+5
| | | | | | | | | | | | | | Rename i8042_irq_enabled to i8042_keyboard_irq_enabled to avoid confusion when adding i8042_aux_irq_enabled. BUG=b:145575366 BRANCH=none TEST=Build test Change-Id: I031bf941faf80d99a01bf2a3834f61b5040f7674 Signed-off-by: Raul E Rangel <rrangel@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073283 Reviewed-by: Edward Hill <ecgh@chromium.org>
* chip/npcx/lpc: Don't enable Output Buffer Empty by defaultRaul E Rangel2020-02-271-2/+2
| | | | | | | | | | | | | | | OBE is enabled by lpc_keyboard_put_char and lpc_mouse_put_char and the disabled by lpc_kbc_obe_interrupt. No reason to enable the interrupt on initialization. BUG=b:145575366 BRANCH=none TEST=Verified OBE interrupt still fires. Change-Id: Iba3f97b2bf4a6c5f09833f808c52901bd8406b4f Signed-off-by: Raul E Rangel <rrangel@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073282 Reviewed-by: Edward Hill <ecgh@chromium.org>
* chip/npcx/lpc: Set bit 5 when sending AUX responses.Raul E Rangel2020-02-272-0/+8
| | | | | | | | | | | | | | The linux kernel expects bit 5 to be set in the status register when the output buffer contains and AUX packet. BUG=b:145575366 BRANCH=none TEST=Verified bit 5 is set when sending aux packets Change-Id: I0d3944ea6fd04224d9f9bcf0e1b0b3c8633ad786 Signed-off-by: Raul E Rangel <rrangel@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073281 Reviewed-by: Edward Hill <ecgh@chromium.org>
* chip/nxcp/lpc: Fix race condition when reading 8042 data.Raul E Rangel2020-02-271-4/+9
| | | | | | | | | | | | | | | | | When reading NPCX_HIKMDI it deasserts the IBF status flag. This means the AP is allowed to write to the input buffer. Because NPCX_HIKMDI is read twice, that means the AP could have written to the input buffer between reads. This results in losing one of the interrupts. This only happens if DEBUG_LPC is enabled. BUG=b:145575366 BRANCH=none TEST=Verified we don't lose any writes by examining logs. Change-Id: I2904c316fcad55001e8d297f4a0a73073b07702b Signed-off-by: Raul E Rangel <rrangel@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073280 Reviewed-by: Edward Hill <ecgh@chromium.org>
* c2d2: add support for I2C-based flashingJett Rink2020-02-277-72/+348
| | | | | | | | | | | | | | | | Add necessary console command to allow C2D2 to pass through i2c bus for ec and ap. Also hook into common ite programming mode code. BRANCH=servo BUG=b:148610186,b:147381671 TEST=flash ampton with C2D2 adapter Change-Id: I1d9b20684b45ff0d101b9cfff8b0b0a85e6c0c70 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2064594 Reviewed-by: David Schneider <dnschneid@chromium.org> Reviewed-by: Matthew Blecker <matthewb@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* Mushu : PD_Max change to 20V/5Aloganliao2020-02-271-2/+6
| | | | | | | | | | | | | | | BUG=b:145841965 BRANCH=none TEST=make BOARD=mushu Change-Id: I7c48d8b57e45f0e1193f3757845d5877d86a0b4b Signed-off-by: loganliao <Logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2051798 Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Scott Collyer <scollyer@chromium.org> Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Commit-Queue: Logan Liao <logan_liao@compal.corp-partner.google.com>
* USB PD: reset VCONN and keep consistent with the previous explicit contractxiong2020-02-271-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | In one case, TCPC was being a sink but a VCONN source in a previous explicit contract. TCPC was still be a sink but not go on suppling VCONN after rebooting EC. Guarding the saved VCONN role and If TCPC was being sourcing VCONN and as a sink source in previous explicit contract, TCPC should still be the VCONN source. BUG=b:150112192 TEST=Some dongles (PS176-01 and JCA374) can display after rebooting EC with adapter. BRANCH=kukui Signed-off-by: Xiong Huang <xiong.huang@bitland.corp-partner.google.com> Change-Id: Ia1e226d21e3a20411521b9ce6f19f749ac48bf51 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2071536 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Xiong Huang <xiong.huang@bitland.corp-partner.google.com> Commit-Queue: Xiong Huang <xiong.huang@bitland.corp-partner.google.com> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Xiong Huang <xiong.huang@bitland.corp-partner.google.com>
* usb_prl_sm: Add state names for debuggingEdward Hill2020-02-271-1/+57
| | | | | | | | | | | | | | | Add state names for prl_tx_states, prl_hr_states, rch_states, tch_states to test_prl_sm_data. BUG=none BRANCH=none TEST=none Change-Id: I1c929fccafc49448dcc58d2235cd7c6e0adf6167 Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068530 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* tcpmv2: Add names for super statesEdward Hill2020-02-272-1/+8
| | | | | | | | | | | | | | | Add names for super states to pe_state_names and tc_state_names, and BUILD_ASSERT that all states are named. BUG=none BRANCH=none TEST=none Change-Id: Iad77ff2e04f761e28169d9e11db328ca5fdb3727 Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068529 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* tcpmv2: Clean up TC_UNATTACHEDEdward Hill2020-02-271-11/+1
| | | | | | | | | | | | | | | | | | | CL 1900058 reverted CL 1825504 (remove unnecessary tcpc CC reads) and (unintentionally?) removed the TC_UNATTACHED super state added by CL 1864427. This change removes the now unused TC_UNATTACHED super state from enum usb_tc_state and cleans up comments to match the code. BUG=none BRANCH=none TEST=none Change-Id: Ia254208edd84e92cc8d8c13469f90c4f1e02fe1f Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068528 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* dalboz: update GPIOsEdward Hill2020-02-276-57/+42
| | | | | | | | | | | | BUG=b:147297680 BRANCH=none TEST=able to boot dalboz AP Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I4a3ec2a77292e48672f5c6143990c36b9a80b6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073277 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: Move fan into variant_trembyle.cEdward Hill2020-02-276-91/+66
| | | | | | | | | | | | BUG=b:147297680 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: Icc77e0d27db794b1aed0d65c7d30de3ccc3747ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2071391 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* zork: Create baseboard variants for trembyle/dalbozEdward Hill2020-02-279-56/+108
| | | | | | | | | | | | BUG=b:150110428 BRANCH=none TEST=none Signed-off-by: Edward Hill <ecgh@chromium.org> Change-Id: I30503a0416325fc8573a4a62b3bc3ff943b5008e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2071390 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* ish: board level PM enablement for tgl rvpLeifu Zhao2020-02-271-0/+17
| | | | | | | | | | | | | | | | | Board level power management enablement for tgl rvp. BUG=b:149238813 BRANCH=none TEST=ISH can successfully enter into D0i1/D0i2/D0i3 on tgl rvp. Signed-off-by: Leifu Zhao <leifu.zhao@intel.com> Change-Id: Ie1eaa532a38a286ca47540cb41edc8044cd7352b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2056150 Reviewed-by: Leifu Zhao <leifu.zhao@intel.corp-partner.google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Leifu Zhao <leifu.zhao@intel.corp-partner.google.com> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Auto-Submit: Leifu Zhao <leifu.zhao@intel.corp-partner.google.com>
* ish: chip level enablement for ish5.4 PMLeifu Zhao2020-02-273-32/+175
| | | | | | | | | | | | | | | | | Chip level power management enablement for ish5.4. BUG=b:149238813 BRANCH=none TEST=ISH can successfully enter into D0i1/D0i2/D0i3 on tgl rvp. Signed-off-by: Leifu Zhao <leifu.zhao@intel.com> Change-Id: Icc554a68fe57970bcaa7be457f56db34067858d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2055895 Reviewed-by: Leifu Zhao <leifu.zhao@intel.corp-partner.google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Leifu Zhao <leifu.zhao@intel.corp-partner.google.com> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Auto-Submit: Leifu Zhao <leifu.zhao@intel.corp-partner.google.com>
* ish: infrastructure changes to support ish5.4 PMLeifu Zhao2020-02-279-47/+114
| | | | | | | | | | | | | | | | | | Infrastructure related changes to support enabling power management for ish5.4 on tgl rvp platform. BUG=b:149238813 BRANCH=none TEST=ISH can successfully enter into D0i1/D0i2/D0i3 on tgl rvp. Signed-off-by: Leifu Zhao <leifu.zhao@intel.com> Change-Id: I50b6f1a4fe9c14f9479af2a2a438ec7395ec27a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2056149 Reviewed-by: Leifu Zhao <leifu.zhao@intel.corp-partner.google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Leifu Zhao <leifu.zhao@intel.corp-partner.google.com> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Auto-Submit: Leifu Zhao <leifu.zhao@intel.corp-partner.google.com>
* usbc: Awaken pd_task during pd_set_suspendAbe Levkoy2020-02-271-0/+7
| | | | | | | | | | | | | | | In the current implementation of the Disabled state, pd_task sleeps until it receives an event. Awaken pd_task upon resume, so that it can transition to Unattached.SNK. BUG=chromium:1021417 TEST=ectool pdcontrol suspend and resume (with subsequent commits) BRANCH=none Change-Id: Ic2de3f46920fa3d0d1853c0439d22cfa32fe07de Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2057981 Reviewed-by: Diana Z <dzigterman@chromium.org>
* usb_set_suspend: Use "enable" consistentlyAbe Levkoy2020-02-273-9/+9
| | | | | | | | | | | | | | The port is enabled when suspend is not enabled and vice versa. Avoid confusing these idioms. BUG=none TEST=make buildall BRANCH=none Change-Id: I3063793334ac875afee8a176f96625e8903d2694 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2057979 Reviewed-by: Keith Short <keithshort@chromium.org>
* max32660: add I2C board support for stand-alone read transactionsJerry Bradshaw2020-02-262-70/+134
| | | | | | | | | | | | | | | | | | | Adds support for solitary I2C board read transactions that are not preceded with an I2C write. BRANCH=none BUG=none TEST=Slave tested with EC CMDs and board cmds sent from a custom written EC HOST using another MAX32660 device as an I2C Master. Tested with Raspberry PI that emulates EC HOST and board commands. Change-Id: I653fd2bd9d4799c7e9cec4561906f0afe92c458c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1939779 Reviewed-by: Jes Klinke <jbk@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Reviewed-by: Tai-Hsu Lin <sheckylin@chromium.org> Tested-by: Tai-Hsu Lin <sheckylin@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org>
* util: add flash_cr50 script for updating cr50.Mary Ruthven2020-02-261-0/+771
| | | | | | | | | | | | | | | | | | | | | | | Add a flash_cr50 script for updating cr50. The script supports updating through gsctool and cr50-rescue. BUG=b:144048851 BRANCH=none TEST=manual python util/flash_cr50.py -i $IMAGE -p 9999 -c cr50-rescue on octopus. python util/flash_cr50.py -i $IMAGE -p 9999 --method=cr50_reset_odl -c cr50-rescue python util/flash_cr50.py -i $IMAGE -c 'sudo gsctool' python util/flash_cr50.py -i $IMAGE -s $SERIAL Change-Id: Ibdd213446fea4cb66f77c6b7249c02914bd0712a Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1907469 Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
* nocturne_fp/hatch_fp: Make explicit fields in spi arrayCraig Hesling2020-02-262-2/+2
| | | | | | | | | | | | | | | This has no functional change, as verified with compare_build.sh. BRANCH=nocturne,hatch BUG=none TEST=./util/compare_build.sh --board nocturne_fp TEST=./util/compare_build.sh --board hatch_fp Change-Id: I4e58a65cd47fe136a471d2c16444d106e8431e5c Signed-off-by: Craig Hesling <hesling@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2071149 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* RELAND: kodama: enable i2c bitbangxiong.huang2020-02-264-4/+24
| | | | | | | | | | | | | | | | | | | | | This is a reland of CL:1876290 for kodama in master. firmware-kukui-12573.B has landed this function. Original commit message: > - Enable bitbang driver > - increase the console/hook stack size because accessing bitbang i2c bus > - requires more stack memory than before BUG=none TEST=1) make buildall 2) boot on Kodama 3) Get battery information normally BRANCH=kukui Change-Id: I05f9e0f7df2369bcbddfa9be55aec03ce821ea8b Signed-off-by: Xiong Huang <xiong.huang@bitland.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2071540 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* dalboz: Add base/lid sensor configurationLu Zhang2020-02-267-97/+386
| | | | | | | | | | | | | | | | Dalboz uses LSM6DS3TR/LIS2DWL instead of BMI160/KX022 BUG=b:149968926 BRANCH=none TEST=using ec console 'accelinfo on' to see if there is sensor data output. Change-Id: If385c5554b50795702736aa8e1e3090dcb8b618a Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2069965 Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* PS8xxx: Workaround of Connection Detection not restartedWai-Hong Tam2020-02-263-3/+44
| | | | | | | | | | | | | | | | | | When issuing the COMMAND.Look4Connection to enable PS8805/PS8815 to restart Connection Detection, PS8805/PS8815 doesn't do so if the partner already presents Rp. This is a workaround that changes the starting pull to the opposite when doing DRP auto-toggle. BRANCH=None BUG=b:149570002 TEST=Enabled TCPMv2 and verified a 20V charger detected properly. TEST=Enabled TCPMv2 and verified a Type-C dongle detected properly. Change-Id: Ic2f65bdd74d1825ae81fcd30fec5e72d29a51663 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2067481 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* volteer: Update USB C1 reset for next buildstabilize-volteer-12931.B-masterKeith Short2020-02-265-10/+43
| | | | | | | | | | | | | | | | Update the GPIO assignment for the USB_C1_RT_RST_ODL signal for the next board build. BUG=b:144933528, b:148243971 BRANCH=none TEST=make buildall TEST=Check unassigned board ID or board ID=0 uses legacy GPIO setting. Otherwise new GPIO setting is used. Change-Id: I4621e039e4461a4e10ab87bc2d4e000b5dcaa885 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2057496 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
View Lorry Controller Status