| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enforce having a bug listed in the LOW_COVERAGE_REASON to track the
issue that impedes coverage for that specific CL. This encourages
developers to go back and fix those problems. Also update the
documentation.
BUG=None
TEST=util/check_low_coverage_reason.py
Change-Id: If35f918b11771d10944e0b6e7a4aeeba84e05eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4537010
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Tristan Honscheid <honscheid@google.com>
Tested-by: Tristan Honscheid <honscheid@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a note about the new config option
CONFIG_COMPILER_TRACK_MACRO_EXPANSION, and also add an example on how to
disable LTO without changing the project file itself.
BUG=none
TEST=check the page on gitiles
Change-Id: I3af8b5ba4f8a0e59a419e426baa4d5460040e86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4516858
Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: Fabio Baltieri <fabiobaltieri@google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove flasrhom EC commands because ectool should be used instead.
BUG=b:280361439
TEST=N/A
Change-Id: Ia8362ca325ed7164adbdbea39f1223b61da45c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4514139
Commit-Queue: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: Nikolai Artemiev <nartemiev@google.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=none
TEST=view in gitiles
Change-Id: I932ff49ccd17e48edd1c200e574e0377774d17c3
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4485199
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:278138274
BRANCH=none
TEST=Tested on ADL-RVP, retimer console command works
./twister -T zephyr/test/drivers
./twister -T zephyr/test/drivers -s drivers.default
./firmware_builder.py --metrics /tmp/tmp_pc1rc15 build
Change-Id: Idaec9b41f550ad6aafa34400e95ebf00b9c11348
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4426790
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Describe how ec_commands.h is shared among different code base and
practices to share changes.
BUG=b:187787115
BRANCH=none
TEST=Check with
`python3 src/chromium/src/tools/md_browser/md_browser.py -d src/platform/ec/docs`
and go to http://localhost:8080/ap-ec-comm.md
Change-Id: Ie9c1966002ca8f7b85bd28ddeda247467820f019
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4369568
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Rob Barnes <robbarnes@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update our documentation to highlight the use of the new
`extra_conf_files`, `extra_overlay_confs`, and `extra_dtc_overlay_files`
YAML fields instead of specifying these in CMake variables in
`extra_args` in `testcase.yaml` files.
These new fields are more readable and were introduced in upstream
Zephyr earlier this year. The plan is to eventually deprecate the
ability to specify confs and overlays through extra_args upstream
following a migration.
BUG=None
BRANCH=None
TEST=None
Change-Id: I3db0b0dcbb24a8dc1f6e38214d7538e6dca50dfb
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4428296
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add links for how to register/get an invite to the Zephyr discord
server.
BUG=none
BRANCH=none
TEST=loaded in chrome and checked for correct render + click on links.
Signed-off-by: Eric Peers <epeers@google.com>
Change-Id: Ib2600bf09f8b258da429925c07f457c308214662
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4412617
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Document how we can trace ec_commands in the EC console and in the kernel.
BUG=none
BRANCH=none
TEST=Check with
`python3 src/chromium/src/tools/md_browser/md_browser.py -d src/platform/ec/docs`
and go to http://localhost:8080/ap-ec-comm.md
Change-Id: Iaf790dc945b46046b84b9f9574bf9a8e552789a5
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4369567
Reviewed-by: Rob Barnes <robbarnes@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=none
TEST=view in gitiles
Change-Id: Id90e483501425f6f0adcfec35b9852a513dd3a80
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4400371
Reviewed-by: Josie Nordrum <josienordrum@google.com>
Reviewed-by: Firas Sammoura <fsammoura@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a note about recompiling tests without rerunning twister and using
gdb on a test generated binary.
BRANCH=none
BUG=none
TEST=checked the page on gitiles
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: Iaaa18d18e4be79d95793932f2848245571484b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4393513
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's now a dedicated Kconfig option for enabling save-temps, switch
the zmake save-temps flag to use that instead of EXTRA_CFLAGS directly.
Update the troubleshooting documentation as well while we are at it.
BRANCH=none
BUG=none
TEST=python3 -m zmake build --save-temps rex
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Cq-Depend: chromium:4393983
Change-Id: I04ecf7cee5134da095c5b3656df2c4f7fdad2056
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4393512
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A bunch of code was leftover after the twister migration. Delete all
references to running tests in zmake.
BUG=b:242563072
BRANCH=i don't care stop bothering me
TEST=unit tests pass
Change-Id: I99b5ff0ae22f74ebecddc6b4dfb0cb5f2b498ea3
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4380141
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Commit-Queue: Tristan Honscheid <honscheid@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mdformat -w --compatibility docs/reducing_ec_image_size.md
BRANCH=none
BUG=none
TEST=view in gitiles
Change-Id: I65e21d5797c614fb3d9adf96df3fefbd034386a0
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4376212
Reviewed-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=none
TEST=view in gitiles
Change-Id: I9131efe660c50c33fc7aaf5cc9ec2b5ff8cdf637
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4376210
Reviewed-by: Firas Sammoura <fsammoura@google.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You should abandon cls that are bad, don't downvote them.
BRANCH=None
BUG=b:274462658
TEST=Abandoned a cl
Change-Id: Ic9ee9d927155cd4ddb766527f643f81dd9d6f3d9
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4368547
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: George Engelbrecht <engeg@google.com>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=none
TEST=view in gitiles
Change-Id: Id34677a59df66603f95fa4c6ba20c2ec8989d770
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4356022
Reviewed-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=none
TEST=view in gitiles
Change-Id: I579b74b63531b33d96fab4607c4b56b646bdde5a
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4356020
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a note in to the __device_dts_ord bit to point out at where to find
the reference.
BRANCH=none
BUG=none
TEST=view on gitiles
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: I230edd1df47a67006315077eed65f04c10963446
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4264114
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has been un-recommended for a while, and the developer guide link
points to a missing anchor.
Also replace 'trunk' with 'chromiumos'; the latter has been recommended
for a while.
BRANCH=none
BUG=none
TEST=none
Change-Id: I5d7ba9601762f98d8a87af7bacc0163d7735476c
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4295357
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Commit-Queue: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the remnants of CMD_PD_DEV_DUMP_INFO from TCPMv2. The function
that was left did not link when enabled.
BUG=b:250015035
TEST=make buildall
BRANCH=none
Change-Id: I884bade638873d79dfcbc72bb5bf98d53f5afa78
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4263563
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new header file that provides type-checked function stubs
for constructing EC host commands. ec_cmd_api.h augments the existing
ec_commands.h to provide a C-friendly host commands API for ectool, unit
tests and other subsystems such as coreboot and the linux kernel.
Consumers of this header file need to provide 2 definitions:
* CROS_EC_COMMAND_INFO: A data type for holding context information for
EC calls.
* CROS_EC_COMMAND: A function that performs the actual EC communication.
BRANCH=none
BUG=b:258110734
TEST=validated with zephyr/test unit tests in following patch
Change-Id: I4a54d2a795e2d4781809c4c6a20340b4d44eb98f
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3996306
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit removes the references to internal shi node in device tree
and changes them to shi0 from the Zephyr device trees.
Changes also the compatible string from internal to upstream one
by removing the 'cros' prefix and removes the binding files.
BRANCH=main
BUG=b:265763662
TEST=run the host commands test on affected boards
LOW_COVERAGE_REASON=No tests are available for EC on-chip peripherals.
Change-Id: Iefdba23680d7734013de128f1b8878bac2c96cfa
Signed-off-by: Michał Barnaś <mb@semihalf.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4180585
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Michał Barnaś <barnas@google.com>
Tested-by: Michał Barnaś <barnas@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After the chroot has been created from scratch, the toolchain needs to
be installed before building the FPMCU firmware will work.
BRANCH=none
BUG=none
TEST=view in gitiles
Change-Id: Ic67f22592ff7b99956ed894634ff14ce0e359d4c
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4221982
Reviewed-by: Andrea Grandi <agrandi@google.com>
Reviewed-by: Firas Sammoura <fsammoura@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "--no-ns-pid" option to cros_sdk is no longer needed.
The output from servod was from a run with the zerblebarn board, which
we no longer use.
BRANCH=none
BUG=b:178129469
TEST=view in gitiles
Change-Id: Ie6cc24e3debce729befb89cac192c40e01b9cf26
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4221981
Reviewed-by: Andrea Grandi <agrandi@google.com>
Reviewed-by: Firas Sammoura <fsammoura@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Twister changed up how the `-s` parameter works, so update the docs with
new instructions on how to use it.
BUG=None
BRANCH=None
TEST=Tested command locally
Change-Id: I114b0dce356602cd82e6cbe11487d266889b8890
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4214751
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a doc explaining what to do with pupr cls.
BRANCH=None
BUG=b:261258378
TEST=None
Change-Id: Idf2cc0d26f225056ba5e9d841626cb9a6101f42a
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4198453
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the firmware testing requirements doc to reflect the new
90% threshold.
BUG=None
BRANCH=None
TEST=None, ironically
Change-Id: I35f90b1592db2203d3c6f7ae05071fdd23ad0695
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4182781
Reviewed-by: Yuval Peress <peress@google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Document the code coverage test requirements.
BUG=b:261987897
BRANCH=none
TEST=View docs in preview mode
Change-Id: I0bde6ed3f36f88f4e7d1102c29ea73d112b82e74
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4166320
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not derating seems like a common pitfall that can cause problems with
some chargers, so set a reasonably conservative default.
5% is chosen as the most common derating factor used among boards today
(counting occurrences in source code, so this may undercount 5%
occurrences because several projects set 5% at the project rather than
board-level):
1. 38 x 5%
2. 23 x 4%
3. 6 x 10%
3. 2 x 3%
4. 1 x 2%
Boards that currently configure this setting are modified only to
continue building without warnings regardless of whether they use the
new default value in order to signal that they were explicitly
configured.
BUG=b:260774380
TEST=make buildall / zmake build -a
BRANCH=none
Change-Id: I017849d38572fbc48090ae1fa2c539b808e426f9
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4109651
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split the mkbp node binding in two nodes, normal and host. This adds the
automatic Kconfig entries that can be used to control the option and
simplify few macros.
BRANCH=none
BUG=none
TEST=cq dry run
TEST=zmake compare-builds -a
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: I8a4825e616557a981a700c13517e76a3fd86ea07
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4117086
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Select PLATFORM_EC_LED_DT automatically when the LED policy node is find
in the devicetree. Drop the remaining LED DT options from the config
files.
BRANCH=none
BUG=none
TEST=cq dry run
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: Ia406abed7e9ca36a2952c59d34daa15a9db76c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4054627
Reviewed-by: Yuval Peress <peress@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Default input current" is not a very clear name, so rename this option to
better express its use as a default value that is set in the charger.
This is made possible by splitting other uses into
CHARGER_MIN_INPUT_CURRENT_LIMIT, making the only use for
CHARGER_INPUT_CURRENT be as a default.
BUG=b:163093572
TEST=make buildall; zmake build -a
BRANCH=none
LOW_COVERAGE_REASON=isl9241 and sm5803 currently lack emulators
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: Ia9c1df9061825b15477466e85343afeb2a371288
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4025404
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This splits the dual use of CONFIG_CHARGER_INPUT_CURRENT into two
different symbols, changing the uses of that which are used to set a
minimum current limit to be CONFIG_CHARGER_MAX_INPUT_CURRENT_LIMIT.
Most boards implement this in the same way within either the board or
baseboard, so handling of the new option is moved into
charge_set_input_current_limit (which is called by every user of the
option) and every board which repeated this pattern has the new symbol
set to the same value as the old one, with the duplicated code deleted.
One functional change to the charge manager is made: when charging
stops, the input current limit is set to the default value
(CONFIG_CHARGER_INPUT_CURRENT) rather than 0. This captures the intent
that the default current is appropriate at any time, which was previously
configured by individual boards' implementation of board_set_charge_limit()
while still allowing the limit to be set lower as needed.
To verify that all changes are appropriate, the following has been
manually checked:
* All boards with a change to a .c file also have a .h change
* All boards without a changed .h file have a changed baseboard.h
* For Zephyr projects, those with a changed .c file have config added
for the minimum limit and others (only corsola) are unchanged to
leave it off.
This is intended to verify that each board that duplicated the MAX()
logic has its configuration updated to use the shared copy, and that
boards with that code in the baseboard also update their configuration.
BUG=b:163093572
TEST=make buildall; zmake build -a
BRANCH=none
LOW_COVERAGE_REASON=added lines will soon be deleted
Change-Id: Ia460a16293c1fb82aac3784fd9be57ba0985f2fe
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4019703
Reviewed-by: Keith Short <keithshort@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Similarly to the gpio led binding, the pwm led binding is using phandle
cells as values. Fix up the code to use a separate property instead, at
this point the -config binding is not needed anymore and we can use the
upstream pwm-leds directly.
BRANCH=none
BUG=b:242826402
TEST=validated the resulting structure with gdb
TEST=zmake build -a; ./twister
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: Iec480da15e2ff5e356bad11fbfb6031d4d56353a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4031269
Reviewed-by: Sam Hurst <shurst@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current cros-ec,gpio-led-pins binding is leaking values into the
named-gpios binding. That's an incorrect way of using the devicetree and
only works because named-gpios is not currently using the value cell and
because we control the binding.
Move the values in a separate property within the cros-ec,gpio-led-pins
binding.
BRANCH=none
BUG=b:242826402
TEST=validated the resulting structure with gdb
TEST=zmake build -a; ./twister
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: I77a09b25cc69c5faed254da38316104b304c8f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4031268
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An upstream change modified the way the `-s` flag works in Twister. This
CL updates places in our docs that reference this flag.
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Change-Id: Ib610c6c8779dea3842cbf33c82f95e18c1fed99d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4028959
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Document the commands needed to add a new VM to the gitlab runners.
One of the VMs ran out of disk space, so add a daily cleanup cron job to
delete old docker data.
BRANCH=None
BUG=b:244590155
TEST=Ran the crontab commands
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I0196cad3fbe113614feea33582741a3d15f27fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4016955
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Al Semjonovs <asemjonovs@google.com>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename the SSFC dts bindings for consistency with the FW_CONFIG ones.
BRANCH=none
BUG=none
TEST=cq dry run
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: Ic47e60948ca6cf3face5903ecbfc8d9b3d0b6c7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3999727
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the documentation for the program and project organization.
BUG=b:254064666
BRANCH=none
TEST=View docs in preview mode.
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: Ifd647eafa9e0ca9d1d60528fa75f54244b154426
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3968445
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was an incomplete sentence. I finished it.
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I991b5248453baeb2e8a0540d59ba3056b19baafa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3995819
Commit-Queue: Tomasz Michalec <tmichalec@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Tomasz Michalec <tmichalec@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since zassume is being used in scenarios where no one would use
ztest_test_skip(), convert all zassumes to zasserts.
BRANCH=None
BUG=b:256650891
TEST=./twister
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I1dc806e25f64f8dbef6f7d10cfe2f46ea4887e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3937539
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Aaron Massey <aaronmassey@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the documentation for testing on Zephyr to reflect the latest
tools and features. Removed docs/zephyr/zephyr_testing.md since it was
only intended to be used for the fix-it week.
BRANCH=none
BUG=none
TEST=none
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: I54cb53af7d051e2ea1c3813f3907773c4e52f83a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3945693
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=None
BUG=b:253647573
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I1f91b8123a2e44ea5a137f9644645ca1b4494aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3956204
Reviewed-by: Bobby Casey <bobbycasey@google.com>
Commit-Queue: Bobby Casey <bobbycasey@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit removes the last NULL parameter that was required by
the zassert_* and zassume_* macros.
BRANCH=main
BUG=b:242982518
TEST=run twister
Change-Id: I8970ee0a755e103367c5edcdf0fd469337c66721
Signed-off-by: Michał Barnaś <mb@semihalf.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3838329
Reviewed-by: Keith Short <keithshort@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Commit-Queue: Michał Barnaś <barnas@google.com>
Tested-by: Michał Barnaś <barnas@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a section that describes how to add configuration settings for a
specific test (example: definition).
BRANCH=None
BUG=b:250625014
TEST=Preview Document
Signed-off-by: Firas Sammoura <fsammoura@google.com>
Change-Id: I79d40e9fc97bf6f1bf98ed68d8090cb00a963ae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3932867
Reviewed-by: Craig Hesling <hesling@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We no longer support the old Dragonclaw boards, so remove the
documentation to avoid confusion.
BRANCH=none
BUG=b:249784223
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I523b6a79915719bb0dc87c3b51d15594c53588c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3926346
Reviewed-by: Andrea Grandi <agrandi@google.com>
Reviewed-by: Bobby Casey <bobbycasey@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flash_ec now consistently works with icetower.
BRANCH=none
BUG=b:177331210
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Id57d53c3779652afe60a555436b4177e27603463
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3926348
Reviewed-by: Bobby Casey <bobbycasey@google.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:249784223
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Id5a8fb9903a38552074913c0c7a2ac4b278e53b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3923729
Reviewed-by: Bobby Casey <bobbycasey@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add documentation for configuring USBC.
BUG=b:208437225
TEST=Browse doc in gerrit
BRANCH=main
Signed-off-by: Sam Hurst <shurst@google.com>
Change-Id: Ibb4a25bb76673b29600a8d4e405792604d67e702
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3440847
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|