diff options
| author | Bill XIE <persmule@hardenedlinux.org> | 2019-11-12 01:19:25 +0800 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-11-12 18:22:34 +0000 |
| commit | 675cb9152e6704383cf402c55758ddea2c7a1e05 (patch) | |
| tree | d8fa0411c836bcc6aaaa0fb070da10c3f9f8262d /util/autoport | |
| parent | 8088584b37b96532d87d0b8a000925313a237749 (diff) | |
| download | coreboot-675cb9152e6704383cf402c55758ddea2c7a1e05.tar.gz | |
util/autoport: Stop generate empty h8_mainboard_init_dock().
CB:36385 makes dock init in ramstage fully mainboard-specific, so
keeping generating empty h8_mainboard_init_dock() for lenovo EC becomes
unnecessary and problematic.
Change-Id: I19f57f41403ffd0319cc86f21bec7e142095df83
Signed-off-by: Bill XIE <persmule@hardenedlinux.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36752
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'util/autoport')
| -rw-r--r-- | util/autoport/ec_lenovo.go | 14 | ||||
| -rw-r--r-- | util/autoport/readme.md | 6 |
2 files changed, 3 insertions, 17 deletions
diff --git a/util/autoport/ec_lenovo.go b/util/autoport/ec_lenovo.go index c2dd333c73..9384896dc8 100644 --- a/util/autoport/ec_lenovo.go +++ b/util/autoport/ec_lenovo.go @@ -59,20 +59,6 @@ Method(_PTS,1) si.WriteString("#include <drivers/pc80/pc/ps2_controller.asl>\n") - dock := Create(ctx, "dock.c") - defer dock.Close() - - AddRAMStageFile("dock.c", "") - - dock.WriteString( - `#include <ec/lenovo/h8/h8.h> - -void h8_mainboard_init_dock (void) -{ -/* FIXME: fill this if needed. */ -} -`) - /* FIXME:XX Move this to ec/lenovo. */ smi := Create(ctx, "smihandler.c") defer smi.Close() diff --git a/util/autoport/readme.md b/util/autoport/readme.md index fa349b906f..6d1c64c3eb 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -407,9 +407,9 @@ Keep `GPE_EC_WAKE` and `GPE_EC_SCI` in sync with `gpi*_routing`. `gpi*_routing` matching `GPE_EC_WAKE` or `GPE_EC_SCI` is set to `2` and all others are absent. -If your dock has LPC wires or needs some special treatement you -need to fill `h8_mainboard_init_dock` and add support code to -DSDT. See the code for `x60`, `x200` or `x201` +If your dock has LPC wires or needs some special treatement you may +need to add codes to initialize the dock and support code to +DSDT. See the `init_dock()` for `x60`, `x200` or `x201`. ## EC (generic laptop) |