diff options
| author | Paul J. Davis <paul.joseph.davis@gmail.com> | 2020-02-27 14:02:51 -0600 |
|---|---|---|
| committer | Paul J. Davis <paul.joseph.davis@gmail.com> | 2020-02-27 16:38:01 -0600 |
| commit | 7dc96b2a62f845d82a3fed17be8ac130a02fb690 (patch) | |
| tree | 5a6a487d223d0254fef6bd5b3c629afee795cae2 | |
| parent | 16304d08581a1e4de8e32d7baf7eddefb0921942 (diff) | |
| download | couchdb-3.0.x-fix-mem3-sync-event-listener-test.tar.gz | |
Fix mem3_sync_event_listener test3.0.x-fix-mem3-sync-event-listener-test
There's a race between the meck:wait call in setup and killing the
config_event process. Its possible that we could kill and restart the
config_event process after meck:wait returns, but before
gen_event:add_sup_handler is called. More likely, we could end up
killing the config_event gen_event process before its fully handled the
add_sup_handler message and linked the notifier pid.
This avoids the race by waiting for config_event to return that it has
processed the add_sup_handler message instead of relying on meck:wait
for the subscription call.
| -rw-r--r-- | src/mem3/src/mem3_sync_event_listener.erl | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/src/mem3/src/mem3_sync_event_listener.erl b/src/mem3/src/mem3_sync_event_listener.erl index b6fbe3279..cad34225d 100644 --- a/src/mem3/src/mem3_sync_event_listener.erl +++ b/src/mem3/src/mem3_sync_event_listener.erl @@ -236,7 +236,7 @@ teardown_all(_) -> setup() -> {ok, Pid} = ?MODULE:start_link(), erlang:unlink(Pid), - meck:wait(config_notifier, subscribe, '_', 1000), + wait_config_subscribed(Pid), Pid. teardown(Pid) -> @@ -338,4 +338,16 @@ wait_state(Pid, Field, Val) when is_pid(Pid), is_integer(Field) -> end, test_util:wait(WaitFun). + +wait_config_subscribed(Pid) -> + WaitFun = fun() -> + Handlers = gen_event:which_handlers(config_event), + Pids = [Id || {config_notifier, Id} <- Handlers], + case lists:member(Pid, Pids) of + true -> true; + false -> wait + end + end, + test_util:wait(WaitFun). + -endif. |