summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRussell Branca <chewbranca@apache.org>2018-09-04 18:53:56 +0000
committerRussell Branca <chewbranca@apache.org>2018-09-11 20:25:49 +0000
commit79dd05481c7c6f7d7a9eff483a6f8f839cc147ac (patch)
tree8f23cf51f1a6bbdaa262f57b860747226455d088
parentbbf0cc1826635978c5fa9cd238a4351da8849454 (diff)
downloadcouchdb-couch-server-improvements.tar.gz
Don't send update_lru messages when disabledcouch-server-improvements
The couchdb.update_lru_on_read setting controls whether couch_server uses read requests as LRU update triggers. Unfortunately, the messages for update_lru on reads are sent regardless of whether this is enabled or disabled. While in principle this is harmless, and overloaded couch_server pid can accumulate a considerable volume of these messages, even when disabled. This patch prevents the caller from sending an update_lru message when the setting is disabled.
-rw-r--r--src/couch/src/couch_server.erl11
1 files changed, 8 insertions, 3 deletions
diff --git a/src/couch/src/couch_server.erl b/src/couch/src/couch_server.erl
index ef895a414..c4b7bf199 100644
--- a/src/couch/src/couch_server.erl
+++ b/src/couch/src/couch_server.erl
@@ -101,9 +101,14 @@ open(DbName, Options0) ->
end.
update_lru(DbName, Options) ->
- case lists:member(sys_db, Options) of
- false -> gen_server:cast(couch_server, {update_lru, DbName});
- true -> ok
+ case config:get_boolean("couchdb", "update_lru_on_read", false) of
+ true ->
+ case lists:member(sys_db, Options) of
+ false -> gen_server:cast(couch_server, {update_lru, DbName});
+ true -> ok
+ end;
+ false ->
+ ok
end.
close_lru() ->