diff options
| author | Nick Vatamaniuc <vatamane@apache.org> | 2020-08-20 11:57:56 -0400 |
|---|---|---|
| committer | Nick Vatamaniuc <vatamane@apache.org> | 2020-08-20 12:57:22 -0400 |
| commit | b8e3c3e18f9ed08e6ddfb124ee9459f49ae40dc6 (patch) | |
| tree | cffff70f10ee7053c544db677784eca439e16d83 | |
| parent | aa40f9e0ef467eb3fb8f840b632e54973b53862e (diff) | |
| download | couchdb-handle-jiffy-iolist-reponse-in-atts-since-3.x.tar.gz | |
Handle jiffy returning an iolist when encoding atts_since query stringhandle-jiffy-iolist-reponse-in-atts-since-3.x
If we don't handle it, it throws an error when trying to encode the full URL
string, for example:
```
badarg,[
{mochiweb_util,quote_plus,2,[{file,"src/mochiweb_util.erl"},{line,192}]},
{couch_replicator_httpc,query_args_to_string,2,[{file,"src/couch_replicator_httpc.erl"},{line,421}]},
{couch_replicator_httpc,full_url,2,[{file,"src/couch_replicator_httpc.erl"},{line,413}]},
{couch_replicator_api_wrap,open_doc_revs,6,[{file,"src/couch_replicator_api_wrap.erl"},{line,255}]}
]
```
This is also similar to what we did for open_revs encoding: https://github.com/apache/couchdb/commit/a2d0c4290dde2015e5fb6184696fec3f89c81a4b
| -rw-r--r-- | src/couch_replicator/src/couch_replicator_api_wrap.erl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/couch_replicator/src/couch_replicator_api_wrap.erl b/src/couch_replicator/src/couch_replicator_api_wrap.erl index a21de4242..8dc7f2f01 100644 --- a/src/couch_replicator/src/couch_replicator_api_wrap.erl +++ b/src/couch_replicator/src/couch_replicator_api_wrap.erl @@ -546,7 +546,7 @@ options_to_query_args(HttpDb, Path, Options0) -> length("GET " ++ FullUrl ++ " HTTP/1.1\r\n") + length("&atts_since=") + 6, % +6 = % encoded [ and ] PAs, MaxLen, []), - [{"atts_since", ?JSON_ENCODE(RevList)} | QueryArgs1] + [{"atts_since", ?b2l(iolist_to_binary(?JSON_ENCODE(RevList)))} | QueryArgs1] end. |