summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Vatamaniuc <vatamane@gmail.com>2021-11-23 11:13:42 -0500
committerNick Vatamaniuc <vatamane@gmail.com>2021-11-23 15:45:21 -0500
commit80aad875d0b0f6dfda3ead2d7da733865555c521 (patch)
treeeeb74402ce9c492261365a6a43392dd4e8fb125d
parent8f70f12c7de10a7dd2c51cc8a269b54fdf919bc0 (diff)
downloadcouchdb-jenkins-fix-quoting-main.tar.gz
Fix Jenkins email quoting failuresjenkins-fix-quoting-main
Should fix: ``` Warning: A secret was passed to "mail" using Groovy String interpolation, which is insecure. ```
-rw-r--r--build-aux/Jenkinsfile.full13
1 files changed, 6 insertions, 7 deletions
diff --git a/build-aux/Jenkinsfile.full b/build-aux/Jenkinsfile.full
index 144c18b39..20b8989a2 100644
--- a/build-aux/Jenkinsfile.full
+++ b/build-aux/Jenkinsfile.full
@@ -54,7 +54,6 @@ pipeline {
environment {
COUCHAUTH = credentials('couchdb_vm2_couchdb')
- recipient = 'notifications@couchdb.apache.org'
COUCHDB_IO_LOG_DIR = '/tmp/couchjslogs'
// Following fix an issue with git <= 2.6.5 where no committer
// name or email are present for reflog, required for git clone
@@ -754,20 +753,20 @@ pipeline {
post {
success {
- mail to: "${env.recipient}",
- replyTo: "${env.recipient}",
+ mail to: 'notifications@couchdb.apache.org',
+ replyTo: 'notifications@couchdb.apache.org',
subject: "[Jenkins] SUCCESS: ${currentBuild.fullDisplayName}",
body: "Yay, we passed. ${env.RUN_DISPLAY_URL}"
}
unstable {
- mail to: "${env.recipient}",
- replyTo: "${env.recipient}",
+ mail to: 'notifications@couchdb.apache.org',
+ replyTo: 'notifications@couchdb.apache.org',
subject: "[Jenkins] SUCCESS: ${currentBuild.fullDisplayName}",
body: "Eep! Build is unstable... ${env.RUN_DISPLAY_URL}"
}
failure {
- mail to: "${env.recipient}",
- replyTo: "${env.recipient}",
+ mail to: 'notifications@couchdb.apache.org',
+ replyTo: 'notifications@couchdb.apache.org',
subject: "[Jenkins] FAILURE: ${currentBuild.fullDisplayName}",
body: "Boo, we failed. ${env.RUN_DISPLAY_URL}"
}