summaryrefslogtreecommitdiff
path: root/t/18_bug_92205.t
diff options
context:
space:
mode:
Diffstat (limited to 't/18_bug_92205.t')
-rw-r--r--t/18_bug_92205.t117
1 files changed, 117 insertions, 0 deletions
diff --git a/t/18_bug_92205.t b/t/18_bug_92205.t
new file mode 100644
index 0000000..e1c1470
--- /dev/null
+++ b/t/18_bug_92205.t
@@ -0,0 +1,117 @@
+#!/usr/bin/perl
+
+use strict;
+
+BEGIN {
+ $| = 1;
+ $^W = 1;
+}
+
+use Test::More tests => 32;
+use t::common;
+use Archive::Zip qw( :CONSTANTS );
+
+
+# RT #92205: CRC error when re-writing Zip created by LibreOffice
+
+# Archive::Zip was blowing up when processing member
+# 'Configurations2/accelerator/current.xml' from the LibreOffice file.
+#
+# 'current.xml' is a zero length file that has been compressed AND uses
+# streaming. That means the uncompressed length is zero but the compressed
+# length is greater than 0.
+#
+# The fix for issue #101092 added code that forced both the uncompressed &
+# compressed lengths to be zero if either was zero. That caused this issue.
+
+
+# This set of test checks that a zero length zip member will ALWAYS be
+# mapped to a zero length Stored member, regardless of the compression
+# method used or the use of streaming.
+#
+#
+# Input files all contain a single zero length member.
+# Streaming & Compression Method are set as follows.
+#
+# File Streamed Method
+# ===============================================
+# emptydef.zip No Deflate
+# emptydefstr.zip Yes Deflate
+# emptystore.zip No Store
+# emptystorestr.zip Yes Store
+#
+# See t/data/mkzip.pl for the code used to create these zip files.
+
+
+my @empty = map { "t/data/$_.zip" }
+ qw( emptydef emptydefstr emptystore emptystorestr );
+
+# Implicit tests - check that stored gets used when no compression method
+# has been set.
+for my $infile (@empty)
+{
+ my $expectedout = "t/data/emptystore.zip";
+ my $outfile = OUTPUTZIP;
+
+ passthrough($infile, $outfile, sub {
+ my $member = shift ;
+ $member->setLastModFileDateTimeFromUnix($member->lastModTime());
+ });
+
+ my $expected = readFile($expectedout);
+ my $after = readFile($outfile);
+
+ my ($status, $reason) = testZip($outfile);
+ is $status, 0, "testZip ok after $infile to $outfile"
+ or warn("ziptest said: $reason\n");
+ ok $expected eq $after, "$expectedout eq $outfile";
+}
+
+
+
+# Explicitly set desired compression
+for my $method ( COMPRESSION_STORED, COMPRESSION_DEFLATED)
+{
+ for my $infile (@empty)
+ {
+ my $outfile = OUTPUTZIP;
+ my $expectedout = "t/data/emptystore.zip";
+
+ passthrough($infile, $outfile, sub {
+ my $member = shift ;
+ $member->desiredCompressionMethod( $method );
+ $member->setLastModFileDateTimeFromUnix($member->lastModTime());
+ });
+
+ my $expected = readFile($expectedout);
+ my $after = readFile($outfile);
+
+ my ($status, $reason) = testZip($outfile);
+ is $status, 0, "[$method] testZip ok after $infile to $outfile"
+ or warn("ziptest said: $reason\n");
+ ok $after eq $expected, "[$method] $infile eq $outfile";
+ }
+}
+
+# The following non-empty files should not be changed at all
+my @nochange = map { "t/data/$_.zip" }
+ qw( def defstr store storestr );
+
+for my $infile (@nochange)
+{
+ my $outfile = OUTPUTZIP;
+
+ passthrough($infile, $outfile, sub {
+ my $member = shift ;
+ $member->setLastModFileDateTimeFromUnix($member->lastModTime());
+ });
+
+ my $expected = readFile($infile);
+ my $after = readFile($outfile);
+
+ my ($status, $reason) = testZip($outfile);
+ is $status, 0, "testZip ok after $infile to $outfile"
+ or warn("ziptest said: $reason\n");
+ ok $expected eq $after, "$infile eq $outfile";
+}
+