diff options
author | Nick Coghlan <ncoghlan@gmail.com> | 2013-11-13 22:24:58 +1000 |
---|---|---|
committer | Nick Coghlan <ncoghlan@gmail.com> | 2013-11-13 22:24:58 +1000 |
commit | 63b965b3856eb8cee28a743a91b68b4f798672fc (patch) | |
tree | bfc69ec4638df681988e60289187224188e87f04 | |
parent | 3ee9210cf5e744a175acec3e1f49ff57f8413443 (diff) | |
download | cpython-63b965b3856eb8cee28a743a91b68b4f798672fc.tar.gz |
Avoid global side effect in test_ensurepip
-rw-r--r-- | Lib/test/test_ensurepip.py | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/Lib/test/test_ensurepip.py b/Lib/test/test_ensurepip.py index e87f476eac..abf00fd188 100644 --- a/Lib/test/test_ensurepip.py +++ b/Lib/test/test_ensurepip.py @@ -2,6 +2,8 @@ import unittest import unittest.mock import ensurepip import test.support +import os +import os.path class TestEnsurePipVersion(unittest.TestCase): @@ -17,9 +19,12 @@ class TestBootstrap(unittest.TestCase): self.run_pip = run_pip_patch.start() self.addCleanup(run_pip_patch.stop) - os_environ_patch = unittest.mock.patch("ensurepip.os.environ", {}) - self.os_environ = os_environ_patch.start() - self.addCleanup(os_environ_patch.stop) + # Avoid side effects on the actual os module + os_patch = unittest.mock.patch("ensurepip.os") + patched_os = os_patch.start() + self.addCleanup(os_patch.stop) + patched_os.path = os.path + self.os_environ = patched_os.environ = os.environ.copy() def test_basic_bootstrapping(self): ensurepip.bootstrap() |