diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2014-01-21 01:41:00 +0100 |
|---|---|---|
| committer | Victor Stinner <victor.stinner@gmail.com> | 2014-01-21 01:41:00 +0100 |
| commit | 809fdac29f14a317858f625f11f365661247cd05 (patch) | |
| tree | 4019d24b0a7a0ba89d68f1eaa6574912ae177a5e | |
| parent | 746235959c03eeda079b700c6c98e91efebd1b7a (diff) | |
| download | cpython-809fdac29f14a317858f625f11f365661247cd05.tar.gz | |
Issue #20311: select.epoll.poll() now rounds the timeout away from zero,
instead of rounding towards zero. For example, a timeout of one microsecond is
now rounded to one millisecond, instead of being rounded to zero.
| -rw-r--r-- | Lib/test/test_epoll.py | 11 | ||||
| -rw-r--r-- | Misc/NEWS | 4 | ||||
| -rw-r--r-- | Modules/selectmodule.c | 4 |
3 files changed, 18 insertions, 1 deletions
diff --git a/Lib/test/test_epoll.py b/Lib/test/test_epoll.py index 7f9547ff95..ad545d3a3b 100644 --- a/Lib/test/test_epoll.py +++ b/Lib/test/test_epoll.py @@ -46,6 +46,17 @@ class TestEPoll(unittest.TestCase): self.serverSocket.listen(1) self.connections = [self.serverSocket] + def test_timeout_rounding(self): + # epoll_wait() has a resolution of 1 millisecond, check if the timeout + # is correctly rounded to the upper bound + epoll = select.epoll() + self.addCleanup(epoll.close) + for timeout in (1e-2, 1e-3, 1e-4): + t0 = time.perf_counter() + epoll.poll(timeout) + dt = time.perf_counter() - t0 + self.assertGreaterEqual(dt, timeout) + def tearDown(self): for skt in self.connections: @@ -43,6 +43,10 @@ Core and Builtins Library ------- +- Issue #20311: select.epoll.poll() now rounds the timeout away from zero, + instead of rounding towards zero. For example, a timeout of one microsecond + is now rounded to one millisecond, instead of being rounded to zero. + - Issue #20262: Warnings are raised now when duplicate names are added in the ZIP file or too long ZIP file comment is truncated. diff --git a/Modules/selectmodule.c b/Modules/selectmodule.c index c492224ecb..ab2016a981 100644 --- a/Modules/selectmodule.c +++ b/Modules/selectmodule.c @@ -1379,7 +1379,9 @@ pyepoll_poll(pyEpoll_Object *self, PyObject *args, PyObject *kwds) return NULL; } else { - timeout = (int)(dtimeout * 1000.0); + /* epoll_wait() has a resolution of 1 millisecond, round away from zero + to wait *at least* dtimeout seconds. */ + timeout = (int)ceil(dtimeout * 1000.0); } if (maxevents == -1) { |