summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Panter <vadmium+py@gmail.com>2016-04-16 23:42:37 +0000
committerMartin Panter <vadmium+py@gmail.com>2016-04-16 23:42:37 +0000
commitea98cef77dfdfdc050d8033bd1b2fb865327f70a (patch)
treeabb7bf8f4e3600ecee1ce91676ac467064b62be8
parent3ea8ac2c5a160e7370c7764a8453699ea180f511 (diff)
downloadcpython-ea98cef77dfdfdc050d8033bd1b2fb865327f70a.tar.gz
Issue #26782: Add STARTUPINFO to subprocess.__all__ on Windows
-rw-r--r--Doc/whatsnew/3.6.rst2
-rw-r--r--Lib/subprocess.py3
-rw-r--r--Lib/test/test_subprocess.py3
-rw-r--r--Misc/NEWS2
4 files changed, 6 insertions, 4 deletions
diff --git a/Doc/whatsnew/3.6.rst b/Doc/whatsnew/3.6.rst
index ef10ef24d6..adb8b73f94 100644
--- a/Doc/whatsnew/3.6.rst
+++ b/Doc/whatsnew/3.6.rst
@@ -500,7 +500,7 @@ Changes in the Python API
attributes to match the documented APIs: :mod:`calendar`, :mod:`csv`,
:mod:`~xml.etree.ElementTree`, :mod:`enum`,
:mod:`fileinput`, :mod:`ftplib`, :mod:`logging`,
- :mod:`optparse`, :mod:`tarfile`, :mod:`threading` and
+ :mod:`optparse`, :mod:`subprocess`, :mod:`tarfile`, :mod:`threading` and
:mod:`wave`. This means they will export new symbols when ``import *``
is used. See :issue:`23883`.
diff --git a/Lib/subprocess.py b/Lib/subprocess.py
index 640519d8db..e9803497d5 100644
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -471,7 +471,8 @@ if _mswindows:
__all__.extend(["CREATE_NEW_CONSOLE", "CREATE_NEW_PROCESS_GROUP",
"STD_INPUT_HANDLE", "STD_OUTPUT_HANDLE",
"STD_ERROR_HANDLE", "SW_HIDE",
- "STARTF_USESTDHANDLES", "STARTF_USESHOWWINDOW"])
+ "STARTF_USESTDHANDLES", "STARTF_USESHOWWINDOW",
+ "STARTUPINFO"])
class Handle(int):
closed = False
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index b5c86f2953..7f70fd0001 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -2540,8 +2540,7 @@ class MiscTests(unittest.TestCase):
def test__all__(self):
"""Ensure that __all__ is populated properly."""
- # STARTUPINFO added to __all__ in 3.6
- intentionally_excluded = {"list2cmdline", "STARTUPINFO", "Handle"}
+ intentionally_excluded = {"list2cmdline", "Handle"}
exported = set(subprocess.__all__)
possible_exports = set()
import types
diff --git a/Misc/NEWS b/Misc/NEWS
index af2d65413a..c02cd3a234 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -245,6 +245,8 @@ Core and Builtins
Library
-------
+- Issue #26782: Add STARTUPINFO to subprocess.__all__ on Windows.
+
- Issue #26404: Add context manager to socketserver. Patch by Aviv Palivoda.
- Issue #26735: Fix :func:`os.urandom` on Solaris 11.3 and newer when reading