diff options
| author | Antoine Pitrou <solipsis@pitrou.net> | 2010-01-17 12:38:54 +0000 |
|---|---|---|
| committer | Antoine Pitrou <solipsis@pitrou.net> | 2010-01-17 12:38:54 +0000 |
| commit | 7728f7962a5f077c0f0fdaaadeb58425f514a687 (patch) | |
| tree | 55533666e9a0b8537d055ef8a7332eba1a609b1e /Include | |
| parent | ceaf8a5cd94d979f9736656ca9b37dca4ffa357d (diff) | |
| download | cpython-7728f7962a5f077c0f0fdaaadeb58425f514a687.tar.gz | |
Merged revisions 77573 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r77573 | antoine.pitrou | 2010-01-17 13:26:20 +0100 (dim., 17 janv. 2010) | 6 lines
Issue #7561: Operations on empty bytearrays (such as `int(bytearray())`)
could crash in many places because of the PyByteArray_AS_STRING() macro
returning NULL. The macro now returns a statically allocated empty
string instead.
........
Diffstat (limited to 'Include')
| -rw-r--r-- | Include/bytearrayobject.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/Include/bytearrayobject.h b/Include/bytearrayobject.h index 265b4bbdd0..8702e5a834 100644 --- a/Include/bytearrayobject.h +++ b/Include/bytearrayobject.h @@ -44,9 +44,13 @@ PyAPI_FUNC(char *) PyByteArray_AsString(PyObject *); PyAPI_FUNC(int) PyByteArray_Resize(PyObject *, Py_ssize_t); /* Macros, trading safety for speed */ -#define PyByteArray_AS_STRING(self) (assert(PyByteArray_Check(self)),((PyByteArrayObject *)(self))->ob_bytes) +#define PyByteArray_AS_STRING(self) \ + (assert(PyByteArray_Check(self)), \ + Py_SIZE(self) ? ((PyByteArrayObject *)(self))->ob_bytes : _PyByteArray_empty_string) #define PyByteArray_GET_SIZE(self) (assert(PyByteArray_Check(self)),Py_SIZE(self)) +extern char _PyByteArray_empty_string[]; + #ifdef __cplusplus } #endif |