Patch 1341 by Amaury Forgeot d'Arc.

This patch corrects test_fileinput on Windows: when redirecting stdout,
os.open should be given O_BINARY, because the file descriptor is then
wrapped in a text-mode file; os.fdopen(fd, "w").

1 files changed, 5 insertions, 3 deletions

diff --git a/Lib/fileinput.py b/Lib/fileinput.py
index 0d7ffada8c..e4c71ced6d 100644
--- a/Lib/fileinput.py
+++ b/Lib/fileinput.py
@@ -326,9 +326,11 @@ class FileInput:
                     except OSError:
                         self._output = open(self._filename, "w")
                     else:
-                        fd = os.open(self._filename,
-                                     os.O_CREAT | os.O_WRONLY | os.O_TRUNC,
-                                     perm)
+                        mode = os.O_CREAT | os.O_WRONLY | os.O_TRUNC
+                        if hasattr(os, 'O_BINARY'):
+                            mode |= os.O_BINARY
+
+                        fd = os.open(self._filename, mode, perm)
                         self._output = os.fdopen(fd, "w")
                         try:
                             if hasattr(os, 'chmod'):