summaryrefslogtreecommitdiff
path: root/Lib/test/test_urllib2.py
diff options
context:
space:
mode:
authorR David Murray <rdmurray@bitdance.com>2013-03-20 00:10:51 -0400
committerR David Murray <rdmurray@bitdance.com>2013-03-20 00:10:51 -0400
commite5f53bf11a8598331be0c9c895d585468ed0b2ac (patch)
tree799dad0853d458e1c172da83d23db36c56d286bc /Lib/test/test_urllib2.py
parent5145d56dce9c0741ca1390d30ea4e1ba6b1cb741 (diff)
downloadcpython-e5f53bf11a8598331be0c9c895d585468ed0b2ac.tar.gz
#17485: Delete the Content-Length header if the data attribute is deleted.
This is a follow on to issue 16464. Original patch by Daniel Wozniak.
Diffstat (limited to 'Lib/test/test_urllib2.py')
-rw-r--r--Lib/test/test_urllib2.py13
1 files changed, 11 insertions, 2 deletions
diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
index 3e19ecff09..0e0572383d 100644
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -1488,11 +1488,20 @@ class RequestTests(unittest.TestCase):
# if we change data we need to remove content-length header
# (cause it's most probably calculated for previous value)
def test_setting_data_should_remove_content_length(self):
- self.assertFalse("Content-length" in self.get.unredirected_hdrs)
+ self.assertNotIn("Content-length", self.get.unredirected_hdrs)
self.get.add_unredirected_header("Content-length", 42)
self.assertEqual(42, self.get.unredirected_hdrs["Content-length"])
self.get.data = "spam"
- self.assertFalse("Content-length" in self.get.unredirected_hdrs)
+ self.assertNotIn("Content-length", self.get.unredirected_hdrs)
+
+ # issue 17485 same for deleting data.
+ def test_deleting_data_should_remove_content_length(self):
+ self.assertNotIn("Content-length", self.get.unredirected_hdrs)
+ self.get.data = 'foo'
+ self.get.add_unredirected_header("Content-length", 3)
+ self.assertEqual(3, self.get.unredirected_hdrs["Content-length"])
+ del self.get.data
+ self.assertNotIn("Content-length", self.get.unredirected_hdrs)
def test_get_full_url(self):
self.assertEqual("http://www.python.org/~jeremy/",