diff options
author | Serhiy Storchaka <storchaka@gmail.com> | 2013-11-17 00:12:21 +0200 |
---|---|---|
committer | Serhiy Storchaka <storchaka@gmail.com> | 2013-11-17 00:12:21 +0200 |
commit | 2e82ca8432d70155d82e290d1c00c67c085e0738 (patch) | |
tree | d7622676595bfb83530e0a5680a117a0a8c2af2b /Lib/unittest/test/testmock/testhelpers.py | |
parent | bb2c2ba5d4692b2c4b509e4f1a1a5b8addaebd1a (diff) | |
download | cpython-2e82ca8432d70155d82e290d1c00c67c085e0738.tar.gz |
Issue #19594: Use specific asserts in unittest tests.
Diffstat (limited to 'Lib/unittest/test/testmock/testhelpers.py')
-rw-r--r-- | Lib/unittest/test/testmock/testhelpers.py | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/Lib/unittest/test/testmock/testhelpers.py b/Lib/unittest/test/testmock/testhelpers.py index 8bfb29391d..a362a2f784 100644 --- a/Lib/unittest/test/testmock/testhelpers.py +++ b/Lib/unittest/test/testmock/testhelpers.py @@ -177,7 +177,7 @@ class CallTest(unittest.TestCase): args = _Call(((1, 2, 3), {})) self.assertEqual(args, call(1, 2, 3)) self.assertEqual(call(1, 2, 3), args) - self.assertTrue(call(1, 2, 3) in [args]) + self.assertIn(call(1, 2, 3), [args]) def test_call_ne(self): @@ -793,7 +793,7 @@ class SpecSignatureTest(unittest.TestCase): mock_property = foo.foo # no spec on properties - self.assertTrue(isinstance(mock_property, MagicMock)) + self.assertIsInstance(mock_property, MagicMock) mock_property(1, 2, 3) mock_property.abc(4, 5, 6) mock_property.assert_called_once_with(1, 2, 3) @@ -826,19 +826,19 @@ class TestCallList(unittest.TestCase): mock(b=6) for kall in call(1, 2), call(a=3), call(3, 4), call(b=6): - self.assertTrue(kall in mock.call_args_list) + self.assertIn(kall, mock.call_args_list) calls = [call(a=3), call(3, 4)] - self.assertTrue(calls in mock.call_args_list) + self.assertIn(calls, mock.call_args_list) calls = [call(1, 2), call(a=3)] - self.assertTrue(calls in mock.call_args_list) + self.assertIn(calls, mock.call_args_list) calls = [call(3, 4), call(b=6)] - self.assertTrue(calls in mock.call_args_list) + self.assertIn(calls, mock.call_args_list) calls = [call(3, 4)] - self.assertTrue(calls in mock.call_args_list) + self.assertIn(calls, mock.call_args_list) - self.assertFalse(call('fish') in mock.call_args_list) - self.assertFalse([call('fish')] in mock.call_args_list) + self.assertNotIn(call('fish'), mock.call_args_list) + self.assertNotIn([call('fish')], mock.call_args_list) def test_call_list_str(self): |