diff options
author | Michael W. Hudson <mwh@python.net> | 2003-08-11 17:32:02 +0000 |
---|---|---|
committer | Michael W. Hudson <mwh@python.net> | 2003-08-11 17:32:02 +0000 |
commit | b8a22caacd90e6eb7f354f9fb582912d3f2b366b (patch) | |
tree | 59013b63a8ae07b02917ebdebf77c039f261560e /Objects/intobject.c | |
parent | af79e954e3123cd42a02b06d2bf39b297281140c (diff) | |
download | cpython-b8a22caacd90e6eb7f354f9fb582912d3f2b366b.tar.gz |
Add a couple of decrefs to error paths.
Now test_descr only appears to leak two references & I think this
are in fact illusory (it's to do with things getting resurrected in
__del__ methods & it's easy to be believe confusion occurs when that
happens <wink>). Woohoo!
Diffstat (limited to 'Objects/intobject.c')
-rw-r--r-- | Objects/intobject.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/Objects/intobject.c b/Objects/intobject.c index a3df3bab61..b97e2bc631 100644 --- a/Objects/intobject.c +++ b/Objects/intobject.c @@ -947,12 +947,14 @@ int_subtype_new(PyTypeObject *type, PyObject *args, PyObject *kwds) if (!PyLong_Check(tmp)) { PyErr_SetString(PyExc_ValueError, "value must convertable to an int"); + Py_DECREF(tmp); return NULL; } ival = PyLong_AsLong(tmp); - if (ival == -1 && PyErr_Occurred()) + if (ival == -1 && PyErr_Occurred()) { + Py_DECREF(tmp); return NULL; - + } } else { ival = ((PyIntObject *)tmp)->ob_ival; } |