Issue #29371: merge with 3.5

2 files changed, 53 insertions, 29 deletions

diff --git a/Python/clinic/bltinmodule.c.h b/Python/clinic/bltinmodule.c.h
index 4e2b1f1fe8..c88deef33f 100644
--- a/Python/clinic/bltinmodule.c.h
+++ b/Python/clinic/bltinmodule.c.h
@@ -93,8 +93,9 @@ builtin_format(PyObject *module, PyObject *args)
     PyObject *format_spec = NULL;
 
     if (!PyArg_ParseTuple(args, "O|U:format",
-        &value, &format_spec))
+        &value, &format_spec)) {
         goto exit;
+    }
     return_value = builtin_format_impl(module, value, format_spec);
 
 exit:
@@ -119,8 +120,9 @@ builtin_chr(PyObject *module, PyObject *arg)
     PyObject *return_value = NULL;
     int i;
 
-    if (!PyArg_Parse(arg, "i:chr", &i))
+    if (!PyArg_Parse(arg, "i:chr", &i)) {
         goto exit;
+    }
     return_value = builtin_chr_impl(module, i);
 
 exit:
@@ -146,7 +148,7 @@ PyDoc_STRVAR(builtin_compile__doc__,
 "in addition to any features explicitly specified.");
 
 #define BUILTIN_COMPILE_METHODDEF    \
-    {"compile", (PyCFunction)builtin_compile, METH_VARARGS|METH_KEYWORDS, builtin_compile__doc__},
+    {"compile", (PyCFunction)builtin_compile, METH_FASTCALL, builtin_compile__doc__},
 
 static PyObject *
 builtin_compile_impl(PyObject *module, PyObject *source, PyObject *filename,
@@ -154,10 +156,11 @@ builtin_compile_impl(PyObject *module, PyObject *source, PyObject *filename,
                      int optimize);
 
 static PyObject *
-builtin_compile(PyObject *module, PyObject *args, PyObject *kwargs)
+builtin_compile(PyObject *module, PyObject **args, Py_ssize_t nargs, PyObject *kwnames)
 {
     PyObject *return_value = NULL;
-    static char *_keywords[] = {"source", "filename", "mode", "flags", "dont_inherit", "optimize", NULL};
+    static const char * const _keywords[] = {"source", "filename", "mode", "flags", "dont_inherit", "optimize", NULL};
+    static _PyArg_Parser _parser = {"OO&s|iii:compile", _keywords, 0};
     PyObject *source;
     PyObject *filename;
     const char *mode;
@@ -165,9 +168,10 @@ builtin_compile(PyObject *module, PyObject *args, PyObject *kwargs)
     int dont_inherit = 0;
     int optimize = -1;
 
-    if (!PyArg_ParseTupleAndKeywords(args, kwargs, "OO&s|iii:compile", _keywords,
-        &source, PyUnicode_FSDecoder, &filename, &mode, &flags, &dont_inherit, &optimize))
+    if (!_PyArg_ParseStack(args, nargs, kwnames, &_parser,
+        &source, PyUnicode_FSDecoder, &filename, &mode, &flags, &dont_inherit, &optimize)) {
         goto exit;
+    }
     return_value = builtin_compile_impl(module, source, filename, mode, flags, dont_inherit, optimize);
 
 exit:
@@ -195,8 +199,9 @@ builtin_divmod(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "divmod",
         2, 2,
-        &x, &y))
+        &x, &y)) {
         goto exit;
+    }
     return_value = builtin_divmod_impl(module, x, y);
 
 exit:
@@ -232,8 +237,9 @@ builtin_eval(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "eval",
         1, 3,
-        &source, &globals, &locals))
+        &source, &globals, &locals)) {
         goto exit;
+    }
     return_value = builtin_eval_impl(module, source, globals, locals);
 
 exit:
@@ -269,8 +275,9 @@ builtin_exec(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "exec",
         1, 3,
-        &source, &globals, &locals))
+        &source, &globals, &locals)) {
         goto exit;
+    }
     return_value = builtin_exec_impl(module, source, globals, locals);
 
 exit:
@@ -321,8 +328,9 @@ builtin_hasattr(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "hasattr",
         2, 2,
-        &obj, &name))
+        &obj, &name)) {
         goto exit;
+    }
     return_value = builtin_hasattr_impl(module, obj, name);
 
 exit:
@@ -366,8 +374,9 @@ builtin_setattr(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "setattr",
         3, 3,
-        &obj, &name, &value))
+        &obj, &name, &value)) {
         goto exit;
+    }
     return_value = builtin_setattr_impl(module, obj, name, value);
 
 exit:
@@ -397,8 +406,9 @@ builtin_delattr(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "delattr",
         2, 2,
-        &obj, &name))
+        &obj, &name)) {
         goto exit;
+    }
     return_value = builtin_delattr_impl(module, obj, name);
 
 exit:
@@ -506,8 +516,9 @@ builtin_pow(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "pow",
         2, 3,
-        &x, &y, &z))
+        &x, &y, &z)) {
         goto exit;
+    }
     return_value = builtin_pow_impl(module, x, y, z);
 
 exit:
@@ -540,8 +551,9 @@ builtin_input(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "input",
         0, 1,
-        &prompt))
+        &prompt)) {
         goto exit;
+    }
     return_value = builtin_input_impl(module, prompt);
 
 exit:
@@ -584,8 +596,9 @@ builtin_sum(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "sum",
         1, 2,
-        &iterable, &start))
+        &iterable, &start)) {
         goto exit;
+    }
     return_value = builtin_sum_impl(module, iterable, start);
 
 exit:
@@ -618,8 +631,9 @@ builtin_isinstance(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "isinstance",
         2, 2,
-        &obj, &class_or_tuple))
+        &obj, &class_or_tuple)) {
         goto exit;
+    }
     return_value = builtin_isinstance_impl(module, obj, class_or_tuple);
 
 exit:
@@ -652,11 +666,12 @@ builtin_issubclass(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "issubclass",
         2, 2,
-        &cls, &class_or_tuple))
+        &cls, &class_or_tuple)) {
         goto exit;
+    }
     return_value = builtin_issubclass_impl(module, cls, class_or_tuple);
 
 exit:
     return return_value;
 }
-/*[clinic end generated code: output=9031270b64c794b8 input=a9049054013a1b77]*/
+/*[clinic end generated code: output=63483deb75805f7c input=a9049054013a1b77]*/
diff --git a/Python/clinic/import.c.h b/Python/clinic/import.c.h
index 05d79ac41b..b3460b061d 100644
--- a/Python/clinic/import.c.h
+++ b/Python/clinic/import.c.h
@@ -89,8 +89,9 @@ _imp__fix_co_filename(PyObject *module, PyObject *args)
     PyObject *path;
 
     if (!PyArg_ParseTuple(args, "O!U:_fix_co_filename",
-        &PyCode_Type, &code, &path))
+        &PyCode_Type, &code, &path)) {
         goto exit;
+    }
     return_value = _imp__fix_co_filename_impl(module, code, path);
 
 exit:
@@ -142,8 +143,9 @@ _imp_init_frozen(PyObject *module, PyObject *arg)
     PyObject *return_value = NULL;
     PyObject *name;
 
-    if (!PyArg_Parse(arg, "U:init_frozen", &name))
+    if (!PyArg_Parse(arg, "U:init_frozen", &name)) {
         goto exit;
+    }
     return_value = _imp_init_frozen_impl(module, name);
 
 exit:
@@ -168,8 +170,9 @@ _imp_get_frozen_object(PyObject *module, PyObject *arg)
     PyObject *return_value = NULL;
     PyObject *name;
 
-    if (!PyArg_Parse(arg, "U:get_frozen_object", &name))
+    if (!PyArg_Parse(arg, "U:get_frozen_object", &name)) {
         goto exit;
+    }
     return_value = _imp_get_frozen_object_impl(module, name);
 
 exit:
@@ -194,8 +197,9 @@ _imp_is_frozen_package(PyObject *module, PyObject *arg)
     PyObject *return_value = NULL;
     PyObject *name;
 
-    if (!PyArg_Parse(arg, "U:is_frozen_package", &name))
+    if (!PyArg_Parse(arg, "U:is_frozen_package", &name)) {
         goto exit;
+    }
     return_value = _imp_is_frozen_package_impl(module, name);
 
 exit:
@@ -220,8 +224,9 @@ _imp_is_builtin(PyObject *module, PyObject *arg)
     PyObject *return_value = NULL;
     PyObject *name;
 
-    if (!PyArg_Parse(arg, "U:is_builtin", &name))
+    if (!PyArg_Parse(arg, "U:is_builtin", &name)) {
         goto exit;
+    }
     return_value = _imp_is_builtin_impl(module, name);
 
 exit:
@@ -246,8 +251,9 @@ _imp_is_frozen(PyObject *module, PyObject *arg)
     PyObject *return_value = NULL;
     PyObject *name;
 
-    if (!PyArg_Parse(arg, "U:is_frozen", &name))
+    if (!PyArg_Parse(arg, "U:is_frozen", &name)) {
         goto exit;
+    }
     return_value = _imp_is_frozen_impl(module, name);
 
 exit:
@@ -277,8 +283,9 @@ _imp_create_dynamic(PyObject *module, PyObject *args)
 
     if (!PyArg_UnpackTuple(args, "create_dynamic",
         1, 2,
-        &spec, &file))
+        &spec, &file)) {
         goto exit;
+    }
     return_value = _imp_create_dynamic_impl(module, spec, file);
 
 exit:
@@ -308,8 +315,9 @@ _imp_exec_dynamic(PyObject *module, PyObject *mod)
     int _return_value;
 
     _return_value = _imp_exec_dynamic_impl(module, mod);
-    if ((_return_value == -1) && PyErr_Occurred())
+    if ((_return_value == -1) && PyErr_Occurred()) {
         goto exit;
+    }
     return_value = PyLong_FromLong((long)_return_value);
 
 exit:
@@ -337,8 +345,9 @@ _imp_exec_builtin(PyObject *module, PyObject *mod)
     int _return_value;
 
     _return_value = _imp_exec_builtin_impl(module, mod);
-    if ((_return_value == -1) && PyErr_Occurred())
+    if ((_return_value == -1) && PyErr_Occurred()) {
         goto exit;
+    }
     return_value = PyLong_FromLong((long)_return_value);
 
 exit:
@@ -352,4 +361,4 @@ exit:
 #ifndef _IMP_EXEC_DYNAMIC_METHODDEF
     #define _IMP_EXEC_DYNAMIC_METHODDEF
 #endif /* !defined(_IMP_EXEC_DYNAMIC_METHODDEF) */
-/*[clinic end generated code: output=90ad6e5833e6170d input=a9049054013a1b77]*/
+/*[clinic end generated code: output=d24d7f73702a907f input=a9049054013a1b77]*/