summaryrefslogtreecommitdiff
path: root/Python
diff options
context:
space:
mode:
authorChristian Heimes <christian@python.org>2016-09-23 20:26:30 +0200
committerChristian Heimes <christian@python.org>2016-09-23 20:26:30 +0200
commiteb54e383fbe29fd13d1d92e478caa1bd6b18d098 (patch)
tree3cfa2feb47c39e61ad8cca3e40e9e5ab86d433fe /Python
parentb84786c09c93202987ca0fd885d7ff4aa95ce150 (diff)
downloadcpython-eb54e383fbe29fd13d1d92e478caa1bd6b18d098.tar.gz
Issue #28100: Refactor error messages, patch by Ivan Levkivskyi
Diffstat (limited to 'Python')
-rw-r--r--Python/symtable.c20
1 files changed, 8 insertions, 12 deletions
diff --git a/Python/symtable.c b/Python/symtable.c
index f762904240..bf30eccdab 100644
--- a/Python/symtable.c
+++ b/Python/symtable.c
@@ -1282,15 +1282,13 @@ symtable_visit_stmt(struct symtable *st, stmt_ty s)
VISIT_QUIT(st, 0);
if (cur & (DEF_LOCAL | USE | DEF_ANNOT)) {
char* msg;
- if (cur & DEF_ANNOT) {
+ if (cur & USE) {
+ msg = GLOBAL_AFTER_USE;
+ } else if (cur & DEF_ANNOT) {
msg = GLOBAL_ANNOT;
- }
- if (cur & DEF_LOCAL) {
+ } else { /* DEF_LOCAL */
msg = GLOBAL_AFTER_ASSIGN;
}
- else {
- msg = GLOBAL_AFTER_USE;
- }
PyErr_Format(PyExc_SyntaxError,
msg, name);
PyErr_SyntaxLocationObject(st->st_filename,
@@ -1315,15 +1313,13 @@ symtable_visit_stmt(struct symtable *st, stmt_ty s)
VISIT_QUIT(st, 0);
if (cur & (DEF_LOCAL | USE | DEF_ANNOT)) {
char* msg;
- if (cur & DEF_ANNOT) {
+ if (cur & USE) {
+ msg = NONLOCAL_AFTER_USE;
+ } else if (cur & DEF_ANNOT) {
msg = NONLOCAL_ANNOT;
- }
- if (cur & DEF_LOCAL) {
+ } else { /* DEF_LOCAL */
msg = NONLOCAL_AFTER_ASSIGN;
}
- else {
- msg = NONLOCAL_AFTER_USE;
- }
PyErr_Format(PyExc_SyntaxError, msg, name);
PyErr_SyntaxLocationObject(st->st_filename,
s->lineno,